[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[ https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226545#comment-16226545 ] Sunil G commented on YARN-7398: --- Thanks [~varun_saxena]. Committing to branch-2 > LICENSE.txt is broken in branch-2 by YARN-4849 merge > > > Key: YARN-7398 > URL: https://issues.apache.org/jira/browse/YARN-7398 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.9.0 >Reporter: Subru Krishnan >Assignee: Varun Saxena >Priority: Blocker > Attachments: YARN-7398.branch-2.01.patch, > YARN-7398.branch-2.02.patch, YARN-7398.branch-2.03.patch > > > YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to > have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest > etc, so I have reverted it. > [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses > asap. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[
https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226532#comment-16226532
]
Hadoop QA commented on YARN-7398:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:17213a0 |
| JIRA Issue | YARN-7398 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894946/YARN-7398.branch-2.03.patch
|
| Optional Tests | asflicense |
| uname | Linux 35d2b890f65b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | branch-2 / 76ec5ea |
| maven | version: Apache Maven 3.3.9
(bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/18261/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> LICENSE.txt is broken in branch-2 by YARN-4849 merge
>
>
> Key: YARN-7398
> URL: https://issues.apache.org/jira/browse/YARN-7398
> Project: Hadoop YARN
> Issue Type: Sub-task
>Affects Versions: 2.9.0
>Reporter: Subru Krishnan
>Assignee: Varun Saxena
>Priority: Blocker
> Attachments: YARN-7398.branch-2.01.patch,
> YARN-7398.branch-2.02.patch, YARN-7398.branch-2.03.patch
>
>
> YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to
> have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest
> etc, so I have reverted it.
> [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses
> asap.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[ https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226502#comment-16226502 ] Varun Saxena commented on YARN-7398: Thanks Sunil for the latest patch including missing dependencies. +1 LGTM. > LICENSE.txt is broken in branch-2 by YARN-4849 merge > > > Key: YARN-7398 > URL: https://issues.apache.org/jira/browse/YARN-7398 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.9.0 >Reporter: Subru Krishnan >Assignee: Varun Saxena >Priority: Blocker > Attachments: YARN-7398.branch-2.01.patch, YARN-7398.branch-2.02.patch > > > YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to > have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest > etc, so I have reverted it. > [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses > asap. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[ https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226439#comment-16226439 ] Sunil G commented on YARN-7398: --- +1 Committing this if no objections. [~varun_saxena], please help to check. > LICENSE.txt is broken in branch-2 by YARN-4849 merge > > > Key: YARN-7398 > URL: https://issues.apache.org/jira/browse/YARN-7398 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.9.0 >Reporter: Subru Krishnan >Assignee: Varun Saxena >Priority: Blocker > Attachments: YARN-7398.branch-2.01.patch, YARN-7398.branch-2.02.patch > > > YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to > have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest > etc, so I have reverted it. > [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses > asap. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[
https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226437#comment-16226437
]
Hadoop QA commented on YARN-7398:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 51s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:17213a0 |
| JIRA Issue | YARN-7398 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894935/YARN-7398.branch-2.02.patch
|
| Optional Tests | asflicense |
| uname | Linux 1fb540abdef5 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | branch-2 / 76ec5ea |
| maven | version: Apache Maven 3.3.9
(bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/18259/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> LICENSE.txt is broken in branch-2 by YARN-4849 merge
>
>
> Key: YARN-7398
> URL: https://issues.apache.org/jira/browse/YARN-7398
> Project: Hadoop YARN
> Issue Type: Sub-task
>Affects Versions: 2.9.0
>Reporter: Subru Krishnan
>Assignee: Varun Saxena
>Priority: Blocker
> Attachments: YARN-7398.branch-2.01.patch, YARN-7398.branch-2.02.patch
>
>
> YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to
> have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest
> etc, so I have reverted it.
> [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses
> asap.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[
https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226421#comment-16226421
]
Sunil G commented on YARN-7398:
---
[~varun_saxena]
One quick comment. We also need to ass below entries to LICENSE.txt, i ll
quickly share patch.
{code}
"bower-shrinkwrap-resolver-ext": "0.1.0",
"broccoli-merge-trees": "1.1.1",
"ember-cli-moment-shim": "0.7.3",
"ember-cli-numeral": "^0.2.0",
"ember-lodash": "0.0.10",
"testem": "0.9.11"
{code}
> LICENSE.txt is broken in branch-2 by YARN-4849 merge
>
>
> Key: YARN-7398
> URL: https://issues.apache.org/jira/browse/YARN-7398
> Project: Hadoop YARN
> Issue Type: Sub-task
>Affects Versions: 2.9.0
>Reporter: Subru Krishnan
>Assignee: Varun Saxena
>Priority: Blocker
> Attachments: YARN-7398.branch-2.01.patch
>
>
> YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to
> have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest
> etc, so I have reverted it.
> [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses
> asap.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[
https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222626#comment-16222626
]
Varun Saxena commented on YARN-7398:
The said section was removed in HADOOP-13780 so I did not keep it here as well.
What we have is a section like this in the LICENSE file, both in trunk and
branch-2:
{noformat}
D3 is available under a 3-clause BSD license. For details, see:
hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/d3-LICENSE
{noformat}
However, as I mentioned in one of the comments above, we are not drawing a
direct linkage with web UI here even though we say D3 is under 3-clause BSD
license. The d3-LICENSE is placed under SLS folder as well. If this is an issue
(seems to be), it needs to be fixed in trunk as well, so possibly in another
JIRA.
> LICENSE.txt is broken in branch-2 by YARN-4849 merge
>
>
> Key: YARN-7398
> URL: https://issues.apache.org/jira/browse/YARN-7398
> Project: Hadoop YARN
> Issue Type: Sub-task
>Affects Versions: 2.9.0
>Reporter: Subru Krishnan
>Assignee: Varun Saxena
>Priority: Blocker
> Attachments: YARN-7398.branch-2.01.patch
>
>
> YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to
> have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest
> etc, so I have reverted it.
> [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses
> asap.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[
https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222611#comment-16222611
]
Sunil G commented on YARN-7398:
---
I could see the major changes only for Mozilla License. And that is added in
YARN-5433 which is not UI related license.
But following line is missing.
{code}
+The binary distribution of this product bundles these dependencies under the
+following license:
+D3 v3.5.6
{code}
> LICENSE.txt is broken in branch-2 by YARN-4849 merge
>
>
> Key: YARN-7398
> URL: https://issues.apache.org/jira/browse/YARN-7398
> Project: Hadoop YARN
> Issue Type: Sub-task
>Affects Versions: 2.9.0
>Reporter: Subru Krishnan
>Assignee: Varun Saxena
>Priority: Blocker
> Attachments: YARN-7398.branch-2.01.patch
>
>
> YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to
> have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest
> etc, so I have reverted it.
> [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses
> asap.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[ https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222593#comment-16222593 ] Varun Saxena commented on YARN-7398: Yes, unless there are further comments. However, I am not sure if web UI needs to explicitly mentioned for D3 as per one of my comments. > LICENSE.txt is broken in branch-2 by YARN-4849 merge > > > Key: YARN-7398 > URL: https://issues.apache.org/jira/browse/YARN-7398 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.9.0 >Reporter: Subru Krishnan >Assignee: Varun Saxena >Priority: Blocker > Attachments: YARN-7398.branch-2.01.patch > > > YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to > have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest > etc, so I have reverted it. > [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses > asap. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[ https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222314#comment-16222314 ] Sunil G commented on YARN-7398: --- [~varun_saxena] Could I consider the attached patch as final patch after your analysis. > LICENSE.txt is broken in branch-2 by YARN-4849 merge > > > Key: YARN-7398 > URL: https://issues.apache.org/jira/browse/YARN-7398 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.9.0 >Reporter: Subru Krishnan >Assignee: Varun Saxena >Priority: Blocker > Attachments: YARN-7398.branch-2.01.patch > > > YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to > have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest > etc, so I have reverted it. > [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses > asap. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[ https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222301#comment-16222301 ] Varun Saxena commented on YARN-7398: [~subru], but the changes brought in for UI merge have already been reverted from branch-2. So, LICENSE file on branch-2 currently is effectively equivalent to what it was before UI merge, barring a couple of recent commits. The changes pointed out above were incorrectly brought in, I presume due to a conflict which may have arisen during cherry-picking. But these changes are not required and the current patch is on top of current state of branch-2 and contains only the required changes in LICENSE for Web UI merge. > LICENSE.txt is broken in branch-2 by YARN-4849 merge > > > Key: YARN-7398 > URL: https://issues.apache.org/jira/browse/YARN-7398 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.9.0 >Reporter: Subru Krishnan >Assignee: Varun Saxena >Priority: Blocker > Attachments: YARN-7398.branch-2.01.patch > > > YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to > have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest > etc, so I have reverted it. > [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses > asap. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[
https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221328#comment-16221328
]
Subru Krishnan commented on YARN-7398:
--
[~varun_saxena], thanks for your prompt response. I am generally +1 on keeping
the LICENSE consistent with trunk especially considering the work done in
HADOOP-13780 but my concern from the branch-2 backport is we dropped a few
licenses and picked up few wrong versions (Java 8 instead of 7).
Captured a couple below for illustration:
{code}
@@ -616,8 +614,6 @@ For:
hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/jquery-1.10.2.min.js
hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/jquery.js
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery
-Apache HBase - Server which contains JQuery minified javascript library
version 1.8.3
-Microsoft JDBC Driver for SQLServer - version 6.2.1.jre7
Copyright jQuery Foundation and other contributors, https://jquery.org/
@@ -693,9 +689,8 @@
hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/d3-LICENSE
The binary distribution of this product bundles these dependencies under the
following license:
-HSQLDB Database 2.3.4
+HSQLDB Database 2.0.0
-(HSQL License)
"COPYRIGHTS AND LICENSES (based on BSD License)
{code}
> LICENSE.txt is broken in branch-2 by YARN-4849 merge
>
>
> Key: YARN-7398
> URL: https://issues.apache.org/jira/browse/YARN-7398
> Project: Hadoop YARN
> Issue Type: Sub-task
>Affects Versions: 2.9.0
>Reporter: Subru Krishnan
>Assignee: Varun Saxena
>Priority: Blocker
> Attachments: YARN-7398.branch-2.01.patch
>
>
> YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to
> have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest
> etc, so I have reverted it.
> [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses
> asap.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[ https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221222#comment-16221222 ] Vrushali C commented on YARN-7398: -- Hi [~wangda] Looks like Varun has made this file consistent with trunk as per his latest comment. Since it's already night in India, thought of asking you if you have any thoughts on that? > LICENSE.txt is broken in branch-2 by YARN-4849 merge > > > Key: YARN-7398 > URL: https://issues.apache.org/jira/browse/YARN-7398 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Subru Krishnan >Assignee: Varun Saxena >Priority: Blocker > Attachments: YARN-7398.branch-2.01.patch > > > YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to > have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest > etc, so I have reverted it. > [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses > asap. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[
https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220831#comment-16220831
]
Hadoop QA commented on YARN-7398:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 19m
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 20m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:17213a0 |
| JIRA Issue | YARN-7398 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894125/YARN-7398.branch-2.01.patch
|
| Optional Tests | asflicense |
| uname | Linux 1cc0435a8110 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | branch-2 / 13f1a7e |
| maven | version: Apache Maven 3.3.9
(bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/18149/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> LICENSE.txt is broken in branch-2 by YARN-4849 merge
>
>
> Key: YARN-7398
> URL: https://issues.apache.org/jira/browse/YARN-7398
> Project: Hadoop YARN
> Issue Type: Bug
>Affects Versions: 2.9.0
>Reporter: Subru Krishnan
>Assignee: Varun Saxena
>Priority: Blocker
> Attachments: YARN-7398.branch-2.01.patch
>
>
> YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to
> have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest
> etc, so I have reverted it.
> [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses
> asap.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[ https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220751#comment-16220751 ] Varun Saxena commented on YARN-7398: [~sunilg], this is based on changes made in HADOOP-13780. I have basically made LICENSE.txt consistent with trunk. We already had a host of dependencies covered under the MIT License. These web UI dependencies mentioned in LICENSE were merged together with other dependecies in HADOOP-13780. So, this patch also takes care of that. Another section related to D3 was also removed in HADOOP-13780. This is because we have already mentioned that D3 is available under a 3-clause BSD license elsewhere. But this is mentioned for d3.v3.js under sls. Maybe we should mention that this applies to web UI too and move the d3-LICENSE information from sls project to LICENSE.txt. If we do so, this should be fixed in trunk too. Thoughts? > LICENSE.txt is broken in branch-2 by YARN-4849 merge > > > Key: YARN-7398 > URL: https://issues.apache.org/jira/browse/YARN-7398 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Subru Krishnan >Assignee: Varun Saxena >Priority: Blocker > Attachments: YARN-7398.branch-2.01.patch > > > YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to > have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest > etc, so I have reverted it. > [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses > asap. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[ https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220416#comment-16220416 ] Sunil G commented on YARN-7398: --- [~varun_saxena], it seems we miss a bit here. pls refer https://issues.apache.org/jira/secure/attachment/12836099/YARN-4734.19.patch#file-2 and check for LICENSE.txt. These are the changes which we need. > LICENSE.txt is broken in branch-2 by YARN-4849 merge > > > Key: YARN-7398 > URL: https://issues.apache.org/jira/browse/YARN-7398 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Subru Krishnan >Assignee: Varun Saxena >Priority: Blocker > Attachments: YARN-7398.branch-2.01.patch > > > YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to > have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest > etc, so I have reverted it. > [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses > asap. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7398) LICENSE.txt is broken in branch-2 by YARN-4849 merge
[ https://issues.apache.org/jira/browse/YARN-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219780#comment-16219780 ] Subru Krishnan commented on YARN-7398: -- Assigning it to [~varun_saxena] based on offline discussion with [~leftnoteasy] as the LICENSE.txt is fine in trunk and this seems to have happened during YARN UI v2 branch-2 merge. cc [~vrushalic]. Can one of you take a look? Thanks. > LICENSE.txt is broken in branch-2 by YARN-4849 merge > > > Key: YARN-7398 > URL: https://issues.apache.org/jira/browse/YARN-7398 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Subru Krishnan >Assignee: Varun Saxena >Priority: Blocker > > YARN-4849 (commit sha id 56654d8820f345fdefd6a3f81836125aa67adbae) seems to > have been based out of stale version of LICENSE.txt, for e.g: HSQLDB, gtest > etc, so I have reverted it. > [~leftnoteasy]/[~sunilg], can you guys take a look and fix the UI v2 licenses > asap. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
