[jira] [Commented] (YARN-78) Change UnmanagedAMLauncher to use YarnClientImpl
[ https://issues.apache.org/jira/browse/YARN-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13453244#comment-13453244 ] Hadoop QA commented on YARN-78: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544673/YARN-78.4.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/35//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/35//console This message is automatically generated. Change UnmanagedAMLauncher to use YarnClientImpl Key: YARN-78 URL: https://issues.apache.org/jira/browse/YARN-78 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.0.2-alpha, 2.0.0-alpha Reporter: Bikas Saha Assignee: Bikas Saha Attachments: YARN-78.1.patch, YARN-78.2.patch, YARN-78.3.patch, YARN-78.4.patch YARN-29 added a common client impl to talk to the RM. Use that in the UnmanagedAMLauncher. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-78) Change UnmanagedAMLauncher to use YarnClientImpl
[ https://issues.apache.org/jira/browse/YARN-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449027#comment-13449027 ] Bikas Saha commented on YARN-78: I have updated the patch to now call stop() and existing test now works. Implementing Service is a good suggestion but I am holding back on that. Service interface implies existence of certain service states which AMLauncher is not satisfying. Also, there are a number of other interface functions like register etc which dont apply to AMLauncher. Going forward if this evolves from being an executable to a library that other apps build on, then it will be useful to implement the full fledged service interface like you suggest. Let me know if this sounds good to you. Change UnmanagedAMLauncher to use YarnClientImpl Key: YARN-78 URL: https://issues.apache.org/jira/browse/YARN-78 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.1.0-alpha, 2.2.0-alpha Reporter: Bikas Saha Assignee: Bikas Saha Attachments: YARN-78.1.patch, YARN-78.2.patch YARN-29 added a common client impl to talk to the RM. Use that in the UnmanagedAMLauncher. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-78) Change UnmanagedAMLauncher to use YarnClientImpl
[
https://issues.apache.org/jira/browse/YARN-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448140#comment-13448140
]
Vinod Kumar Vavilapalli commented on YARN-78:
-
Makes sense.
But you still need to fix the run() method to make sure client is stopped
correctly. I think instead of my earlier suggestion of extending
YarnClientImpl, implementing Service is better for you since you can then shut
down client as part of {{stop()}} and create it as part of {{start()}}.
Change UnmanagedAMLauncher to use YarnClientImpl
Key: YARN-78
URL: https://issues.apache.org/jira/browse/YARN-78
Project: Hadoop YARN
Issue Type: Bug
Affects Versions: 2.1.0-alpha, 2.2.0-alpha
Reporter: Bikas Saha
Assignee: Bikas Saha
Attachments: YARN-78.1.patch
YARN-29 added a common client impl to talk to the RM. Use that in the
UnmanagedAMLauncher.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
