[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-08 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642214#comment-16642214
 ] 

Íñigo Goiri commented on YARN-8843:
---

Cherry-picked to branch-3.2.

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Manikandan R
>Priority: Minor
> Fix For: 3.2.0, 3.3.0
>
> Attachments: YARN-8843.000.patch, YARN-8843.001.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-08 Thread Sunil Govindan (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642170#comment-16642170
 ] 

Sunil Govindan commented on YARN-8843:
--

Yes. Lets get this in for 3.2 as well.

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Manikandan R
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: YARN-8843.000.patch, YARN-8843.001.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-08 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642168#comment-16642168
 ] 

Hudson commented on YARN-8843:
--

FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #15140 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/15140/])
YARN-8843. updateNodeResource does not support units for memory. (inigoiri: rev 
745f64012a2a912d5f0a36bbda89dc638e1715cb)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java


> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Manikandan R
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: YARN-8843.000.patch, YARN-8843.001.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-08 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642154#comment-16642154
 ] 

Íñigo Goiri commented on YARN-8843:
---

Assigned it to [~maniraj...@gmail.com], committing to trunk and branch-3.2.
Do you guys want this anywhere else?

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Manikandan R
>Priority: Minor
> Attachments: YARN-8843.000.patch, YARN-8843.001.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-08 Thread Sunil Govindan (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642130#comment-16642130
 ] 

Sunil Govindan commented on YARN-8843:
--

Looks good to me as well. [~elgoiri] pls feel free to get it in.

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Íñigo Goiri
>Priority: Minor
> Attachments: YARN-8843.000.patch, YARN-8843.001.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-08 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642093#comment-16642093
 ] 

Íñigo Goiri commented on YARN-8843:
---

The fix in [^YARN-8843.001.patch] LGTM.

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Íñigo Goiri
>Priority: Minor
> Attachments: YARN-8843.000.patch, YARN-8843.001.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-08 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641477#comment-16641477
 ] 

Hadoop QA commented on YARN-8843:
-

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m 
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 23s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
25s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 41s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 24m 
55s{color} | {color:green} hadoop-yarn-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
32s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 77m 21s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | YARN-8843 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12942771/YARN-8843.001.patch |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 99b318c0d6d2 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 228dc19 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/22095/testReport/ |
| Max. process+thread count | 678 (vs. ulimit of 1) |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/22095/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> updateNodeResource does not support units for memory
> 
>
> Key:

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-07 Thread Sunil Govindan (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641375#comment-16641375
 ] 

Sunil Govindan commented on YARN-8843:
--

Thanks [~maniraj...@gmail.com]. This change looks cleaner to me. 

[~elgoiri], ideally ResourceUtils.parseResourceValue was used in places where 
it was not supposed to be used. [~maniraj...@gmail.com], cud u pls help to 
assess if we can mark ResourceUtils.parseResourceValue as private if possible. 
What is the need to expose this as public and cause such issues. Thanks.

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Íñigo Goiri
>Priority: Minor
> Attachments: YARN-8843.000.patch, YARN-8843.001.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-07 Thread Manikandan R (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641333#comment-16641333
 ] 

Manikandan R commented on YARN-8843:


Made changes in updateNodeResource flow to fix this problem. Can you please 
check?

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Íñigo Goiri
>Priority: Minor
> Attachments: YARN-8843.000.patch, YARN-8843.001.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-05 Thread Sunil Govindan (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639614#comment-16639614
 ] 

Sunil Govindan commented on YARN-8843:
--

updateNodeResource api is not handling this resource conversion and causing 
this pblm. So ideally its better we work in that interface.

[~maniraj...@gmail.com], cud u pls confirm whether updateNodeResource api can 
handle resource conversion ?

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Íñigo Goiri
>Priority: Minor
> Attachments: YARN-8843.000.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-04 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638344#comment-16638344
 ] 

Íñigo Goiri commented on YARN-8843:
---

[~sunilg], the behavior is broken. If you try the unit test without the fix, 
you'll see that the resource is 1MB. I saw this very same behavior in my 
cluster; I set the memory to 1Gi and the memory for the NM becomes 1MB. I'm not 
sure if the fix I proposed is in the best place but the unit test is. 

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Íñigo Goiri
>Priority: Minor
> Attachments: YARN-8843.000.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-04 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638349#comment-16638349
 ] 

Íñigo Goiri commented on YARN-8843:
---

I see YARN-7159 is in 3.2.
I tested with 3.1.1 and that's where I saw the issue.
However, I verified that trunk had the issue. 
Do you mind running the unit test with my change to verify is broken there? 

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Íñigo Goiri
>Priority: Minor
> Attachments: YARN-8843.000.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-04 Thread Sunil Govindan (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638350#comment-16638350
 ] 

Sunil Govindan commented on YARN-8843:
--

Thanks. As per my understanding, this should ideally not happen. So let me 
recheck again.

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Íñigo Goiri
>Priority: Minor
> Attachments: YARN-8843.000.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-04 Thread Sunil Govindan (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638329#comment-16638329
 ] 

Sunil Govindan commented on YARN-8843:
--

[~elgoiri] is this change needed?

Internally while we use Resource object within RM, these units ll be same. Over 
the wire (through proto), there is a chance if different unit. YARN-7159 has 
fixed this pblm.

So I am bit confused why this is needed, did u see any pblm. Could u pls confirm

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Íñigo Goiri
>Priority: Minor
> Attachments: YARN-8843.000.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-04 Thread Manikandan R (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637879#comment-16637879
 ] 

Manikandan R commented on YARN-8843:


YARN-7159 has tried to keep all units conversion changes in common place. Looks 
like this code path is different from ResourcePBImpl flow? cc [~sunilg] Can you 
pls confirm?

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Íñigo Goiri
>Priority: Minor
> Attachments: YARN-8843.000.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-03 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637708#comment-16637708
 ] 

Hadoop QA commented on YARN-8843:
-

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m 
 9s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m 
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
15m  7s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  7m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
13m 46s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  
2s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 26m 
37s{color} | {color:green} hadoop-yarn-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
56s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}114m 44s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | YARN-8843 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12942337/YARN-8843.000.patch |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  findbugs  checkstyle  |
| uname | Linux f3e7469fea0a 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 1dc0adf |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/22052/testReport/ |
| Max. process+thread count | 682 (vs. ulimit of 1) |
| modules | C:

[jira] [Commented] (YARN-8843) updateNodeResource does not support units for memory

2018-10-03 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637629#comment-16637629
 ] 

Íñigo Goiri commented on YARN-8843:
---

I think this was introduced in YARN-6761.
[~vvasudev], [~templedf], do you guys mind taking a look.

In addition to the test for updateNodeResource, I think we should test 
somewhere close to {{Resource}} or {{ResourceInformation}}.

> updateNodeResource does not support units for memory
> 
>
> Key: YARN-8843
> URL: https://issues.apache.org/jira/browse/YARN-8843
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Íñigo Goiri
>Assignee: Íñigo Goiri
>Priority: Minor
> Attachments: YARN-8843.000.patch
>
>
> When doing -updateNodeResource memory-mb=1Gi, it assigns 1MB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org