[jira] [Commented] (YARN-9096) Some GpuResourcePlugin and ResourcePluginManager methods are synchronized unnecessarily
[
https://issues.apache.org/jira/browse/YARN-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903702#comment-16903702
]
Hudson commented on YARN-9096:
--
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17071 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/17071/])
YARN-9096: Some GpuResourcePlugin and ResourcePluginManager methods are
(snemeth: rev 742e30b47381ad63e2b2fe63738cd0fe6cbce106)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/gpu/GpuResourcePlugin.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/ResourcePluginManager.java
> Some GpuResourcePlugin and ResourcePluginManager methods are synchronized
> unnecessarily
> ---
>
> Key: YARN-9096
> URL: https://issues.apache.org/jira/browse/YARN-9096
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Gergely Pollak
>Priority: Major
> Fix For: 3.3.0, 3.2.1, 3.1.3
>
> Attachments: YARN-9096.001.patch, YARN-9096.002.patch,
> YARN-9096.002.patch
>
>
> These methods are not used concurrently, they are part of the initialization
> code of NM that happens from one thread.
> This is the list of the call hierarchies:
> 1. GpuResourcePlugin.initialize + ResourcePluginManager.initialize
>
> {code:java}
> GpuResourcePlugin.initialize(Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> ResourcePluginManager.initialize(Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin)
> NodeManager.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager){code}
>
>
> 2. GpuResourcePlugin.createResourceHandler:
>
> {code:java}
> GpuResourcePlugin.createResourceHandler(Context, CGroupsHandler,
> PrivilegedOperationExecutor)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> ResourceHandlerModule.addHandlersFromConfiguredResourcePlugins(List,
> Configuration, Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ResourceHandlerModule.initializeConfiguredResourceHandlerChain(Configuration,
> Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ResourceHandlerModule.getConfiguredResourceHandlerChain(Configuration,
> Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ContainerScheduler.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.scheduler)
> LinuxContainerExecutor.init(Context)
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}
>
> 3. GpuResourcePlugin.getNodeResourceHandlerInstance:
>
> {code:java}
> GpuResourcePlugin.getNodeResourceHandlerInstance()
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> NodeStatusUpdaterImpl.updateConfiguredResourcesViaPlugins(Resource)(2 usages)
> (org.apache.hadoop.yarn.server.nodemanager)
> NodeStatusUpdaterImpl.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9096) Some GpuResourcePlugin and ResourcePluginManager methods are synchronized unnecessarily
[
https://issues.apache.org/jira/browse/YARN-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903678#comment-16903678
]
Szilard Nemeth commented on YARN-9096:
--
Hi [[~shuzirra]!
Thanks for the latest patch, committed to trunk, branch-3.2 and branch-3.1!
Thanks [~adam.antal]] for the reviews!
> Some GpuResourcePlugin and ResourcePluginManager methods are synchronized
> unnecessarily
> ---
>
> Key: YARN-9096
> URL: https://issues.apache.org/jira/browse/YARN-9096
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Gergely Pollak
>Priority: Major
> Attachments: YARN-9096.001.patch, YARN-9096.002.patch,
> YARN-9096.002.patch
>
>
> These methods are not used concurrently, they are part of the initialization
> code of NM that happens from one thread.
> This is the list of the call hierarchies:
> 1. GpuResourcePlugin.initialize + ResourcePluginManager.initialize
>
> {code:java}
> GpuResourcePlugin.initialize(Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> ResourcePluginManager.initialize(Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin)
> NodeManager.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager){code}
>
>
> 2. GpuResourcePlugin.createResourceHandler:
>
> {code:java}
> GpuResourcePlugin.createResourceHandler(Context, CGroupsHandler,
> PrivilegedOperationExecutor)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> ResourceHandlerModule.addHandlersFromConfiguredResourcePlugins(List,
> Configuration, Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ResourceHandlerModule.initializeConfiguredResourceHandlerChain(Configuration,
> Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ResourceHandlerModule.getConfiguredResourceHandlerChain(Configuration,
> Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ContainerScheduler.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.scheduler)
> LinuxContainerExecutor.init(Context)
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}
>
> 3. GpuResourcePlugin.getNodeResourceHandlerInstance:
>
> {code:java}
> GpuResourcePlugin.getNodeResourceHandlerInstance()
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> NodeStatusUpdaterImpl.updateConfiguredResourcesViaPlugins(Resource)(2 usages)
> (org.apache.hadoop.yarn.server.nodemanager)
> NodeStatusUpdaterImpl.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9096) Some GpuResourcePlugin and ResourcePluginManager methods are synchronized unnecessarily
[
https://issues.apache.org/jira/browse/YARN-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899953#comment-16899953
]
Hadoop QA commented on YARN-9096:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
42s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
40s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 29s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:
The patch generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 59s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 21m
58s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 75m 45s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:bdbca0e53b4 |
| JIRA Issue | YARN-9096 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976670/YARN-9096.002.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 4dacfc63b836 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3
08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / f8ea6e1 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/24468/testReport/ |
| Max. process+thread count | 341 (vs. ulimit of 5500) |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
|
|
[jira] [Commented] (YARN-9096) Some GpuResourcePlugin and ResourcePluginManager methods are synchronized unnecessarily
[
https://issues.apache.org/jira/browse/YARN-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899867#comment-16899867
]
Adam Antal commented on YARN-9096:
--
+1 (non-binding)
> Some GpuResourcePlugin and ResourcePluginManager methods are synchronized
> unnecessarily
> ---
>
> Key: YARN-9096
> URL: https://issues.apache.org/jira/browse/YARN-9096
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Gergely Pollak
>Priority: Major
> Attachments: YARN-9096.001.patch, YARN-9096.002.patch
>
>
> These methods are not used concurrently, they are part of the initialization
> code of NM that happens from one thread.
> This is the list of the call hierarchies:
> 1. GpuResourcePlugin.initialize + ResourcePluginManager.initialize
>
> {code:java}
> GpuResourcePlugin.initialize(Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> ResourcePluginManager.initialize(Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin)
> NodeManager.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager){code}
>
>
> 2. GpuResourcePlugin.createResourceHandler:
>
> {code:java}
> GpuResourcePlugin.createResourceHandler(Context, CGroupsHandler,
> PrivilegedOperationExecutor)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> ResourceHandlerModule.addHandlersFromConfiguredResourcePlugins(List,
> Configuration, Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ResourceHandlerModule.initializeConfiguredResourceHandlerChain(Configuration,
> Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ResourceHandlerModule.getConfiguredResourceHandlerChain(Configuration,
> Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ContainerScheduler.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.scheduler)
> LinuxContainerExecutor.init(Context)
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}
>
> 3. GpuResourcePlugin.getNodeResourceHandlerInstance:
>
> {code:java}
> GpuResourcePlugin.getNodeResourceHandlerInstance()
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> NodeStatusUpdaterImpl.updateConfiguredResourcesViaPlugins(Resource)(2 usages)
> (org.apache.hadoop.yarn.server.nodemanager)
> NodeStatusUpdaterImpl.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9096) Some GpuResourcePlugin and ResourcePluginManager methods are synchronized unnecessarily
[
https://issues.apache.org/jira/browse/YARN-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810791#comment-16810791
]
Hadoop QA commented on YARN-9096:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 19s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
55s{color} | {color:red}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
in trunk has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:
The patch generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 34s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 35s{color}
| {color:red} hadoop-yarn-server-nodemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 70m 57s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.yarn.server.nodemanager.TestNodeManagerResync |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | YARN-9096 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12964988/YARN-9096.002.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux eb66f0b96dc0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 77fe51e |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| findbugs |
[jira] [Commented] (YARN-9096) Some GpuResourcePlugin and ResourcePluginManager methods are synchronized unnecessarily
[
https://issues.apache.org/jira/browse/YARN-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749964#comment-16749964
]
Peter Bacsko commented on YARN-9096:
+1 (non-binding)
> Some GpuResourcePlugin and ResourcePluginManager methods are synchronized
> unnecessarily
> ---
>
> Key: YARN-9096
> URL: https://issues.apache.org/jira/browse/YARN-9096
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Szilard Nemeth
>Priority: Major
> Attachments: YARN-9096.001.patch
>
>
> These methods are not used concurrently, they are part of the initialization
> code of NM that happens from one thread.
> This is the list of the call hierarchies:
> 1. GpuResourcePlugin.initialize + ResourcePluginManager.initialize
>
> {code:java}
> GpuResourcePlugin.initialize(Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> ResourcePluginManager.initialize(Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin)
> NodeManager.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager){code}
>
>
> 2. GpuResourcePlugin.createResourceHandler:
>
> {code:java}
> GpuResourcePlugin.createResourceHandler(Context, CGroupsHandler,
> PrivilegedOperationExecutor)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> ResourceHandlerModule.addHandlersFromConfiguredResourcePlugins(List,
> Configuration, Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ResourceHandlerModule.initializeConfiguredResourceHandlerChain(Configuration,
> Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ResourceHandlerModule.getConfiguredResourceHandlerChain(Configuration,
> Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ContainerScheduler.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.scheduler)
> LinuxContainerExecutor.init(Context)
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}
>
> 3. GpuResourcePlugin.getNodeResourceHandlerInstance:
>
> {code:java}
> GpuResourcePlugin.getNodeResourceHandlerInstance()
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> NodeStatusUpdaterImpl.updateConfiguredResourcesViaPlugins(Resource)(2 usages)
> (org.apache.hadoop.yarn.server.nodemanager)
> NodeStatusUpdaterImpl.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9096) Some GpuResourcePlugin and ResourcePluginManager methods are synchronized unnecessarily
[
https://issues.apache.org/jira/browse/YARN-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723872#comment-16723872
]
Szilard Nemeth commented on YARN-9096:
--
[~devaraj.k], [~tangzhankun], [~zyluo], [~sunilg], [~leftnoteasy]: As you have
a lot expertise in this area, could you please help me to review (and hopefully
commit) this?
Thanks!
> Some GpuResourcePlugin and ResourcePluginManager methods are synchronized
> unnecessarily
> ---
>
> Key: YARN-9096
> URL: https://issues.apache.org/jira/browse/YARN-9096
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Szilard Nemeth
>Priority: Major
> Attachments: YARN-9096.001.patch
>
>
> These methods are not used concurrently, they are part of the initialization
> code of NM that happens from one thread.
> This is the list of the call hierarchies:
> 1. GpuResourcePlugin.initialize + ResourcePluginManager.initialize
>
> {code:java}
> GpuResourcePlugin.initialize(Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> ResourcePluginManager.initialize(Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin)
> NodeManager.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager){code}
>
>
> 2. GpuResourcePlugin.createResourceHandler:
>
> {code:java}
> GpuResourcePlugin.createResourceHandler(Context, CGroupsHandler,
> PrivilegedOperationExecutor)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> ResourceHandlerModule.addHandlersFromConfiguredResourcePlugins(List,
> Configuration, Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ResourceHandlerModule.initializeConfiguredResourceHandlerChain(Configuration,
> Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ResourceHandlerModule.getConfiguredResourceHandlerChain(Configuration,
> Context)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources)
> ContainerScheduler.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.scheduler)
> LinuxContainerExecutor.init(Context)
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}
>
> 3. GpuResourcePlugin.getNodeResourceHandlerInstance:
>
> {code:java}
> GpuResourcePlugin.getNodeResourceHandlerInstance()
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> NodeStatusUpdaterImpl.updateConfiguredResourcesViaPlugins(Resource)(2 usages)
> (org.apache.hadoop.yarn.server.nodemanager)
> NodeStatusUpdaterImpl.serviceInit(Configuration)
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9096) Some GpuResourcePlugin and ResourcePluginManager methods are synchronized unnecessarily
[
https://issues.apache.org/jira/browse/YARN-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713655#comment-16713655
]
Hadoop QA commented on YARN-9096:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
15m 4s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:
The patch generated 0 new + 1 unchanged - 3 fixed = 1 total (was 4) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
15m 30s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 20m
25s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 85m 45s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | YARN-9096 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12951093/YARN-9096.001.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux bc989a70bd15 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct
5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 5e773ef |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/22812/testReport/ |
| Max. process+thread count | 305 (vs. ulimit of 1) |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
U:
