[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814653#comment-13814653 ] Vinod Kumar Vavilapalli commented on YARN-978: -- Tx for the reviews Zhijie. Also Xuan for the earlier patches. [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Mayank Bansal Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.10.patch, YARN-978.2.patch, YARN-978.3.patch, YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch, YARN-978.8.patch, YARN-978.9.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812682#comment-13812682 ] Zhijie Shen commented on YARN-978: -- +1 [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Mayank Bansal Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.10.patch, YARN-978.2.patch, YARN-978.3.patch, YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch, YARN-978.8.patch, YARN-978.9.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811390#comment-13811390
]
Zhijie Shen commented on YARN-978:
--
The patch is almost good, but still requires to address the following issues:
* Update the name accordingly the suggestion in
{YARN-1123|https://issues.apache.org/jira/browse/YARN-1123?focusedCommentId=13811377page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13811377}
{code}
{code}
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch,
YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch,
YARN-978.8.patch, YARN-978.9.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811398#comment-13811398
]
Zhijie Shen commented on YARN-978:
--
Sorry for the breaking message above.
The patch is almost good, but still requires to address the following issue:
* Update the name accordingly the suggestion in YARN-1123
{code}
+message ApplicationAttemptReportProto {
+ optional ApplicationAttemptIdProto applicationAttemptId = 1;
+ optional string host = 2;
+ optional int32 rpc_port = 3;
+ optional string trackingUrl = 4;
+ optional string diagnostics = 5 [default = N/A];
+ optional YarnApplicationAttemptStateProto yarn_application_attempt_state = 6;
+ optional ContainerIdProto amContainerId = 7;
+}
{code}
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch,
YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch,
YARN-978.8.patch, YARN-978.9.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811754#comment-13811754
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12611704/YARN-978.10.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2356//console
This message is automatically generated.
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.10.patch, YARN-978.2.patch,
YARN-978.3.patch, YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch,
YARN-978.7.patch, YARN-978.8.patch, YARN-978.9.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809801#comment-13809801
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12611217/YARN-978.9.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2326//console
This message is automatically generated.
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch,
YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch,
YARN-978.8.patch, YARN-978.9.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804788#comment-13804788 ] Mayank Bansal commented on YARN-978: Assigning it back to myself for change due to YARN-947 Thanks, Mayank [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch, YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch, YARN-978.8.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766572#comment-13766572
]
Xuan Gong commented on YARN-978:
bq. I'm fine with remove it, but trackingUrl is on web UI according to the
latest patches in YARN-954 and YARN-1023. If it is to be removed, we should
leave note there.
Yes, We might still need trackingUrl. Originally, I though the trackingUrl will
be set as null, so we might not need it. But I checked code again. Actually,
this is from the ApplicationMaster
{code}
resourceManager.unregisterApplicationMaster(appStatus, appMessage, null);
{code}.
I am thinking since this applicationMaster can be re-wrote or provided by the
client, this will be changed, too. (At least from MRApplicationMaster, the
trackUrl is set as non-null). So, we can add trackUrl to the
applicationAttemptReport.
And I agree that the logUrl should go to the containerReport.
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Xuan Gong
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch,
YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766916#comment-13766916
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12603089/YARN-978.8.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1923//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1923//console
This message is automatically generated.
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Xuan Gong
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch,
YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch,
YARN-978.8.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766935#comment-13766935 ] Mayank Bansal commented on YARN-978: Looks good +1 Thanks, Mayank [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch, YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch, YARN-978.8.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766028#comment-13766028 ] Mayank Bansal commented on YARN-978: If we can add the tracking url that would be useful in UI Thanks, Mayank [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch, YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764597#comment-13764597 ] Xuan Gong commented on YARN-978: bq.Should it be the trackingUrl? LogUrl should be part of the container report. Application attempt report has the Id of the AM container, which can be used to retrieve the container report. We have already discussed that we would remove the trackingUrl, have not we ?? For adding logUril, please see the latest comments from [~vinodkv] [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch, YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764579#comment-13764579
]
Zhijie Shen commented on YARN-978:
--
{code}
+ @Private
+ @Unstable
+ public abstract void setDiagnostics(String diagnostics);
+
+ /**
+ * Get the emlogs url/em for the application attempt.
+ *
+ * @return emlogs url/em for the application attempt
+ */
+ @Public
+ @Unstable
+ public abstract String getLogsUrl();
+
{code}
Should it be the trackingUrl? LogUrl should be part of the container report.
Application attempt report has the Id of the AM container, which can be used to
retrieve the container report.
Then, put forward a another question. Shall we include some info (e.g., logUrl)
of the container report of the AM container into the application attempt
report, just as the application report has the info of the final application
attempt? Thoughts?
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Xuan Gong
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch,
YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764670#comment-13764670 ] Zhijie Shen commented on YARN-978: -- bq. We have already discussed that we would remove the trackingUrl, have not we ?? I'm fine with remove it, but trackingUrl is on web UI according to the latest patches in YARN-954 and YARN-1023. If it is to be removed, we should leave note there. [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch, YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763315#comment-13763315 ] Zhijie Shen commented on YARN-978: -- The patch looks good, but it's better to add some javadoc for YarnApplicationAttemptState and ApplicationAttemptReport, because it's user-oriented. Another question is whether all RMAppAttemptState states are meaningful to users to have the 1-to-1 mapping. I've noticed that YarnApplicationState combined FINISHING and FINISHED. Thoughts? If we decided not to expose host, rpc port, and tracking url via rpc protocol, we should be consistent via web (YARN-954 and YARN-1023). [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch, YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763898#comment-13763898 ] Xuan Gong commented on YARN-978: bq.FINISHING to FINISHED is a bad merge, and indeed is a bug, will file a ticket. But agree with the general sentiment. LAUNCHED_UNMANAGED_SAVING can be mapped to ALLOCATED_SAVING, I actually think we don't need a separate LAUNCHED_UNMANAGED_SAVING, Unmanaged AM should directly go to ALLOCATED state on app-submission, will file a bug. The rest seem fine enough for me. Fixed. Now YarnApplicationAttemptState has FINISHED and FINISHING. Also mapping RMAppAttemptState. LAUNCHED_UNMANAGED_SAVING to YarnApplicationAttemptState. ALLOCATED_SAVING bq. I think we should add the host and port information for information purposes so that users can reason where their previous AMs ran and on what ports. The tracking url can be removed, instead a logs-url can be added like we have on the UI. Added host, rpc_port and logsUrl to applicationAttemptReport bq.No need to add more stuff to BuilderUtils. It was supposed to be dismantled. Removed bq.Do we really need the prefix APP_ATTEMPT_ in YarnApplicationAttemptStateProto? Yes, we have to. Just like we added APP prefix in FinalApplicationStatusProto. The reason is in protocolbuffers, enum values use C++ scoping rules, meaning that enum values are siblings of their type, not children of it. all enum values must be unique within the global scope, not just within YarnApplicationAttemptStateProto. [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch, YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763946#comment-13763946
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12602505/YARN-978.7.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1894//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1894//console
This message is automatically generated.
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Xuan Gong
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch,
YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch, YARN-978.7.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760462#comment-13760462
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12601859/YARN-978.5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1861//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1861//console
This message is automatically generated.
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Xuan Gong
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch,
YARN-978.4.patch, YARN-978.5.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760530#comment-13760530
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12601877/YARN-978.6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1865//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1865//console
This message is automatically generated.
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Xuan Gong
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch,
YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13759746#comment-13759746
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12601743/YARN-978.4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1849//console
This message is automatically generated.
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Xuan Gong
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch,
YARN-978.4.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735572#comment-13735572 ] Zhijie Shen commented on YARN-978: -- I'm not pretty sure how users would make use of the attempt information, but I think it does no harm to expose the attempt information listed in the patch, which on the other side, give users more options. Compared with application report, the duplicated fields: * diagnostics * finalApplicationStatus * host * rpcPort * trackingUrl However, the fields in an application report, is extracted from the *current* attempt. Therefore, through the application report, users can only know this information of the current attempt. In the case of application history, the information should belong to that of the last attempt when the application is finished. In contrast, an application may have launched several attempts before it is finished. The aforementioned information of each attempt may be different. Therefore, this information should not be duplicate. bq. For a non-running attempt, what is the tracker url and the original tracking url? hm... Do you mean the tracking url only work for a running attempt? bq. Failed attempts have a failed yarn state. Failed attempts would register an app state with the RM ( during unregister ) if that attempt is the final attempt Sorry, I mean all attempts should have a finalApplicationStatus, shouldn't they? [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735624#comment-13735624 ] Hitesh Shah commented on YARN-978: -- In terms of duplication: diagnostics, host and rpcPort are unique for each attempt and can be useful to know about. I am not sure from a historical point of view whether rpc port is useful but definitely needed for a running attempt. The finalApplicationStatus is only set for the last attempt. The internal *hidden behind proxy* tracker url is different for each attempt but not exposed to the user. The tracker url either points to the current running attempt or to the history server hence a question as to whether it is needed for each attempt. [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13733736#comment-13733736 ] Zhijie Shen commented on YARN-978: -- bq. any reason why we need final application status and the tracker url in the report? Like why we need this info for application report. It should be important to users. bq. aren't these available in the overall application report? Yes, the application report contains this info, which is extracted from the current attempt. We'd like to keep the info of all the attempts, including the failed ones. bq. what is meant to be retrieved from the attempt report as compared to the app report? We hope the users can get the as complete info of attempts as possible. [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13729801#comment-13729801 ] Zhijie Shen commented on YARN-978: -- +1 LGTM. The patch should be clean for trunk. [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13729832#comment-13729832 ] Mayank Bansal commented on YARN-978: +1 Thanks, Mayank [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727788#comment-13727788 ] Zhijie Shen commented on YARN-978: -- bq. We can add that. But do we really need this ? From the point view of AHS, I'd like to show the connection between an AppAttempt and its AM container. Thoughts? [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727908#comment-13727908 ] Xuan Gong commented on YARN-978: Add the containerId to AppAttemptReport. [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727940#comment-13727940
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12595645/YARN-978.3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1646//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1646//console
This message is automatically generated.
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Xuan Gong
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727023#comment-13727023 ] Xuan Gong commented on YARN-978: Open the ticket. Trunk need this, too [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727084#comment-13727084
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12595510/YARN-978.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1643//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1643//console
This message is automatically generated.
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Xuan Gong
Fix For: YARN-321
Attachments: YARN-978-1.patch, YARN-978.2.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727188#comment-13727188 ] Xuan Gong commented on YARN-978: No test cases added [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation -- Key: YARN-978 URL: https://issues.apache.org/jira/browse/YARN-978 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Xuan Gong Fix For: YARN-321 Attachments: YARN-978-1.patch, YARN-978.2.patch We dont have ApplicationAttemptReport and Protobuf implementation. Adding that. Thanks, Mayank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720551#comment-13720551
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12594345/YARN-978-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1589//console
This message is automatically generated.
[YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
--
Key: YARN-978
URL: https://issues.apache.org/jira/browse/YARN-978
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Attachments: YARN-978-1.patch
We dont have ApplicationAttemptReport and Protobuf implementation.
Adding that.
Thanks,
Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
