[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kumar Vavilapalli updated YARN-530: - Attachment: YARN-530-023.patch Fixing the warnings.. > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117-019.patch, YARN-117changes.pdf, > YARN-530-005.patch, YARN-530-008.patch, YARN-530-009.patch, > YARN-530-010.patch, YARN-530-011.patch, YARN-530-012.patch, > YARN-530-013.patch, YARN-530-014.patch, YARN-530-015.patch, > YARN-530-016.patch, YARN-530-017.patch, YARN-530-018.patch, > YARN-530-019.patch, YARN-530-020.patch, YARN-530-021.patch, > YARN-530-022.patch, YARN-530-023.patch, YARN-530-2.patch, YARN-530-3.patch, > YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-022.patch Patch in sync w/ YARN-117-022: rebased to trunk of June 10; all tests passing. > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117-019.patch, YARN-117changes.pdf, > YARN-530-005.patch, YARN-530-008.patch, YARN-530-009.patch, > YARN-530-010.patch, YARN-530-011.patch, YARN-530-012.patch, > YARN-530-013.patch, YARN-530-014.patch, YARN-530-015.patch, > YARN-530-016.patch, YARN-530-017.patch, YARN-530-018.patch, > YARN-530-019.patch, YARN-530-020.patch, YARN-530-021.patch, > YARN-530-022.patch, YARN-530-2.patch, YARN-530-3.patch, YARN-530.4.patch, > YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-021.patch This patch manages all the MR services properly -the change was trivial, once tracked down. Rather than synchronize on the service itself for state changes, we synchronize on a specific {{stateChangeLock}} -ensures that this doesn't create any locks elsewhere. When applied on its own, the YARN changes will successfully run all the MapReduce tests except for two in {{TestStagingCleanup}} which are actually due to {{ContainerLauncherRouter}} not checking {{containerLauncher}} for nullness before stopping -and the shutdown hook calling it in INITED state, not STARTED -i.e. is due to the stop() code not being robust enough to stop when not started. That's fixed in the main MapReduce patch, because it does add the null reference checks {code} testDeletionofStagingOnKill(org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup) Time elapsed: 57 sec <<< ERROR! java.lang.NullPointerException at org.apache.hadoop.mapreduce.v2.app.MRAppMaster$ContainerLauncherRouter.stop(MRAppMaster.java:865) at org.apache.hadoop.yarn.service.ServiceOperations.stop(ServiceOperations.java:51) at org.apache.hadoop.yarn.service.ServiceOperations.stopQuietly(ServiceOperations.java:79) at org.apache.hadoop.yarn.service.CompositeService.stop(CompositeService.java:135) at org.apache.hadoop.yarn.service.CompositeService.serviceStop(CompositeService.java:108) at org.apache.hadoop.yarn.service.AbstractService.stop(AbstractService.java:216) at org.apache.hadoop.mapreduce.v2.app.MRAppMaster$MRAppMasterShutdownHook.run(MRAppMaster.java:1350) at org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup.testDeletionofStagingOnKill(TestStagingCleanup.java:167) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at junit.framework.TestCase.runTest(TestCase.java:168) at junit.framework.TestCase.runBare(TestCase.java:134) at junit.framework.TestResult$1.protect(TestResult.java:110) at junit.framework.TestResult.runProtected(TestResult.java:128) at junit.framework.TestResult.run(TestResult.java:113) at junit.framework.TestCase.run(TestCase.java:124) at junit.framework.TestSuite.runTest(TestSuite.java:243) at junit.framework.TestSuite.run(TestSuite.java:238) at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) {code} > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117-019.patch, YARN-117changes.pdf, > YARN-530-005.patch, YARN-530-008.patch, YARN-530-009.patch, > YARN-530-010.patch, YARN-530-011.patch, YARN-530-012.patch, > YARN-530-013.patch, YARN-530-014.patch, YARN-530-015.patch, > YARN-530-016.patch, YARN-530-017.patch, YARN-530-018.patch, > YARN-530-019.patch, YARN-530-020.patch, YARN-530-021.patch, YARN-530-2.patch, > YARN-530-3.patch, YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-020.patch There's no change from -19 except an extra line of logging in CompositeService > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117-019.patch, YARN-117changes.pdf, > YARN-530-005.patch, YARN-530-008.patch, YARN-530-009.patch, > YARN-530-010.patch, YARN-530-011.patch, YARN-530-012.patch, > YARN-530-013.patch, YARN-530-014.patch, YARN-530-015.patch, > YARN-530-016.patch, YARN-530-017.patch, YARN-530-018.patch, > YARN-530-019.patch, YARN-530-020.patch, YARN-530-2.patch, YARN-530-3.patch, > YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-019.patch # make sure addService, removeService and service iteration are all thread safe -eliminates risk of concurrency problems if the service list is changed during init/start/stop of children. As these methods are protected, a subclass would have to do this in another thread -or make the methods public # composite service policy is switched to stop all services that are STARTED or INITED > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117-019.patch, YARN-117changes.pdf, > YARN-530-005.patch, YARN-530-008.patch, YARN-530-009.patch, > YARN-530-010.patch, YARN-530-011.patch, YARN-530-012.patch, > YARN-530-013.patch, YARN-530-014.patch, YARN-530-015.patch, > YARN-530-016.patch, YARN-530-017.patch, YARN-530-018.patch, > YARN-530-019.patch, YARN-530-2.patch, YARN-530-3.patch, YARN-530.4.patch, > YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-117-019.patch # make sure addService, removeService and service iteration are all thread safe -eliminates risk of concurrency problems if the service list is changed during init/start/stop of children. As these methods are protected, a subclass would have to do this in another thread -or make the methods public # composite service policy is switched to stop all services that are STARTED or INITED > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117-019.patch, YARN-117changes.pdf, > YARN-530-005.patch, YARN-530-008.patch, YARN-530-009.patch, > YARN-530-010.patch, YARN-530-011.patch, YARN-530-012.patch, > YARN-530-013.patch, YARN-530-014.patch, YARN-530-015.patch, > YARN-530-016.patch, YARN-530-017.patch, YARN-530-018.patch, YARN-530-2.patch, > YARN-530-3.patch, YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-018.patch vinod -thanks for trying to defeat findbugs. Here is your patch rebased for the YARN-635 exception rename changes > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-009.patch, YARN-530-010.patch, > YARN-530-011.patch, YARN-530-012.patch, YARN-530-013.patch, > YARN-530-014.patch, YARN-530-015.patch, YARN-530-016.patch, > YARN-530-017.patch, YARN-530-018.patch, YARN-530-2.patch, YARN-530-3.patch, > YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kumar Vavilapalli updated YARN-530: - Attachment: YARN-530-017.patch > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-009.patch, YARN-530-010.patch, > YARN-530-011.patch, YARN-530-012.patch, YARN-530-013.patch, > YARN-530-014.patch, YARN-530-015.patch, YARN-530-016.patch, > YARN-530-017.patch, YARN-530-2.patch, YARN-530-3.patch, YARN-530.4.patch, > YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kumar Vavilapalli updated YARN-530: - Attachment: YARN-530-016.patch Locking only for wait and notify in AbstractService. > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-009.patch, YARN-530-010.patch, > YARN-530-011.patch, YARN-530-012.patch, YARN-530-013.patch, > YARN-530-014.patch, YARN-530-015.patch, YARN-530-016.patch, YARN-530-2.patch, > YARN-530-3.patch, YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-015.patch patch in sync number-wise with YARN-117-015.patch. No change since -014 except some trailing whitespaces were stripped from the {{TestServiceLifecycle}} class > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-009.patch, YARN-530-010.patch, > YARN-530-011.patch, YARN-530-012.patch, YARN-530-013.patch, > YARN-530-014.patch, YARN-530-015.patch, YARN-530-2.patch, YARN-530-3.patch, > YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-014.patch Pulled the {{ServiceShutdownHook}} code off to YARN-679, this eliminates two of the FindBugs warnings. The remaining two are spurious as they note that an AtomicBool is being used for both a wait/notify barrier as well as for the thread-safe get/set operations. > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-009.patch, YARN-530-010.patch, > YARN-530-011.patch, YARN-530-012.patch, YARN-530-013.patch, > YARN-530-014.patch, YARN-530-2.patch, YARN-530-3.patch, YARN-530.4.patch, > YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-013.patch # revert the renaming of the service subscribe/unsubscribe methods to ensure cross-yarn-project compiles # added two test to verify that unsubscribe works, both when called outside a listener callback, and inside -the latter catches any concurrent editing bugs in the notifier list > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-009.patch, YARN-530-010.patch, > YARN-530-011.patch, YARN-530-012.patch, YARN-530-013.patch, YARN-530-2.patch, > YARN-530-3.patch, YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-012.patch Updated -sync stop() -thanks for reviewing everything! I've pulled the IRQ handler, and added a new JIRA - YARN-740 - on documenting the service lifecycle & base class for YARN developers > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Affects Versions: 2.0.4-alpha >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-009.patch, YARN-530-010.patch, > YARN-530-011.patch, YARN-530-012.patch, YARN-530-2.patch, YARN-530-3.patch, > YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-011.patch Updated patch which makes start/init no-ops if called from that state. moved (not for patching) ServiceLauncher code to reduce clutter > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-009.patch, YARN-530-010.patch, > YARN-530-011.patch, YARN-530-2.patch, YARN-530-3.patch, YARN-530.4.patch, > YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-010.patch patch rebased to trunk > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-009.patch, YARN-530-010.patch, YARN-530-2.patch, > YARN-530-3.patch, YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-009.patch > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-009.patch, YARN-530-2.patch, YARN-530-3.patch, > YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-008.patch resubmit, main change is to downgrade the log message on service start to debug, as it appears on things like yarn client applications, where it gets in the way. # I'd like to come up with a way of postponing all service state change notifications until a service has exited the synchronized phase of the state change -to avoid all risk of deadlocks. But I can't see an easy way to do this while also guaranteeing the {{stop()}} operation will be called if a service fails to init or start -that call, with its notifications, will be called in the synchronized block. The only workable solution that is immediately obvious is have a special private {{stopNoNotifications}} call, then leave it up to the outer notifier operation in the start/stop methods to tell the listeners the state has changed. # this patch includes the {{ServiceLauncher}} and {{IrqHandler}} I mention in YARN-679. They are for completeness -not for committing. They are evolving and need more use before even ready for review. For the curious only: they show how we don't need separate entry points for every YARN service. > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-2.patch, YARN-530-3.patch, YARN-530.4.patch, > YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-005.patch > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-2.patch, YARN-530-3.patch, YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530.4.patch no tangible change than previously; publishing to keep in sync with the updated YARN-117 "everything" patch > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-2.patch, YARN-530-3.patch, > YARN-530.4.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-3.patch > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-2.patch, YARN-530-3.patch, > YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530-2.patch This patch * includes the static service notification tests of YARN-119 * catches when a service replaces or clones the original configuration it was started with, and updates the copy stored in the base service class. > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-2.patch, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-530.patch This is the subset of YARN-117 for yarn-common > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-530) Define Service model strictly, implement AbstractService for robust subclassing, migrate yarn-common services
[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated YARN-530: Attachment: YARN-117changes.pdf this is an overview of the changes, with explanations > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > - > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Steve Loughran >Assignee: Steve Loughran > Attachments: YARN-117changes.pdf > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira