Re: [yocto] 'yocto-kernel-tools' requires git version much greater than general Yocto requirement

2024-02-23 Thread Bruce Ashfield
On Fri, Feb 23, 2024, 5:26 PM Konstantin Aladyshev 
wrote:

> Thanks Richard! That did the trick!
>
> I've made the following changes to the "kern-tools-native_git.bb":
> ```
> diff --git a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
> b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
> index 941160ea9c..7f8ea3e050 100644
> --- a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
> +++ b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "\
> file://Kconfiglib/LICENSE.txt;md5=712177a72a3937909543eda3ad1bfb7c
> \
>  "
>
> -DEPENDS = "git-native"
> +DEPENDS = "git-replacement-native"
>
>  SRCREV = "7160ebe8b865dd6028aef278efa219433db93f7e"
>  PV = "0.3+git"
> ```
> Is it ok? Can I send this patch to the mailing list?
>

It is easier if I just make the change locally and send it to the list as
part of my next pull request.

Thanks for the report and testing, I'll send a patch shortly.

Bruce



>
> Best regards,
> Konstantin Aladyshev
>
> On Sat, Feb 24, 2024 at 12:07 AM Richard Purdie
>  wrote:
> >
> > On Fri, 2024-02-23 at 13:45 -0500, Bruce Ashfield wrote:
> > > On Fri, Feb 23, 2024 at 12:15 PM Konstantin Aladyshev
> > >  wrote:
> > > >
> > > > Should I see the new git version in the linux-yocto devshell?
> > > > """
> > > > bitbake linux-yocto -c devshell
> > > > """
> > > >
> > > > I've tried to check it in the current poky master, and it gives me:
> > > > """
> > > > $/data/poky/build/workspace/sources/linux-yocto# git --version
> > > > git version 2.30.2
> > > > $/data/poky/build/workspace/sources/linux-yocto# which git
> > > > /data/poky/scripts/git
> > > > """
> > > > So in this case host git is used. "bitbake kern-tools-native -c
> > > > devshell" gives the same result.
> > > > Can this be considered as a proof that git-native is not used?
> > > >
> > >
> > > It is likely ASSUME_PROVIDED that is causing the issue, git-native is
> > > in there, which means it is going to use the host version and not
> > > build our -native recipe for it.
> > >
> > > We'll need some guidance from Richard on this, because the use of
> > > that
> > > flag in the git operations is in fact required for security reasons,
> > > so it isn't going to be optional. If that means we need a minimum git
> > > version or to use our own built one (and possibly the buildtools
> > > tarball, etc), then those are the hoops we'll have to jump through.
> > >
> > > When I pulled git-native out of ASSUME_PROVIDED locally, I ended up
> > > in
> > > a dependency loop.
> > >
> > > I can have a closer look at this again on Monday, but i'm out of time
> > > for it today.
> >
> > We do have a way to handle this.
> >
> > DEPENDS += "git-replacement-native"
> >
> > should do it.
> >
> > Cheers,
> >
> > Richard
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62595): https://lists.yoctoproject.org/g/yocto/message/62595
Mute This Topic: https://lists.yoctoproject.org/mt/104509876/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [yocto] 'yocto-kernel-tools' requires git version much greater than general Yocto requirement

2024-02-23 Thread Konstantin Aladyshev
Thanks Richard! That did the trick!

I've made the following changes to the "kern-tools-native_git.bb":
```
diff --git a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
index 941160ea9c..7f8ea3e050 100644
--- a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
+++ b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "\
file://Kconfiglib/LICENSE.txt;md5=712177a72a3937909543eda3ad1bfb7c \
 "

-DEPENDS = "git-native"
+DEPENDS = "git-replacement-native"

 SRCREV = "7160ebe8b865dd6028aef278efa219433db93f7e"
 PV = "0.3+git"
```
Is it ok? Can I send this patch to the mailing list?

Best regards,
Konstantin Aladyshev

On Sat, Feb 24, 2024 at 12:07 AM Richard Purdie
 wrote:
>
> On Fri, 2024-02-23 at 13:45 -0500, Bruce Ashfield wrote:
> > On Fri, Feb 23, 2024 at 12:15 PM Konstantin Aladyshev
> >  wrote:
> > >
> > > Should I see the new git version in the linux-yocto devshell?
> > > """
> > > bitbake linux-yocto -c devshell
> > > """
> > >
> > > I've tried to check it in the current poky master, and it gives me:
> > > """
> > > $/data/poky/build/workspace/sources/linux-yocto# git --version
> > > git version 2.30.2
> > > $/data/poky/build/workspace/sources/linux-yocto# which git
> > > /data/poky/scripts/git
> > > """
> > > So in this case host git is used. "bitbake kern-tools-native -c
> > > devshell" gives the same result.
> > > Can this be considered as a proof that git-native is not used?
> > >
> >
> > It is likely ASSUME_PROVIDED that is causing the issue, git-native is
> > in there, which means it is going to use the host version and not
> > build our -native recipe for it.
> >
> > We'll need some guidance from Richard on this, because the use of
> > that
> > flag in the git operations is in fact required for security reasons,
> > so it isn't going to be optional. If that means we need a minimum git
> > version or to use our own built one (and possibly the buildtools
> > tarball, etc), then those are the hoops we'll have to jump through.
> >
> > When I pulled git-native out of ASSUME_PROVIDED locally, I ended up
> > in
> > a dependency loop.
> >
> > I can have a closer look at this again on Monday, but i'm out of time
> > for it today.
>
> We do have a way to handle this.
>
> DEPENDS += "git-replacement-native"
>
> should do it.
>
> Cheers,
>
> Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62590): https://lists.yoctoproject.org/g/yocto/message/62590
Mute This Topic: https://lists.yoctoproject.org/mt/104509876/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [yocto] 'yocto-kernel-tools' requires git version much greater than general Yocto requirement

2024-02-23 Thread Richard Purdie
On Fri, 2024-02-23 at 13:45 -0500, Bruce Ashfield wrote:
> On Fri, Feb 23, 2024 at 12:15 PM Konstantin Aladyshev
>  wrote:
> > 
> > Should I see the new git version in the linux-yocto devshell?
> > """
> > bitbake linux-yocto -c devshell
> > """
> > 
> > I've tried to check it in the current poky master, and it gives me:
> > """
> > $/data/poky/build/workspace/sources/linux-yocto# git --version
> > git version 2.30.2
> > $/data/poky/build/workspace/sources/linux-yocto# which git
> > /data/poky/scripts/git
> > """
> > So in this case host git is used. "bitbake kern-tools-native -c
> > devshell" gives the same result.
> > Can this be considered as a proof that git-native is not used?
> > 
> 
> It is likely ASSUME_PROVIDED that is causing the issue, git-native is
> in there, which means it is going to use the host version and not
> build our -native recipe for it.
> 
> We'll need some guidance from Richard on this, because the use of
> that
> flag in the git operations is in fact required for security reasons,
> so it isn't going to be optional. If that means we need a minimum git
> version or to use our own built one (and possibly the buildtools
> tarball, etc), then those are the hoops we'll have to jump through.
> 
> When I pulled git-native out of ASSUME_PROVIDED locally, I ended up
> in
> a dependency loop.
> 
> I can have a closer look at this again on Monday, but i'm out of time
> for it today.

We do have a way to handle this.

DEPENDS += "git-replacement-native"

should do it.

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62589): https://lists.yoctoproject.org/g/yocto/message/62589
Mute This Topic: https://lists.yoctoproject.org/mt/104509876/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [yocto] 'yocto-kernel-tools' requires git version much greater than general Yocto requirement

2024-02-23 Thread Konstantin Aladyshev
Thanks Bruce! I would appreciate that.
Should we move this discussion to linux-yocto as well?

Best regards,
Konstantin

On Fri, Feb 23, 2024 at 9:45 PM Bruce Ashfield  wrote:
>
> On Fri, Feb 23, 2024 at 12:15 PM Konstantin Aladyshev
>  wrote:
> >
> > Should I see the new git version in the linux-yocto devshell?
> > """
> > bitbake linux-yocto -c devshell
> > """
> >
> > I've tried to check it in the current poky master, and it gives me:
> > """
> > $/data/poky/build/workspace/sources/linux-yocto# git --version
> > git version 2.30.2
> > $/data/poky/build/workspace/sources/linux-yocto# which git
> > /data/poky/scripts/git
> > """
> > So in this case host git is used. "bitbake kern-tools-native -c
> > devshell" gives the same result.
> > Can this be considered as a proof that git-native is not used?
> >
>
> It is likely ASSUME_PROVIDED that is causing the issue, git-native is
> in there, which means it is going to use the host version and not
> build our -native recipe for it.
>
> We'll need some guidance from Richard on this, because the use of that
> flag in the git operations is in fact required for security reasons,
> so it isn't going to be optional. If that means we need a minimum git
> version or to use our own built one (and possibly the buildtools
> tarball, etc), then those are the hoops we'll have to jump through.
>
> When I pulled git-native out of ASSUME_PROVIDED locally, I ended up in
> a dependency loop.
>
> I can have a closer look at this again on Monday, but i'm out of time
> for it today.
>
> Bruce
>
>
> Bruce
>
> > Konstantin
> >
> > On Fri, Feb 23, 2024 at 4:11 PM Bruce Ashfield  
> > wrote:
> > >
> > > On Fri, Feb 23, 2024 at 6:43 AM Alexander Kanavin
> > >  wrote:
> > > >
> > > > On Fri, 23 Feb 2024 at 12:32, Konstantin Aladyshev
> > > >  wrote:
> > > > > Thanks for the response! What would be a proper way to fix this 
> > > > > problem then?
> > > >
> > > > 1. show how to reproduce the issue in plain poky master.
> > > > 2. check why none of the tests expose the issue. You can for example
> > > > grep related keywords in meta/lib/oeqa/selftest/cases. I think there
> > > > are tests that check devtool kernel operations there.
> > > > 3. see if existing tests can be easily extended to cover it, so that
> > > > they fail without a fix.
> > > > 4. perhaps the fix would be to check git version first, and add the
> > > > argument only if the version is recent enough.
> > >
> > > Which unfortunately would still leave the problem that the change is
> > > intended to fix, so I wouldn't want to merge any patches to make it
> > > conditional in the kern-tools.
> > >
> > > Those changes were made to prevent git operations from running
> > > hooks from the host environment, for both security and consistency
> > > reasons.
> > >
> > > We added git-native to the kern-tools-native recipe to get a consistently
> > > new version available for any operations involving the tools.
> > >
> > > So I'd add another question .. why is this operation not using our
> > > natively built git ? Is there something going on with the path, 
> > > environment
> > > or something else that we missed when adding that native dependency.
> > >
> > > Bruce
> > >
> > > >
> > > > Alex
> > > >
> > > > 
> > > >
> > >
> > >
> > > --
> > > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > > thee at its end
> > > - "Use the force Harry" - Gandalf, Star Trek II
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62588): https://lists.yoctoproject.org/g/yocto/message/62588
Mute This Topic: https://lists.yoctoproject.org/mt/104509876/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [yocto] 'yocto-kernel-tools' requires git version much greater than general Yocto requirement

2024-02-23 Thread Bruce Ashfield
On Fri, Feb 23, 2024 at 12:15 PM Konstantin Aladyshev
 wrote:
>
> Should I see the new git version in the linux-yocto devshell?
> """
> bitbake linux-yocto -c devshell
> """
>
> I've tried to check it in the current poky master, and it gives me:
> """
> $/data/poky/build/workspace/sources/linux-yocto# git --version
> git version 2.30.2
> $/data/poky/build/workspace/sources/linux-yocto# which git
> /data/poky/scripts/git
> """
> So in this case host git is used. "bitbake kern-tools-native -c
> devshell" gives the same result.
> Can this be considered as a proof that git-native is not used?
>

It is likely ASSUME_PROVIDED that is causing the issue, git-native is
in there, which means it is going to use the host version and not
build our -native recipe for it.

We'll need some guidance from Richard on this, because the use of that
flag in the git operations is in fact required for security reasons,
so it isn't going to be optional. If that means we need a minimum git
version or to use our own built one (and possibly the buildtools
tarball, etc), then those are the hoops we'll have to jump through.

When I pulled git-native out of ASSUME_PROVIDED locally, I ended up in
a dependency loop.

I can have a closer look at this again on Monday, but i'm out of time
for it today.

Bruce


Bruce

> Konstantin
>
> On Fri, Feb 23, 2024 at 4:11 PM Bruce Ashfield  
> wrote:
> >
> > On Fri, Feb 23, 2024 at 6:43 AM Alexander Kanavin
> >  wrote:
> > >
> > > On Fri, 23 Feb 2024 at 12:32, Konstantin Aladyshev
> > >  wrote:
> > > > Thanks for the response! What would be a proper way to fix this problem 
> > > > then?
> > >
> > > 1. show how to reproduce the issue in plain poky master.
> > > 2. check why none of the tests expose the issue. You can for example
> > > grep related keywords in meta/lib/oeqa/selftest/cases. I think there
> > > are tests that check devtool kernel operations there.
> > > 3. see if existing tests can be easily extended to cover it, so that
> > > they fail without a fix.
> > > 4. perhaps the fix would be to check git version first, and add the
> > > argument only if the version is recent enough.
> >
> > Which unfortunately would still leave the problem that the change is
> > intended to fix, so I wouldn't want to merge any patches to make it
> > conditional in the kern-tools.
> >
> > Those changes were made to prevent git operations from running
> > hooks from the host environment, for both security and consistency
> > reasons.
> >
> > We added git-native to the kern-tools-native recipe to get a consistently
> > new version available for any operations involving the tools.
> >
> > So I'd add another question .. why is this operation not using our
> > natively built git ? Is there something going on with the path, environment
> > or something else that we missed when adding that native dependency.
> >
> > Bruce
> >
> > >
> > > Alex
> > >
> > > 
> > >
> >
> >
> > --
> > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > thee at its end
> > - "Use the force Harry" - Gandalf, Star Trek II



--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62586): https://lists.yoctoproject.org/g/yocto/message/62586
Mute This Topic: https://lists.yoctoproject.org/mt/104509876/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [yocto] 'yocto-kernel-tools' requires git version much greater than general Yocto requirement

2024-02-23 Thread Konstantin Aladyshev
Should I see the new git version in the linux-yocto devshell?
"""
bitbake linux-yocto -c devshell
"""

I've tried to check it in the current poky master, and it gives me:
"""
$/data/poky/build/workspace/sources/linux-yocto# git --version
git version 2.30.2
$/data/poky/build/workspace/sources/linux-yocto# which git
/data/poky/scripts/git
"""
So in this case host git is used. "bitbake kern-tools-native -c
devshell" gives the same result.
Can this be considered as a proof that git-native is not used?

Konstantin

On Fri, Feb 23, 2024 at 4:11 PM Bruce Ashfield  wrote:
>
> On Fri, Feb 23, 2024 at 6:43 AM Alexander Kanavin
>  wrote:
> >
> > On Fri, 23 Feb 2024 at 12:32, Konstantin Aladyshev
> >  wrote:
> > > Thanks for the response! What would be a proper way to fix this problem 
> > > then?
> >
> > 1. show how to reproduce the issue in plain poky master.
> > 2. check why none of the tests expose the issue. You can for example
> > grep related keywords in meta/lib/oeqa/selftest/cases. I think there
> > are tests that check devtool kernel operations there.
> > 3. see if existing tests can be easily extended to cover it, so that
> > they fail without a fix.
> > 4. perhaps the fix would be to check git version first, and add the
> > argument only if the version is recent enough.
>
> Which unfortunately would still leave the problem that the change is
> intended to fix, so I wouldn't want to merge any patches to make it
> conditional in the kern-tools.
>
> Those changes were made to prevent git operations from running
> hooks from the host environment, for both security and consistency
> reasons.
>
> We added git-native to the kern-tools-native recipe to get a consistently
> new version available for any operations involving the tools.
>
> So I'd add another question .. why is this operation not using our
> natively built git ? Is there something going on with the path, environment
> or something else that we missed when adding that native dependency.
>
> Bruce
>
> >
> > Alex
> >
> > 
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62585): https://lists.yoctoproject.org/g/yocto/message/62585
Mute This Topic: https://lists.yoctoproject.org/mt/104509876/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [yocto] 'yocto-kernel-tools' requires git version much greater than general Yocto requirement

2024-02-23 Thread Bruce Ashfield
On Fri, Feb 23, 2024 at 6:43 AM Alexander Kanavin
 wrote:
>
> On Fri, 23 Feb 2024 at 12:32, Konstantin Aladyshev
>  wrote:
> > Thanks for the response! What would be a proper way to fix this problem 
> > then?
>
> 1. show how to reproduce the issue in plain poky master.
> 2. check why none of the tests expose the issue. You can for example
> grep related keywords in meta/lib/oeqa/selftest/cases. I think there
> are tests that check devtool kernel operations there.
> 3. see if existing tests can be easily extended to cover it, so that
> they fail without a fix.
> 4. perhaps the fix would be to check git version first, and add the
> argument only if the version is recent enough.

Which unfortunately would still leave the problem that the change is
intended to fix, so I wouldn't want to merge any patches to make it
conditional in the kern-tools.

Those changes were made to prevent git operations from running
hooks from the host environment, for both security and consistency
reasons.

We added git-native to the kern-tools-native recipe to get a consistently
new version available for any operations involving the tools.

So I'd add another question .. why is this operation not using our
natively built git ? Is there something going on with the path, environment
or something else that we missed when adding that native dependency.

Bruce

>
> Alex
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62582): https://lists.yoctoproject.org/g/yocto/message/62582
Mute This Topic: https://lists.yoctoproject.org/mt/104509876/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [yocto] 'yocto-kernel-tools' requires git version much greater than general Yocto requirement

2024-02-23 Thread Alexander Kanavin
On Fri, 23 Feb 2024 at 12:32, Konstantin Aladyshev
 wrote:
> Thanks for the response! What would be a proper way to fix this problem then?

1. show how to reproduce the issue in plain poky master.
2. check why none of the tests expose the issue. You can for example
grep related keywords in meta/lib/oeqa/selftest/cases. I think there
are tests that check devtool kernel operations there.
3. see if existing tests can be easily extended to cover it, so that
they fail without a fix.
4. perhaps the fix would be to check git version first, and add the
argument only if the version is recent enough.

Alex

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62579): https://lists.yoctoproject.org/g/yocto/message/62579
Mute This Topic: https://lists.yoctoproject.org/mt/104509876/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [yocto] 'yocto-kernel-tools' requires git version much greater than general Yocto requirement

2024-02-23 Thread Konstantin Aladyshev
Hi, Alex!

Thanks for the response! What would be a proper way to fix this problem then?

Konstantin

On Fri, Feb 23, 2024 at 2:24 PM Alexander Kanavin
 wrote:
>
> It's probably just a simple oversight. If the problematic code path is
> not taken in automated tests, no one will see the issue when it's
> introduced by the commit.
>
> Alex
>
> On Thu, 22 Feb 2024 at 16:11, Konstantin Aladyshev
>  wrote:
> >
> > Hello!
> > I was investigating some problems with the `devtool modify linux`
> > command and have discovered that part of the problems is generated
> > from the commit
> > https://git.yoctoproject.org/yocto-kernel-tools/commit/?id=923a9de418b3ca8592c3fd0a0d0b1e4b29533891
> > This commit is very simple and just adds the `--no-verify` flag to the
> > `git am` command. The problem is that this flag was added pretty
> > recently  (Jan 5 2023 -
> > https://github.com/git/git/commit/566902f2db3bdad9be7fb083c713f0d21acf111e)
> > and my host git doesn't have it.
> > Is it normal that yocto relies on such modern git? Because the yocto
> > documentation just says `Git 1.8.3.1 or greater`
> > (https://docs.yoctoproject.org/brief-yoctoprojectqs/index.html#compatible-linux-distribution).
> > And `git am --no-verify` works from something like `v2.31.6`
> > apparently.
> >
> > Best regards,
> > Konstantin Aladyshev
> >
> > 
> >

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62578): https://lists.yoctoproject.org/g/yocto/message/62578
Mute This Topic: https://lists.yoctoproject.org/mt/104509876/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [yocto] 'yocto-kernel-tools' requires git version much greater than general Yocto requirement

2024-02-23 Thread Alexander Kanavin
It's probably just a simple oversight. If the problematic code path is
not taken in automated tests, no one will see the issue when it's
introduced by the commit.

Alex

On Thu, 22 Feb 2024 at 16:11, Konstantin Aladyshev
 wrote:
>
> Hello!
> I was investigating some problems with the `devtool modify linux`
> command and have discovered that part of the problems is generated
> from the commit
> https://git.yoctoproject.org/yocto-kernel-tools/commit/?id=923a9de418b3ca8592c3fd0a0d0b1e4b29533891
> This commit is very simple and just adds the `--no-verify` flag to the
> `git am` command. The problem is that this flag was added pretty
> recently  (Jan 5 2023 -
> https://github.com/git/git/commit/566902f2db3bdad9be7fb083c713f0d21acf111e)
> and my host git doesn't have it.
> Is it normal that yocto relies on such modern git? Because the yocto
> documentation just says `Git 1.8.3.1 or greater`
> (https://docs.yoctoproject.org/brief-yoctoprojectqs/index.html#compatible-linux-distribution).
> And `git am --no-verify` works from something like `v2.31.6`
> apparently.
>
> Best regards,
> Konstantin Aladyshev
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62576): https://lists.yoctoproject.org/g/yocto/message/62576
Mute This Topic: https://lists.yoctoproject.org/mt/104509876/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[yocto] 'yocto-kernel-tools' requires git version much greater than general Yocto requirement

2024-02-22 Thread Konstantin Aladyshev
Hello!
I was investigating some problems with the `devtool modify linux`
command and have discovered that part of the problems is generated
from the commit
https://git.yoctoproject.org/yocto-kernel-tools/commit/?id=923a9de418b3ca8592c3fd0a0d0b1e4b29533891
This commit is very simple and just adds the `--no-verify` flag to the
`git am` command. The problem is that this flag was added pretty
recently  (Jan 5 2023 -
https://github.com/git/git/commit/566902f2db3bdad9be7fb083c713f0d21acf111e)
and my host git doesn't have it.
Is it normal that yocto relies on such modern git? Because the yocto
documentation just says `Git 1.8.3.1 or greater`
(https://docs.yoctoproject.org/brief-yoctoprojectqs/index.html#compatible-linux-distribution).
And `git am --no-verify` works from something like `v2.31.6`
apparently.

Best regards,
Konstantin Aladyshev

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62567): https://lists.yoctoproject.org/g/yocto/message/62567
Mute This Topic: https://lists.yoctoproject.org/mt/104509876/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-