Re: [yocto] [PATCH 0/1] Misc: detect trailing space in the patches
From: Daniel Stone [mailto:dan...@fooishbar.org] Sent: Wednesday, December 05, 2012 9:48 PM To: Martin Jansa Cc: Kamble, Nitin A; yocto@yoctoproject.org Subject: Re: [yocto] [PATCH 0/1] Misc: detect trailing space in the patches Hi, On 6 December 2012 15:23, Martin Jansa martin.ja...@gmail.commailto:martin.ja...@gmail.com wrote: Can you add also detection of mixed whitespace? E.g. tab followed by space in multilinear indentation? Only as warning. Thanks These checks can generate infuriating false positives when your patch modifies upstream code which has trailing or mixed whitespace in either context or removal lines; in this case, removing a line with trailing whitespace and replacing it with one which doesn't would generate a warning. Mixed whitespace is also part of some coding styles, notably the kernel's. Cheers, Daniel This code checks for the trialing whitespace only in the lines added by the patches. The context lines or removed lines are not checked. It is easy to check for mixed whitespace also, but before doing that I would like to know the final decision about it, as I see some objection to it too. Thanks, Nitin ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [PATCH 0/1] Misc: detect trailing space in the patches
From: Nitin A Kamble nitin.a.kam...@intel.com This commit is for detecting trailing white space in the create-pull-request script. Thanks, Nitin The following changes since commit 381c4b69c7e8b452f4d3de2f8214e6e5f6a9abe7: sstate.bbclass: fix detection of owners matching sstate files (2012-12-05 15:34:07 +) are available in the git repository at: git://git.pokylinux.org/poky-contrib nitin/misc http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/misc Nitin A Kamble (1): create-pull-request: detect trailing white space scripts/create-pull-request | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) -- 1.7.3.4 ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [PATCH 0/1] Misc: detect trailing space in the patches
Can you add also detection of mixed whitespace? E.g. tab followed by space in multilinear indentation? Only as warning. Thanks On Dec 6, 2012 12:38 AM, nitin.a.kam...@intel.com wrote: From: Nitin A Kamble nitin.a.kam...@intel.com This commit is for detecting trailing white space in the create-pull-request script. Thanks, Nitin The following changes since commit 381c4b69c7e8b452f4d3de2f8214e6e5f6a9abe7: sstate.bbclass: fix detection of owners matching sstate files (2012-12-05 15:34:07 +) are available in the git repository at: git://git.pokylinux.org/poky-contrib nitin/misc http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/misc Nitin A Kamble (1): create-pull-request: detect trailing white space scripts/create-pull-request | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) -- 1.7.3.4 ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [PATCH 0/1] Misc: detect trailing space in the patches
Hi, On 6 December 2012 15:23, Martin Jansa martin.ja...@gmail.com wrote: Can you add also detection of mixed whitespace? E.g. tab followed by space in multilinear indentation? Only as warning. Thanks These checks can generate infuriating false positives when your patch modifies upstream code which has trailing or mixed whitespace in either context or removal lines; in this case, removing a line with trailing whitespace and replacing it with one which doesn't would generate a warning. Mixed whitespace is also part of some coding styles, notably the kernel's. Cheers, Daniel ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
