Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager
I just tried merging it against lp:activity-log-manager locally and it went fine. It'd also show conflicts here if there were some. I've merged the branch against tip and updated the references in POTFILES.in. make distcheck is now working fine locally. -- https://code.launchpad.net/~ev/activity-log-manager/split-out-diagnostics-service/+merge/175820 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager
Evan Dandrea has proposed merging lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager. Requested reviews: Activity Log Manager (activity-log-manager) For more details, see: https://code.launchpad.net/~ev/activity-log-manager/split-out-diagnostics-service/+merge/175820 This branch removes the code for the whoopsie-preferences DBus service as it now lives in the whoopsie-preferences package (http://bazaar.launchpad.net/~ev/whoopsie-preferences/trunk/files). -- https://code.launchpad.net/~ev/activity-log-manager/split-out-diagnostics-service/+merge/175820 Your team Activity Log Manager is requested to review the proposed merge of lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager. === modified file 'configure.ac' --- configure.ac 2013-07-10 04:22:15 + +++ configure.ac 2013-07-19 12:36:26 + @@ -46,7 +46,7 @@ PKG_CHECK_MODULES(GEE, gee-1.0, [HAVE_GEE=yes]) PKG_CHECK_MODULES(GIO_UNIX, gio-unix-2.0, [HAVE_GIO_UNIX=yes]) PKG_CHECK_MODULES(POLKIT, polkit-gobject-1, [HAVE_POLKIT=yes], [HAVE_POLKIT=no]) -PKG_CHECK_MODULES(LIBWHOOPSIE, libwhoopsie, [HAVE_LIBWHOOPSIE=yes], [HAVE_LIBWHOOPSIE=no]) +PKG_CHECK_MODULES(LIBWHOOPSIEPREFS, libwhoopsie-preferences, [HAVE_LIBWHOOPSIE=yes], [HAVE_LIBWHOOPSIE=no]) PKG_CHECK_MODULES(PANTHEON, pantheon, [HAVE_PANTHEON=yes], [HAVE_PANTHEON=no]) PKG_CHECK_MODULES(GLIB, glib-2.0 gobject-2.0) @@ -89,7 +89,7 @@ fi if test x$with_whoopsie != xcheck test x$HAVE_LIBWHOOPSIE != xyes; then AC_MSG_FAILURE( -[--with-whoopsie was given, but libwhoopsie was not found]) +[--with-whoopsie was given, but libwhoopsie or libwhoopsie-preferences was not found]) fi ] @@ -103,19 +103,15 @@ ) AM_CONDITIONAL([HAVE_CCPANEL], [test -n $CCPANEL_LIBS test x$with_ccpanel != xno]) - -AM_CONDITIONAL([HAVE_WHOOPSIE], [test -n $POLKIT_LIBS test -n $LIBWHOOPSIE_LIBS]) - +AM_CONDITIONAL([HAVE_WHOOPSIE], [test -n $POLKIT_LIBS test -n $LIBWHOOPSIEPREFS_LIBS]) AC_CONFIG_FILES([ Makefile data/Makefile src/Makefile -src/diagnostics/Makefile po/Makefile.in ]) - if test x$with_whoopsie != xno test x$HAVE_POLKIT != xno test x$HAVE_LIBWHOOPSIE != xno; then AC_DEFINE([HAVE_WHOOPSIE], 1, [Enable Whoopsie]) WHOOPSIE_ENABLE=yes === modified file 'data/Makefile.am' --- data/Makefile.am 2013-06-12 23:31:37 + +++ data/Makefile.am 2013-07-19 12:36:26 + @@ -33,10 +33,15 @@ switchboard_DATA = alm-switchboard.plug endif +if HAVE_WHOOPSIE +gnomeccuidir = $(datadir)/gnome-control-center/ui +gnomeccui_DATA = whoopsie.ui +endif + desktop_DATA = $(desktop_in_files:.desktop.in=.desktop) @INTLTOOL_DESKTOP_RULE@ -EXTRA_DIST = activity-log-manager.desktop.in gnome-activity-log-manager-panel.desktop.in alm-switchboard.plug +EXTRA_DIST = activity-log-manager.desktop.in gnome-activity-log-manager-panel.desktop.in alm-switchboard.plug whoopsie.ui CLEANFILES = activity-log-manager.desktop gnome-activity-log-manager-panel.desktop check: $(desktop_DATA) === renamed file 'src/diagnostics/whoopsie.ui' = 'data/whoopsie.ui' === modified file 'src/Makefile.am' --- src/Makefile.am 2013-07-09 01:34:49 + +++ src/Makefile.am 2013-07-19 12:36:26 + @@ -42,6 +42,11 @@ $(POLKIT_LIBS) \ -lm +if HAVE_WHOOPSIE +SHARED_LIBS += \ + $(LIBWHOOPSIEPREFS_LIBS) +endif + alm_switchboard_SOURCES = \ $(SHARED_SOURCES) \ alm-plug.vala \ @@ -49,8 +54,7 @@ if HAVE_WHOOPSIE alm_switchboard_SOURCES += \ - diagnostics-widget.c \ - diagnostics/whoopsie-generated.c + diagnostics-widget.c endif if HAVE_SWITCHBOARD @@ -74,7 +78,6 @@ AM_VALAFLAGS += \ -D DIAGNOSTIC gnomeccuidir = $(datadir)/gnome-control-center/ui/ -SUBDIRS = diagnostics endif @@ -103,8 +106,7 @@ if HAVE_WHOOPSIE activity_log_manager_SOURCES += \ - diagnostics-widget.c \ - diagnostics/whoopsie-generated.c + diagnostics-widget.c endif libactivity_log_manager_la_SOURCES = \ @@ -113,8 +115,7 @@ if HAVE_WHOOPSIE libactivity_log_manager_la_SOURCES += \ - diagnostics-widget.c \ - diagnostics/whoopsie-generated.c + diagnostics-widget.c endif @@ -128,10 +129,6 @@ $(SHARED_LIBS) \ $(CCPANEL_LIBS) -if HAVE_WHOOPSIE -libactivity_log_manager_la_LIBADD += \ - $(POLKIT_LIBS) -endif GENERATED_C_FILES = $(SHARED_SOURCES:.vala=.c) GENERATED_O_FILES = $(SHARED_SOURCES:.vala=.o) === removed directory 'src/diagnostics' === modified file 'src/diagnostics-widget.c' --- src/diagnostics-widget.c 2013-06-20 02:06:00 + +++ src/diagnostics-widget.c 2013-07-19 12:36:26 + @@ -6,7 +6,7 @@ #define _GNU_SOURCE #include stdio.h -#include diagnostics/whoopsie-generated.h +#include whoopsie-preferences/libwhoopsie-preferences.h static WhoopsiePreferences* proxy = NULL; === removed file 'src/diagnostics/Makefile.am' --- src/diagnostics/Makefile.am 2013-04-16 11:25:34 + +++ src/diagnostics/Makefile.am 1970-01-01 00:00:00 + @@ -1,50 +0,0 @@ -if HAVE_CCPANEL -ccpaneldir
[Zeitgeist] [Merge] lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager
The proposal to merge lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager has been updated. Description changed to: This branch removes the code for the whoopsie-preferences DBus service as it now lives in the whoopsie-preferences package (http://bazaar.launchpad.net/~ev/whoopsie-preferences/trunk/files). See also: https://bugs.launchpad.net/ubuntu/+source/activity-log-manager/+bug/1203042 For more details, see: https://code.launchpad.net/~ev/activity-log-manager/split-out-diagnostics-service/+merge/175820 -- https://code.launchpad.net/~ev/activity-log-manager/split-out-diagnostics-service/+merge/175820 Your team Activity Log Manager is requested to review the proposed merge of lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~ev/activity-log-manager/1192778 into lp:activity-log-manager
Evan Dandrea has proposed merging lp:~ev/activity-log-manager/1192778 into
lp:activity-log-manager.
Requested reviews:
Activity Log Manager (activity-log-manager)
For more details, see:
https://code.launchpad.net/~ev/activity-log-manager/1192778/+merge/172098
Fixes bug 1192778. :)
--
https://code.launchpad.net/~ev/activity-log-manager/1192778/+merge/172098
Your team Activity Log Manager is requested to review the proposed merge of
lp:~ev/activity-log-manager/1192778 into lp:activity-log-manager.
=== modified file 'configure.ac'
--- configure.ac 2013-06-20 02:06:00 +
+++ configure.ac 2013-06-28 16:25:33 +
@@ -62,7 +62,7 @@
AC_ARG_WITH([whoopsie],
[AS_HELP_STRING([--with-whoopsie],
[build control-center plugin Ubuntu crash reporting page @:@default=check@:@])],
- [with_ccpanel=yes],
+ [with_ccpanel=check],
[with_whoopsie=check])
AC_ARG_WITH([ccpanel],
@@ -95,10 +95,6 @@
AC_SUBST(CCPANEL_DIR),
[
-if test x$with_whoopsie != xcheck; then
- AC_MSG_FAILURE(
-[--with-whoopsie was given, but test for libgnome-control-center failed])
-fi
if test x$with_ccpanel != xcheck; then
AC_MSG_FAILURE(
[--with-ccpanel was given, but test for libgnome-control-center failed])
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2013-06-18 12:37:52 +
+++ src/Makefile.am 2013-06-28 16:25:33 +
@@ -11,13 +11,14 @@
SHARED_CFLAGS = \
-Wall \
-g \
+ -DGNOMECC_UI_DIR=\$(gnomeccuidir)\ \
-DPACKAGE_LOCALE_DIR=\$(prefix)/$(DATADIRNAME)/locale\ \
-DPACKAGE_SRC_DIR=\$(srcdir)\ \
-DPACKAGE_DATA_DIR=\$(datadir)\ \
-DPROGRAMNAME_LOCALEDIR=\${PROGRAMNAME_LOCALEDIR}\ \
-DGETTEXT_PACKAGE=\$(GETTEXT_PACKAGE)\ \
-DGNOMELOCALEDIR=\$(prefix)/$(DATADIRNAME)/locale\ \
- $(GTK_CFLAGS) $(ZEITGEIST_CFLAGS) $(GEE_CFLAGS) $(GIO_UNIX_CFLAGS)
+ $(GTK_CFLAGS) $(ZEITGEIST_CFLAGS) $(GEE_CFLAGS) $(GIO_UNIX_CFLAGS) $(POLKIT_CFLAGS)
SHARED_SOURCES = \
@@ -36,6 +37,7 @@
$(GEE_LIBS) \
$(GIO_UNIX_LIBS) \
$(GLIB_LIBS) \
+ $(POLKIT_LIBS) \
-lm
alm_switchboard_SOURCES = \
@@ -43,6 +45,12 @@
alm-plug.vala \
$(NULL)
+if HAVE_WHOOPSIE
+alm_switchboard_SOURCES += \
+ diagnostics-widget.c \
+ diagnostics/whoopsie-generated.c
+endif
+
if HAVE_SWITCHBOARD
switchboarddir = $(prefix)/lib/plugs/zeitgeist/alm
switchboard_PROGRAMS = alm-switchboard
@@ -81,7 +89,6 @@
if HAVE_WHOOPSIE
libactivity_log_manager_la_CFLAGS += \
- $(POLKIT_CFLAGS) \
-DGNOMECC_UI_DIR=\$(gnomeccuidir)\
endif
@@ -89,6 +96,13 @@
$(SHARED_SOURCES) \
alm.vala \
$(NULL)
+
+if HAVE_WHOOPSIE
+activity_log_manager_SOURCES += \
+ diagnostics-widget.c \
+ diagnostics/whoopsie-generated.c
+endif
+
libactivity_log_manager_la_SOURCES = \
$(SHARED_SOURCES:.vala=.c) \
alm-cc.c
@@ -115,9 +129,8 @@
$(POLKIT_LIBS)
endif
-GENERATED_C_FILES = $(activity_log_manager_SOURCES:.vala=.c)
-
-GENERATED_O_FILES = $(activity_log_manager_SOURCES:.vala=.o)
+GENERATED_C_FILES = $(SHARED_SOURCES:.vala=.c)
+GENERATED_O_FILES = $(SHARED_SOURCES:.vala=.o)
CLEANFILES = \
$(GENERATED_C_FILES) \
=== modified file 'src/activity-log-manager.vala'
--- src/activity-log-manager.vala 2013-06-20 05:29:55 +
+++ src/activity-log-manager.vala 2013-06-28 16:25:33 +
@@ -19,11 +19,14 @@
* You should have received a copy of the GNU Lesser General Public License
* along with this program. If not, see http://www.gnu.org/licenses/.;
*/
+extern Gtk.Widget whoopsie_daisy_preferences_new ();
+
namespace Alm {
public class ActivityLogManager : Gtk.Box {
private Gtk.Notebook notebook;
private PrivacyWidget privacy_widget;
+private Gtk.Widget whoopsie;
private Blacklist blacklist;
@@ -36,11 +39,14 @@
blacklist = new Blacklist();
privacy_widget = new PrivacyWidget(blacklist);
+whoopsie = whoopsie_daisy_preferences_new ();
notebook = new Gtk.Notebook();
this.pack_start(notebook, true, true, 0);
var privacy_label = new Gtk.Label(_(Files Applications));
notebook.append_page(privacy_widget, privacy_label);
+var whoopsie_label = new Gtk.Label(_(Diagnostics));
+notebook.append_page(whoopsie, whoopsie_label);
this.show_all();
}
=== modified file 'src/alm-cc.c'
--- src/alm-cc.c 2013-06-19 15:15:46 +
+++ src/alm-cc.c 2013-06-28 16:25:33 +
@@ -22,10 +22,6 @@
#include libgnome-control-center/cc-panel.h
extern void* alm_activity_log_manager_new (void);
-#ifdef HAVE_WHOOPSIE
-extern void alm_activity_log_manager_append_page (void* alm, GtkWidget* widget, const gchar* label);
-extern GtkWidget* whoopsie_daisy_preferences_new (void);
-#endif
#define ALM_TYPE_MAIN_WINDOW_PANEL alm_main_window_panel_get_type()
@@ -58,10 +54,6 @@
alm_main_window_panel_init (AlmMainWindowPanel *self)
{
GtkWidget *widget = GTK_WIDGET (alm_activity_log_manager_new ());
-#ifdef HAVE_WHOOPSIE
- GtkWidget *whoopsie = GTK_WIDGET (whoopsie_daisy_preferences_new ());
- alm_activity_log_manager_append_page
[Zeitgeist] [Merge] lp:~ev/activity-log-manager/1192777 into lp:activity-log-manager
Evan Dandrea has proposed merging lp:~ev/activity-log-manager/1192777 into lp:activity-log-manager. Requested reviews: Activity Log Manager (activity-log-manager) For more details, see: https://code.launchpad.net/~ev/activity-log-manager/1192777/+merge/171839 This branch fixes: https://bugs.launchpad.net/activity-log-manager/+bug/1192777 It simply disables the checkbox as the feature is not implemented yet. -- https://code.launchpad.net/~ev/activity-log-manager/1192777/+merge/171839 Your team Activity Log Manager is requested to review the proposed merge of lp:~ev/activity-log-manager/1192777 into lp:activity-log-manager. === modified file 'src/diagnostics/whoopsie.ui' --- src/diagnostics/whoopsie.ui 2013-06-19 21:19:46 + +++ src/diagnostics/whoopsie.ui 2013-06-27 15:15:34 + @@ -166,6 +166,7 @@ property name=label translatable=yesSend a report automatically if a problem prevents login/property property name=use_action_appearanceFalse/property property name=visibleTrue/property +property name=sensitiveFalse/property property name=can_focusTrue/property property name=receives_defaultFalse/property property name=use_action_appearanceFalse/property ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager
I've implemented the define for whoopsie in a slightly different way. It is working fine for me when I build it in a deb and install that way. Can you please build with debugging symbols and provide a backtrace? -- https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/169855 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager
I can also confirm this works well with Jeremy's debdiff: https://bugs.launchpad.net/ubuntu/+source/activity-log-manager/+bug/1189253/+attachment/3699264/+files/update-to-0.9.5.debdiff -- https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/169855 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager
Evan Dandrea has proposed merging lp:~ev/activity-log-manager/add-whoopsie-back
into lp:activity-log-manager.
Requested reviews:
Activity Log Manager (activity-log-manager)
For more details, see:
https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/169855
This resurrects code for the Diagnostics panel (whoopsie) that appears to have
been accidentally deleted in the move from the
lp:~activity-log-manager/activity-log-manager/vala branch.
Namely, it brings back src/diagnostics-widget.c, which is not automatically
generated code, unlike the rest of the C files that appear in that directory.
I'm working on a debdiff, with these changes incorporated, against
0.9.4-0ubuntu6.1, which is the version in Ubuntu Saucy.
--
https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/169855
Your team Activity Log Manager is requested to review the proposed merge of
lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager.
=== modified file '.bzrignore'
--- .bzrignore 2013-04-21 07:25:20 +
+++ .bzrignore 2013-06-17 17:15:32 +
@@ -28,7 +28,7 @@
src/activity-log-manager
src/alm
src/alm-switchboard
-src/*.c
+RE:src/(?!diagnostics-widget).*.c
src/*.h
src/*.la
src/*.lo
@@ -41,3 +41,6 @@
po/.intltool-merge-cache
po/POTFILES
po/stamp-it
+src/diagnostics/whoopsie-preferences
+src/diagnostics/com.ubuntu.whoopsiepreferences.policy
+src/diagnostics/.libs
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2013-04-20 12:35:20 +
+++ src/Makefile.am 2013-06-17 17:15:32 +
@@ -79,6 +79,12 @@
$(SHARED_CFLAGS) \
$(CCPANEL_CFLAGS)
+if HAVE_WHOOPSIE
+libactivity_log_manager_la_CFLAGS += \
+ $(POLKIT_CFLAGS) \
+ -DGNOMECC_UI_DIR=\$(gnomeccuidir)\
+endif
+
activity_log_manager_SOURCES = \
$(SHARED_SOURCES) \
alm.vala \
@@ -88,6 +94,13 @@
alm-cc.c \
$(NULL)
+if HAVE_WHOOPSIE
+libactivity_log_manager_la_SOURCES += \
+ diagnostics-widget.c \
+ diagnostics/whoopsie-generated.c \
+ $(NULL)
+endif
+
activity_log_manager_LDFLAGS = \
-Wl,--export-dynamic
@@ -99,6 +112,11 @@
$(SHARED_LIBS) \
$(CCPANEL_LIBS)
+if HAVE_WHOOPSIE
+libactivity_log_manager_la_LIBADD += \
+ $(POLKIT_LIBS)
+endif
+
GENERATED_C_FILES = $(activity_log_manager_SOURCES:.vala=.c)
GENERATED_O_FILES = $(activity_log_manager_SOURCES:.vala=.o)
=== added file 'src/diagnostics-widget.c'
--- src/diagnostics-widget.c 1970-01-01 00:00:00 +
+++ src/diagnostics-widget.c 2013-06-17 17:15:32 +
@@ -0,0 +1,249 @@
+#include gtk/gtk.h
+#include gio/gio.h
+#include polkit/polkit.h
+#include stdlib.h
+
+#include diagnostics/whoopsie-generated.h
+
+static WhoopsiePreferences* proxy = NULL;
+
+#define POL_PATH com.ubuntu.whoopsiepreferences.change
+#define PRIVACY_URL http://www.ubuntu.com/aboutus/privacypolicy?crashdb;
+#define SYSTEM_ERRORS_URL https://errors.ubuntu.com/user;
+
+#define WHOOPSIE_DAISY_TYPE_PREFERENCES whoopsie_daisy_preferences_get_type()
+#define WHOOPSIE_DAISY_PREFERENCES(obj) \
+(G_TYPE_CHECK_INSTANCE_CAST ((obj), \
+WHOOPSIE_DAISY_TYPE_PREFERENCES, WhoopsieDaisyPreferences))
+#define WHOOPSIE_DAISY_PREFERENCES_PRIVATE(o) \
+(G_TYPE_INSTANCE_GET_PRIVATE ((o), WHOOPSIE_DAISY_TYPE_PREFERENCES, WhoopsieDaisyPreferencesPrivate))
+
+GType whoopsie_daisy_preferences_get_type (void) G_GNUC_CONST;
+
+typedef struct _WhoopsieDaisyPreferences WhoopsieDaisyPreferences;
+typedef struct _WhoopsieDaisyPreferencesClass WhoopsieDaisyPreferencesClass;
+typedef struct _WhoopsieDaisyPreferencesPrivate WhoopsieDaisyPreferencesPrivate;
+
+struct _WhoopsieDaisyPreferencesPrivate
+{
+GtkBuilder* builder;
+GPermission* permission;
+};
+
+struct _WhoopsieDaisyPreferences
+{
+GtkBox parent;
+WhoopsieDaisyPreferencesPrivate* priv;
+};
+
+struct _WhoopsieDaisyPreferencesClass
+{
+GtkBoxClass parent_class;
+};
+
+G_DEFINE_TYPE (WhoopsieDaisyPreferences, whoopsie_daisy_preferences, GTK_TYPE_BOX)
+
+static void
+whoopsie_daisy_preferences_dispose (GObject* object)
+{
+WhoopsieDaisyPreferencesPrivate* priv = WHOOPSIE_DAISY_PREFERENCES (object)-priv;
+
+if (priv-builder) {
+g_object_unref (priv-builder);
+priv-builder = NULL;
+}
+if (priv-permission) {
+g_object_unref (priv-permission);
+priv-permission = NULL;
+}
+}
+
+static void
+whoopsie_daisy_preferences_class_init (WhoopsieDaisyPreferencesClass *klass)
+{
+GObjectClass *object_class = G_OBJECT_CLASS (klass);
+g_type_class_add_private (klass, sizeof (WhoopsieDaisyPreferencesPrivate));
+object_class-dispose = whoopsie_daisy_preferences_dispose;
+}
+
+static void
+on_privacy_policy_clicked (GtkWidget* button, gpointer user_data)
+{
+system (xdg-open PRIVACY_URL);
+}
+
+static void
+on_show_previous_reports_clicked (GtkWidget* button, gpointer user_data)
+{
+GError* error = NULL;
+gchar* identifier = NULL;
+gchar* command = NULL;
+whoopsie_preferences_call_get_identifier_sync (proxy, identifier, NULL
[Zeitgeist] [Bug 933042] Re: Integrate diagnostics application from whoopsie
** Changed in: activity-log-manager Status: Fix Committed = Fix Released ** Changed in: activity-log-manager Milestone: 0.9.2 = None -- You received this bug notification because you are a member of Activity Log Manager, which is the registrant for Activity Log Manager. https://bugs.launchpad.net/bugs/933042 Title: Integrate diagnostics application from whoopsie Status in Activity Log Manager for Zeitgeist: Fix Released Bug description: Whoopsie daisy is crash database and reporting daemon for Ubuntu which comes with UI showing up in control center. This UI needs to be integrated within activity-log-manager https://launchpad.net/whoopsie-daisy To manage notifications about this bug go to: https://bugs.launchpad.net/activity-log-manager/+bug/933042/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/whoopsie into lp:activity-log-manager
On Tue, Feb 21, 2012 at 2:55 PM, Seif Lotfy s...@lotfy.com wrote: Evan I dont mind also having it in the standalone version :D Sure, but presumably that requires building the whoopsie code as a library and generating a vapi, as you cannot directly call C code from vala source. So could we get that in a second pass, given that UI freeze is tomorrow? -- https://code.launchpad.net/~ev/activity-log-manager/whoopsie/+merge/93899 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/whoopsie into lp:activity-log-manager
On Mon, Feb 20, 2012 at 8:51 PM, Seif Lotfy s...@lotfy.com wrote: Can you please make sure that the makefile is complete... I can't compile it due to make[3]: *** No rule to make target `diagnostics/whoopsie-generated.c', needed by `libactivity_log_manager_la_vala.stamp'. Stop. make[3]: Leaving directory `/home/seif/Projects/whoopsie/src' Fixed in r85. This was due to the autogenerated vala targets pulling in libactivity-log-manager even when --with-ccpanel was not set. I've worked around that by explicitly building against the C source targets: activity_log_manager_la_SOURCES = \ $(SOURCES:.vala=.c) alm-cc.c \ diagnostics-widget.c \ diagnostics/whoopsie-generated.c -- https://code.launchpad.net/~ev/activity-log-manager/whoopsie/+merge/93899 Your team Activity Log Manager is requested to review the proposed merge of lp:~ev/activity-log-manager/whoopsie into lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
