[Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations into lp:activity-log-manager
The proposal to merge lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations into lp:activity-log-manager has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations/+merge/174096 -- https://code.launchpad.net/~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations/+merge/174096 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations into lp:activity-log-manager
Review: Approve -- https://code.launchpad.net/~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations/+merge/174096 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations into lp:activity-log-manager
Yes, Zeitgeist can handle Spreadsheets separately than Presentations but I can't think of a good reason why a typical user wouldn't just want a single toggle for all document types. I used zg's data/ontology/nfo.trig to see that Spreadsheets and Presentations are subclasses of Documents anyway (as are several other document types that we don't have toggles for). -- https://code.launchpad.net/~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations/+merge/174096 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations into lp:activity-log-manager
Review: Needs Information I am not sure if dropping Presentations and Spreadsheets makes sense because Datahub's recent-manager-provider.vala does take care of openoffice stuff. Check lines 113 and it is able to deduce the proper Interpretation from the mimetype (line 148) -- https://code.launchpad.net/~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations/+merge/174096 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations into lp:activity-log-manager
Jeremy Bicha has proposed merging
lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations into
lp:activity-log-manager.
Requested reviews:
Activity Log Manager (activity-log-manager)
Related bugs:
Bug #1198724 in Activity Log Manager: "Don't show Presentations &
Spreadsheets in Include list"
https://bugs.launchpad.net/activity-log-manager/+bug/1198724
For more details, see:
https://code.launchpad.net/~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations/+merge/174096
...and changes the capitalization of "Chat Logs" to "Chat logs" which I think
fits better in the style Unity is aiming towards in the dash and elsewhere.
--
https://code.launchpad.net/~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations/+merge/174096
Your team Activity Log Manager is requested to review the proposed merge of
lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations into
lp:activity-log-manager.
=== modified file 'src/unified-privacy.vala'
--- src/unified-privacy.vala 2013-07-09 23:46:11 +
+++ src/unified-privacy.vala 2013-07-11 02:28:33 +
@@ -115,13 +115,12 @@
});
mime_dict = new HashMap(str_hash, str_equal);
+ mime_dict.set(_("Applications"), NFO.SOFTWARE);
mime_dict.set(_("Music"), NFO.AUDIO);
mime_dict.set(_("Videos"), NFO.VIDEO);
mime_dict.set(_("Pictures"), NFO.IMAGE);
mime_dict.set(_("Documents"), NFO.DOCUMENT);
- mime_dict.set(_("Presentations"), NFO.PRESENTATION);
- mime_dict.set(_("Spreadsheets"), NFO.SPREADSHEET);
- mime_dict.set(_("Chat Logs"), NMO.IMMESSAGE);
+ mime_dict.set(_("Chat logs"), NMO.IMMESSAGE);
mime_dict.set(_("Emails"), NMO.EMAIL);
mime_dict.set(_("Websites"), NFO.WEBSITE);
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
