[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708335#action_12708335 ] Hadoop QA commented on ZOOKEEPER-395: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407797/ZOOKEEPER-395.patch against trunk revision 772843. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/70/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/70/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/70/console This message is automatically generated. Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-237) Add a Chroot request
[ https://issues.apache.org/jira/browse/ZOOKEEPER-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708599#action_12708599 ] Patrick Hunt commented on ZOOKEEPER-237: There are a couple of pros for server: 1) implement once rather than once for each client java/c 2) it has the additional benefit of being a security feature, rather than just a user convenience. would be interesting to look at the complexity of implementation client vs server. Add a Chroot request Key: ZOOKEEPER-237 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-237 Project: Zookeeper Issue Type: New Feature Components: c client, java client, server Reporter: Benjamin Reed Priority: Minor Fix For: 3.2.0 It would be nice to be able to root ZooKeeper handles at specific points in the namespace, so that applications that use ZooKeeper can work in their own rooted subtree. For example, if ops decides that application X can use the subtree /apps/X and application Y can use the subtree /apps/Y, X can to a chroot to /apps/X and then all its path references can be rooted at /apps/X. Thus when X creates the path /myid, it will actually be creating the path /apps/X/myid. There are two ways we can expose this mechanism: 1) We can simply add a chroot(String path) API, or 2) we can integrate into a service identifier scheme for example zk://server1:2181,server2:2181/my/root. I like the second form personally. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708621#action_12708621 ] Mahadev konar commented on ZOOKEEPER-395: - henry, are you going to add tests to this patch? Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-391) bookeeper mainline code should not be calling printStackTrace
[ https://issues.apache.org/jira/browse/ZOOKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-391: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) +1. I just committed this. bookeeper mainline code should not be calling printStackTrace - Key: ZOOKEEPER-391 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: ZOOKEEPER-391.patch Bookeeper mainline code is calling printStackTrace, it should be using logging instead. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-400) Issues with procedure to close ledger
Issues with procedure to close ledger - Key: ZOOKEEPER-400 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-400 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Priority: Critical When running a few experiments with BookKeeper, I found a couple of issues with closing a ledger: * On ClientCBWorker::run(), we should call setAddConfirmed before invoking the callback method. Otherwise, it is possible that an application closes a ledger before ClientCBWorker modifies the last confirmed operation, and the value written to ZooKeeper won't be the last one written; * LedgerHandle should write the last add confirmed instead of the last counter. The last attribute counts the operations issued, and we use it to determine the id of the next entry. If an application calls close upon receiving all callbacks, then with the previous modification, the last confirmed add must be equal to (last-1). However, if an application invokes close before receiving all callbacks, the ledger may be left in an inconsistent state because the last entry written to ZooKeeper may be an operation that hasn't completed yet. Although the modifications required are simple, they are important. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708634#action_12708634 ] Henry Robinson commented on ZOOKEEPER-395: -- Yes they're in hand - I didn't get much time to work on them yesterday but I've knocked a couple off today. Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-401) Cleaning of logging in the code and log4j configuration might be a good idea
Cleaning of logging in the code and log4j configuration might be a good idea Key: ZOOKEEPER-401 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-401 Project: Zookeeper Issue Type: Bug Reporter: Konstantin Boudnik Priority: Minor During the conversion of mainline tests from JUnit into TestNG it has been noticed (partially because TestNG doesn't intercept tests output) that some of log4j configuration parameters aren't very handy. E.g. - some of really non-important messages go at WARN level - by default all output goes into ConsoleAppender, which is a lot and makes it difficult to trace the execution from simply observing the console output - it'd be good to have a couple different log4j configs to be able to turn ConsoleAppender on and off by simply passing a parameter to ant build -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-397) mainline tests conversion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Boudnik updated ZOOKEEPER-397: - Attachment: ZOOKEEPER-397.patch Initial version of the patch for mainline tests conversion mainline tests conversion - Key: ZOOKEEPER-397 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-397 Project: Zookeeper Issue Type: Sub-task Components: tests Reporter: Konstantin Boudnik Assignee: Konstantin Boudnik Attachments: ZOOKEEPER-397.patch In this stage main set (src/java/test) of ZK tests will be converted to TestNG -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-397) mainline tests conversion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Boudnik updated ZOOKEEPER-397: - Status: Patch Available (was: In Progress) The following issues are taken care of by this patch: - all test cases of mainline suite are converted into native TestNG format - new target is added into build.xml to execute mainline tests under TestNG control rather than JUnit (it is now the default behavior for test-core-java) - a couple new classes are added to serve TestNG reporting purposes org.apache.zookeeper.MyInvocationReporter and MyOutputInterceptor. The first is intended to unify the logging of test execution invocation (instead of having a separate LOG.info for every test case, this class is added once); the second one prints out the information about executed test cases and the the result of the execution. It comes in this form: [testng] org.apache.zookeeper.test.WatcherFuncTest.testGetDataSync: Passed (in 12ms) Generally, I'd suggest to move the classes somewhere at the level above zookeeper for they will be serving more than one project in the future. - A number of test classes are fixed to work properly in the TestNG paradigm where test classes aren't inhered from some common TestCase thus their instances aren't normally getting thrown after each test method execution. Unsolved issues: 1) org.apache.zookeeper.test.WatcherTest:testWatchAutoResetWithPending fails with the following diagnostics Did not connect org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:95) at org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:174) when is executed along with all other tests. An attempt to increase some timeouts was made, but it didn't help a lot. 2) All standard output from the testcases along with the output of ConsoleAppender is printed to console now. I see two way of fixing it: - changing log4j configuration for the tests - creating, if possible, a workaround at the TestNG level to intercept stdout if needed The latter solution might be relative difficult to achieve. I would appreciate to get a review for this patch. mainline tests conversion - Key: ZOOKEEPER-397 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-397 Project: Zookeeper Issue Type: Sub-task Components: tests Reporter: Konstantin Boudnik Assignee: Konstantin Boudnik Attachments: ZOOKEEPER-397.patch In this stage main set (src/java/test) of ZK tests will be converted to TestNG -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-400) Issues with procedure to close ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-400: - Status: Patch Available (was: Open) Issues with procedure to close ledger - Key: ZOOKEEPER-400 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-400 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Priority: Critical Attachments: ZOOKEEPER-400.patch When running a few experiments with BookKeeper, I found a couple of issues with closing a ledger: * On ClientCBWorker::run(), we should call setAddConfirmed before invoking the callback method. Otherwise, it is possible that an application closes a ledger before ClientCBWorker modifies the last confirmed operation, and the value written to ZooKeeper won't be the last one written; * LedgerHandle should write the last add confirmed instead of the last counter. The last attribute counts the operations issued, and we use it to determine the id of the next entry. If an application calls close upon receiving all callbacks, then with the previous modification, the last confirmed add must be equal to (last-1). However, if an application invokes close before receiving all callbacks, the ledger may be left in an inconsistent state because the last entry written to ZooKeeper may be an operation that hasn't completed yet. Although the modifications required are simple, they are important. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-400) Issues with procedure to close ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-400: - Attachment: ZOOKEEPER-400.patch This patch implements the modifications as suggested and changes unit tests accordingly. Issues with procedure to close ledger - Key: ZOOKEEPER-400 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-400 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Priority: Critical Attachments: ZOOKEEPER-400.patch When running a few experiments with BookKeeper, I found a couple of issues with closing a ledger: * On ClientCBWorker::run(), we should call setAddConfirmed before invoking the callback method. Otherwise, it is possible that an application closes a ledger before ClientCBWorker modifies the last confirmed operation, and the value written to ZooKeeper won't be the last one written; * LedgerHandle should write the last add confirmed instead of the last counter. The last attribute counts the operations issued, and we use it to determine the id of the next entry. If an application calls close upon receiving all callbacks, then with the previous modification, the last confirmed add must be equal to (last-1). However, if an application invokes close before receiving all callbacks, the ledger may be left in an inconsistent state because the last entry written to ZooKeeper may be an operation that hasn't completed yet. Although the modifications required are simple, they are important. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-400) Issues with procedure to close ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira reassigned ZOOKEEPER-400: Assignee: Flavio Paiva Junqueira Issues with procedure to close ledger - Key: ZOOKEEPER-400 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-400 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Priority: Critical Attachments: ZOOKEEPER-400.patch When running a few experiments with BookKeeper, I found a couple of issues with closing a ledger: * On ClientCBWorker::run(), we should call setAddConfirmed before invoking the callback method. Otherwise, it is possible that an application closes a ledger before ClientCBWorker modifies the last confirmed operation, and the value written to ZooKeeper won't be the last one written; * LedgerHandle should write the last add confirmed instead of the last counter. The last attribute counts the operations issued, and we use it to determine the id of the next entry. If an application calls close upon receiving all callbacks, then with the previous modification, the last confirmed add must be equal to (last-1). However, if an application invokes close before receiving all callbacks, the ledger may be left in an inconsistent state because the last entry written to ZooKeeper may be an operation that hasn't completed yet. Although the modifications required are simple, they are important. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-397) mainline tests conversion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708657#action_12708657 ] Hadoop QA commented on ZOOKEEPER-397: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407926/ZOOKEEPER-397.patch against trunk revision 774081. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 144 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/71/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/71/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/71/console This message is automatically generated. mainline tests conversion - Key: ZOOKEEPER-397 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-397 Project: Zookeeper Issue Type: Sub-task Components: tests Reporter: Konstantin Boudnik Assignee: Konstantin Boudnik Attachments: ZOOKEEPER-397.patch In this stage main set (src/java/test) of ZK tests will be converted to TestNG -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-400) Issues with procedure to close ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708666#action_12708666 ] Hadoop QA commented on ZOOKEEPER-400: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407927/ZOOKEEPER-400.patch against trunk revision 774081. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/72/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/72/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/72/console This message is automatically generated. Issues with procedure to close ledger - Key: ZOOKEEPER-400 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-400 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Priority: Critical Attachments: ZOOKEEPER-400.patch When running a few experiments with BookKeeper, I found a couple of issues with closing a ledger: * On ClientCBWorker::run(), we should call setAddConfirmed before invoking the callback method. Otherwise, it is possible that an application closes a ledger before ClientCBWorker modifies the last confirmed operation, and the value written to ZooKeeper won't be the last one written; * LedgerHandle should write the last add confirmed instead of the last counter. The last attribute counts the operations issued, and we use it to determine the id of the next entry. If an application calls close upon receiving all callbacks, then with the previous modification, the last confirmed add must be equal to (last-1). However, if an application invokes close before receiving all callbacks, the ledger may be left in an inconsistent state because the last entry written to ZooKeeper may be an operation that hasn't completed yet. Although the modifications required are simple, they are important. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-397) mainline tests conversion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Boudnik updated ZOOKEEPER-397: - Attachment: testng-5.9-jdk15.jar Missed TestNG jar file mainline tests conversion - Key: ZOOKEEPER-397 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-397 Project: Zookeeper Issue Type: Sub-task Components: tests Reporter: Konstantin Boudnik Assignee: Konstantin Boudnik Attachments: testng-5.9-jdk15.jar, ZOOKEEPER-397.patch In this stage main set (src/java/test) of ZK tests will be converted to TestNG -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-395: - Attachment: ZOOKEEPER-395.patch This version contains tests for create, get, set, exists and delete code paths. The rest to follow as quickly as I can, but I don't want to hold up this patch trying to get all the unit tests finished if it can go ahead without. Also, this patch contains some important bugfixes (tests are good for finding those...) and a change to the way errors are handled. See zkpython/README for details. I haven't yet been able to figure out the right way to run python unittests from build.xml. Any ideas? Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
