[jira] Updated: (ZOOKEEPER-607) improve bookkeeper overview
[ https://issues.apache.org/jira/browse/ZOOKEEPER-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-607: - Attachment: ZOOKEEPER-607.patch Another preliminary patch addressing Ben's comment and introducing a figure. I'm uploading the figure separately, and it has to go to the resources/images folder to generate the docs. I also want to check that table of entry fields is consistent with the latest version of the system. improve bookkeeper overview --- Key: ZOOKEEPER-607 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-607 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Benjamin Reed Fix For: 3.3.0 Attachments: bk-overview.jpg, ZOOKEEPER-607.patch, ZOOKEEPER-607.patch, ZOOKEEPER-607.patch, ZOOKEEPER-607.patch fix the overview section in the bookkeeper documentation to introduce the programmer/admin to bookkeeper before giving the details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-607) improve bookkeeper overview
[ https://issues.apache.org/jira/browse/ZOOKEEPER-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-607: - Attachment: bk-overview.jpg Overview figure. improve bookkeeper overview --- Key: ZOOKEEPER-607 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-607 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Benjamin Reed Fix For: 3.3.0 Attachments: bk-overview.jpg, ZOOKEEPER-607.patch, ZOOKEEPER-607.patch, ZOOKEEPER-607.patch, ZOOKEEPER-607.patch fix the overview section in the bookkeeper documentation to introduce the programmer/admin to bookkeeper before giving the details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-635) Server supports listening on a specified network address
[ https://issues.apache.org/jira/browse/ZOOKEEPER-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831011#action_12831011 ] Patrick Hunt commented on ZOOKEEPER-635: I wrote the docs first, then during impl noticed that the two funnel down to the same code. I thought about it a bit and convinced myself that having two variable made it more understandable to the user, so I didn't change it from my original approach. I could go either way though. What would you call it if there's just one? clientPortBindAddress and just spec in the docs that it's either ip addr or name? Re the testing I was concerned that I could not get reproduceable tests if I tried tying it to a particular interface. Do you know (think of) a bulletproof approach? Something that will work in all cases, incl ipv6 (esp where the hosts file might cause problems) Server supports listening on a specified network address Key: ZOOKEEPER-635 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-635 Project: Zookeeper Issue Type: New Feature Components: server Affects Versions: 3.2.1 Reporter: Steve Chu Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-635.patch, ZOOKEEPER-635.patch The issue in maililist is located: http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200912.mbox/%3c4ac0d28c0912210242g58230a9ds1c55361561c70...@mail.gmail.com%3e I have checked the server size code, seems no this option provided. This feature is useful when we have more than two network interfaces, one for Internet and others for intranet. We want to run ZooKeeper in our intranet and not be exposed to outside world. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted
[ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831165#action_12831165 ] Mahadev konar commented on ZOOKEEPER-589: - +1 for the patch. When create a znode, a NULL ACL parameter cannot be accepted Key: ZOOKEEPER-589 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.2.1 Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux Reporter: Qian Ye Assignee: Benjamin Reed Fix For: 3.3.0 Attachments: ZOOKEEPER-524.patch In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node if null, the ACL of the parent will be used. However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-589) When create a znode, a NULL ACL parameter cannot be accepted
[ https://issues.apache.org/jira/browse/ZOOKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-589: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. thanks ben! When create a znode, a NULL ACL parameter cannot be accepted Key: ZOOKEEPER-589 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-589 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.2.1 Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux Reporter: Qian Ye Assignee: Benjamin Reed Fix For: 3.3.0 Attachments: ZOOKEEPER-524.patch In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node if null, the ACL of the parent will be used. However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-607) improve bookkeeper overview
[ https://issues.apache.org/jira/browse/ZOOKEEPER-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831169#action_12831169 ] Benjamin Reed commented on ZOOKEEPER-607: - +1 good job flavio. improve bookkeeper overview --- Key: ZOOKEEPER-607 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-607 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Benjamin Reed Fix For: 3.3.0 Attachments: bk-overview.jpg, ZOOKEEPER-607.patch, ZOOKEEPER-607.patch, ZOOKEEPER-607.patch, ZOOKEEPER-607.patch fix the overview section in the bookkeeper documentation to introduce the programmer/admin to bookkeeper before giving the details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-524) DBSizeTest is not really testing anything
[ https://issues.apache.org/jira/browse/ZOOKEEPER-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831170#action_12831170 ] Mahadev konar commented on ZOOKEEPER-524: - its a little tricky to have latency tests as a part of unit testing. I think we should remove it. ben are you going to remove the file and commit? DBSizeTest is not really testing anything - Key: ZOOKEEPER-524 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-524 Project: Zookeeper Issue Type: Bug Components: server, tests Reporter: Patrick Hunt Assignee: Benjamin Reed Priority: Minor Fix For: 3.3.0 DBSizeTest looks like it should be testing latency, but it doesn't seem to do it (assert is commented out). We need to decide if this test should be fixed, or just dropped. Also note: this test takes 40seconds on my system. Way too long. Perhaps async create operations should be used to populate the database. I also noticed that data size has a big impact on overall test time (1k vs 5 bytes is something like a 2x time diff for time to run the test). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-569) Failure of elected leader can lead to never-ending leader election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831203#action_12831203 ] Mahadev konar commented on ZOOKEEPER-569: - henry, are you working on a new patch adressing flavio's comments? Failure of elected leader can lead to never-ending leader election -- Key: ZOOKEEPER-569 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-569 Project: Zookeeper Issue Type: Bug Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-569.patch, zookeeper-569.patch, zookeeper-569.patch It is possible for basic LeaderElection to enter a situation where it never terminates. As an example, consider a three node cluster A, B and C. 1. In the first round, A votes for A, B votes for B and C votes for C 2. Since C B A, all nodes resolve to vote for C in the second round as there is no first round winner 3. A, B vote for C, but C fails. 4. C is not elected because neither A nor B hear from it, and so votes for it are discarded 5. A and B never reset their votes, despite not hearing from C, so continue to vote for it ad infinitum. Step 5 is the bug. If A and B reset their votes to themselves in the case where the heard-from vote set is empty, leader election will continue. I do not know if this affects running ZK clusters, as it is possible that the out-of-band failure detection protocols may cause leader election to be restarted anyhow, but I've certainly seen this in tests. I have a trivial patch which fixes it, but it needs a test (and tests for race conditions are hard to write!) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831206#action_12831206 ] Mahadev konar commented on ZOOKEEPER-579: - +1 the patch looks good. ll run zkpython tests and post the results here. henry, you might want to start adding comments to the zookeeper.c file so that its easier for other developers to work on it in case someone wants to pick it up. zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-569) Failure of elected leader can lead to never-ending leader election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831213#action_12831213 ] Henry Robinson commented on ZOOKEEPER-569: -- Yes, hoping to get it out this week. Failure of elected leader can lead to never-ending leader election -- Key: ZOOKEEPER-569 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-569 Project: Zookeeper Issue Type: Bug Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-569.patch, zookeeper-569.patch, zookeeper-569.patch It is possible for basic LeaderElection to enter a situation where it never terminates. As an example, consider a three node cluster A, B and C. 1. In the first round, A votes for A, B votes for B and C votes for C 2. Since C B A, all nodes resolve to vote for C in the second round as there is no first round winner 3. A, B vote for C, but C fails. 4. C is not elected because neither A nor B hear from it, and so votes for it are discarded 5. A and B never reset their votes, despite not hearing from C, so continue to vote for it ad infinitum. Step 5 is the bug. If A and B reset their votes to themselves in the case where the heard-from vote set is empty, leader election will continue. I do not know if this affects running ZK clusters, as it is possible that the out-of-band failure detection protocols may cause leader election to be restarted anyhow, but I've certainly seen this in tests. I have a trivial patch which fixes it, but it needs a test (and tests for race conditions are hard to write!) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-579: Fix Version/s: 3.3.0 marking it for 3.3 zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831217#action_12831217 ] Henry Robinson commented on ZOOKEEPER-579: -- It is a problem that the build is considered successful even though tests fail... I should make a new JIRA to fix that. What version of Python are you using? Both of those tests pass fine for me on Python 2.6, but it's possible that this is a version-related error. zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
