[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831170#action_12831170
 ] 

Mahadev konar commented on ZOOKEEPER-524:
-----------------------------------------

its a little tricky to have latency tests as a part of unit testing. I think we 
should remove it. ben are you going to remove the file and commit?

> DBSizeTest is not really testing anything
> -----------------------------------------
>
>                 Key: ZOOKEEPER-524
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-524
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Patrick Hunt
>            Assignee: Benjamin Reed
>            Priority: Minor
>             Fix For: 3.3.0
>
>
> DBSizeTest looks like it should be testing latency, but it doesn't seem to do 
> it (assert is commented out).
> We need to decide if this test should be fixed, or just dropped.
> Also note: this test takes 40seconds on my system. Way too long. Perhaps 
> async create operations should be used
> to populate the database. I also noticed that data size has a big impact on 
> overall test time (1k vs 5 bytes is something
> like a 2x time diff for time to run the test).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to