Build failed in Hudson: ZooKeeper-trunk #823
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/823/changes Changes: [henry] ZOOKEEPER-769: Leader can treat observers as quorum members [phunt] ZOOKEEPER-636. configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS [phunt] ZOOKEEPER-772. zkpython segfaults when watcher from async get children is invoked. [phunt] ZOOKEEPER-774. Recipes tests are slightly outdated: they do not compile against JUnit 4.8 [fpj] ZOOKEEPER-464. Need procedure to garbage collect ledgers (erwin via fpj) OBS: Adding missing files. [fpj] ZOOKEEPER-464. Need procedure to garbage collect ledgers (erwin via fpj) -- [...truncated 1326 lines...] [exec] ^api/index.html [exec] * [44/22] [1/32]0.217s 7.8Kb zookeeperHierarchicalQuorums.html [exec] * [45/21] [0/0] 0.026s 2.4Kb zookeeperHierarchicalQuorums.pdf [exec] * [46/20] [0/0] 0.347s 66.1Kb zookeeperAdmin.pdf [exec] ^api/index.html [exec] * [47/20] [1/31]0.126s 14.5Kb zookeeperJMX.html [exec] * [48/19] [0/0] 0.062s 11.5Kb bookkeeperStarted.pdf [exec] * [49/18] [0/0] 0.0090s 14.8Kb images/2pc.jpg [exec] ^api/index.html [exec] * [50/18] [1/31]0.248s 28.7Kb zookeeperTutorial.html [exec] * [51/17] [0/0] 0.016s 209b skin/images/rc-t-l-5-1header-2tab-selected-3tab-selected.png [exec] * [52/16] [0/0] 0.011s 68.1Kb images/zkperfreliability.jpg [exec] * [53/15] [0/0] 0.03s 2.9Kb skin/basic.css [exec] ^api/index.html [exec] * [54/15] [1/31]0.13s 10.9Kb bookkeeperConfig.html [exec] * [55/14] [0/0] 0.061s 8.5Kb bookkeeperConfig.pdf [exec] * [56/13] [0/0] 0.045s 5.5Kb zookeeperQuotas.pdf [exec] * [57/12] [0/0] 0.068s 28.2Kb zookeeperTutorial.pdf [exec] * [59/10] [0/0] 0.011s 199b skin/images/rc-t-l-5-1header-2searchbox-3searchbox.png [exec] ^api/index.html [exec] * [60/10] [1/32]0.136s 28.8Kb javaExample.html [exec] * [61/9][0/0] 0.092s 30.2Kb javaExample.pdf [exec] * [62/8][0/0] 0.817s 62.2Kb releasenotes.pdf [exec] ^api/index.html [exec] * [63/8][1/35]0.14s 20.0Kb zookeeperStarted.html [exec] * [64/7][0/0] 0.099s 22.6Kb zookeeperStarted.pdf [exec] * [65/6][0/0] 0.013s 215b skin/images/rc-t-r-5-1header-2tab-selected-3tab-selected.png [exec] * [67/4][0/0] 0.017s 214b skin/images/rc-t-r-5-1header-2tab-unselected-3tab-unselected.png [exec] ^api/index.html [exec] * [68/6][3/35]0.177s 11.1Kb index.html [exec] * [69/5][0/0] 0.085s 10.3Kb index.pdf [exec] * [70/4][0/0] 0.0060s 1.8Kb images/built-with-forrest-button.png [exec] ^api/index.html [exec] * [71/4][1/32]0.3s 13.5Kb bookkeeperStream.html [exec] * [72/3][0/0] 0.091s 8.0Kb bookkeeperStream.pdf [exec] * [73/2][0/0] 0.153s 43.3Kb zookeeperInternals.pdf [exec] * [74/1][0/0] 0.122s 11.9Kb zookeeperJMX.pdf [exec] * [75/0][0/0] 0.019s 121.2Kb images/bk-overview.jpg [exec] Total time: 0 minutes 15 seconds, Site size: 1,943,060 Site pages: 67 [exec] [exec] Copying broken links file to site root. [exec] [exec] Copying 1 file to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/docs/build/site [exec] [exec] - [exec] Static site was successfully generated at: [exec] http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/docs/build/site [exec] -- [exec] [exec] [exec] BUILD SUCCESSFUL [exec] Total time: 20 seconds [copy] Copying 109 files to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/docs [style] Warning: the task name style is deprecated. Use xslt instead. [style] Transforming into http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/docs init: [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/classes [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/lib [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/test/lib ivy-download: [get] Getting: http://repo2.maven.org/maven2/org/apache/ivy/ivy/2.1.0/ivy-2.1.0.jar [get] To: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/ivy-2.1.0.jar ivy-taskdef: ivy-init: ivy-retrieve:
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Savu Andrei updated ZOOKEEPER-744: -- Status: Patch Available (was: Open) Release Note: Added new 4letter word for monitoring: mntr The output is compatible with the Java properties format.Your script should expect content changes: new keys could be added in the future. Affects Version/s: 3.4.0 Assignee: Savu Andrei Add monitoring four-letter word --- Key: ZOOKEEPER-744 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744 Project: Zookeeper Issue Type: New Feature Components: server Affects Versions: 3.4.0 Reporter: Travis Crawford Assignee: Savu Andrei Attachments: zk-ganglia.png, ZOOKEEPER-744.patch Filing a feature request based on a zookeeper-user discussion. Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base) This command should initially export the following: (a) Count of instances in the ensemble. (b) Count of up-to-date instances in the ensemble. But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key space character value line: # Total number of instances in the ensemble zk_ensemble_instances_total 5 # Number of instances currently participating in the quorum. zk_ensemble_instances_active 4 From the mailing list: Date: Mon, 19 Apr 2010 12:10:44 -0700 From: Patrick Hunt ph...@apache.org To: zookeeper-u...@hadoop.apache.org Subject: Re: Recovery issue - how to debug? On 04/19/2010 11:55 AM, Travis Crawford wrote: It would be a lot easier from the operations perspective if the leader explicitly published some health stats: (a) Count of instances in the ensemble. (b) Count of up-to-date instances in the ensemble. This would greatly simplify monitoring alerting - when an instance falls behind one could configure their monitoring system to let someone know and take a look at the logs. That's a great idea. Please enter a JIRA for this - a new 4 letter word and JMX support. It would also be a great starter project for someone interested in becoming more familiar with the server code. Patrick -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: ZooKeeper-trunk #824
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/824/ -- [...truncated 373 lines...] [exec] * [43/22] [2/35]0.374s 54.4Kb zookeeperAdmin.html [exec] ^api/index.html [exec] * [44/22] [1/32]0.135s 7.8Kb zookeeperHierarchicalQuorums.html [exec] * [45/21] [0/0] 0.033s 2.4Kb zookeeperHierarchicalQuorums.pdf [exec] * [46/20] [0/0] 0.367s 66.1Kb zookeeperAdmin.pdf [exec] ^api/index.html [exec] * [47/20] [1/31]0.265s 14.5Kb zookeeperJMX.html [exec] * [48/19] [0/0] 0.074s 11.5Kb bookkeeperStarted.pdf [exec] * [49/18] [0/0] 0.0080s 14.8Kb images/2pc.jpg [exec] ^api/index.html [exec] * [50/18] [1/31]0.137s 28.7Kb zookeeperTutorial.html [exec] * [51/17] [0/0] 0.026s 209b skin/images/rc-t-l-5-1header-2tab-selected-3tab-selected.png [exec] * [52/16] [0/0] 0.011s 68.1Kb images/zkperfreliability.jpg [exec] * [53/15] [0/0] 0.03s 2.9Kb skin/basic.css [exec] ^api/index.html [exec] * [54/15] [1/31]0.153s 10.9Kb bookkeeperConfig.html [exec] * [55/14] [0/0] 0.153s 8.5Kb bookkeeperConfig.pdf [exec] * [56/13] [0/0] 0.04s 5.5Kb zookeeperQuotas.pdf [exec] * [57/12] [0/0] 0.069s 28.2Kb zookeeperTutorial.pdf [exec] * [59/10] [0/0] 0.014s 199b skin/images/rc-t-l-5-1header-2searchbox-3searchbox.png [exec] ^api/index.html [exec] * [60/10] [1/32]0.151s 28.8Kb javaExample.html [exec] * [61/9][0/0] 0.091s 30.2Kb javaExample.pdf [exec] * [62/8][0/0] 0.69s 62.2Kb releasenotes.pdf [exec] ^api/index.html [exec] * [63/8][1/35]0.267s 20.0Kb zookeeperStarted.html [exec] * [64/7][0/0] 0.092s 22.6Kb zookeeperStarted.pdf [exec] * [65/6][0/0] 0.011s 215b skin/images/rc-t-r-5-1header-2tab-selected-3tab-selected.png [exec] * [67/4][0/0] 0.013s 214b skin/images/rc-t-r-5-1header-2tab-unselected-3tab-unselected.png [exec] ^api/index.html [exec] * [68/6][3/35]0.157s 11.1Kb index.html [exec] * [69/5][0/0] 0.095s 10.3Kb index.pdf [exec] * [70/4][0/0] 0.0040s 1.8Kb images/built-with-forrest-button.png [exec] ^api/index.html [exec] * [71/4][1/32]0.173s 13.5Kb bookkeeperStream.html [exec] * [72/3][0/0] 0.099s 8.0Kb bookkeeperStream.pdf [exec] * [73/2][0/0] 0.264s 43.3Kb zookeeperInternals.pdf [exec] * [74/1][0/0] 0.098s 11.9Kb zookeeperJMX.pdf [exec] * [75/0][0/0] 0.01s 121.2Kb images/bk-overview.jpg [exec] Total time: 0 minutes 15 seconds, Site size: 1,943,060 Site pages: 67 [exec] [exec] Copying broken links file to site root. [exec] [exec] Copying 1 file to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/docs/build/site [exec] [exec] - [exec] Static site was successfully generated at: [exec] http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/docs/build/site [exec] -- [exec] [exec] [exec] BUILD SUCCESSFUL [exec] Total time: 20 seconds [copy] Copying 109 files to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/docs [style] Warning: the task name style is deprecated. Use xslt instead. [style] Transforming into http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/docs init: [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/classes [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/lib [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/test/lib ivy-download: ivy-taskdef: ivy-init: ivy-retrieve: [ivy:retrieve] :: Ivy 2.1.0 - 20090925235825 :: http://ant.apache.org/ivy/ :: [ivy:retrieve] :: loading settings :: file = http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/ivysettings.xml [ivy:retrieve] :: resolving dependencies :: org.apache.zookeeper#zookeeper;3.4.0 [ivy:retrieve] confs: [default] [ivy:retrieve] found log4j#log4j;1.2.15 in default [ivy:retrieve] found jline#jline;0.9.94 in default [ivy:retrieve] :: resolution report :: resolve 168ms :: artifacts dl 6ms - | |modules|| artifacts | | conf | number|
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872176#action_12872176 ] Hadoop QA commented on ZOOKEEPER-744: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445586/ZOOKEEPER-744.patch against trunk revision 947063. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/console This message is automatically generated. Add monitoring four-letter word --- Key: ZOOKEEPER-744 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744 Project: Zookeeper Issue Type: New Feature Components: server Affects Versions: 3.4.0 Reporter: Travis Crawford Assignee: Savu Andrei Attachments: zk-ganglia.png, ZOOKEEPER-744.patch Filing a feature request based on a zookeeper-user discussion. Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base) This command should initially export the following: (a) Count of instances in the ensemble. (b) Count of up-to-date instances in the ensemble. But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key space character value line: # Total number of instances in the ensemble zk_ensemble_instances_total 5 # Number of instances currently participating in the quorum. zk_ensemble_instances_active 4 From the mailing list: Date: Mon, 19 Apr 2010 12:10:44 -0700 From: Patrick Hunt ph...@apache.org To: zookeeper-u...@hadoop.apache.org Subject: Re: Recovery issue - how to debug? On 04/19/2010 11:55 AM, Travis Crawford wrote: It would be a lot easier from the operations perspective if the leader explicitly published some health stats: (a) Count of instances in the ensemble. (b) Count of up-to-date instances in the ensemble. This would greatly simplify monitoring alerting - when an instance falls behind one could configure their monitoring system to let someone know and take a look at the logs. That's a great idea. Please enter a JIRA for this - a new 4 letter word and JMX support. It would also be a great starter project for someone interested in becoming more familiar with the server code. Patrick -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872219#action_12872219 ] Ivan Kelly commented on ZOOKEEPER-775: -- This patch doesn't include the ssl cert server.p12 as it's binary. This causes some tests to fail. Perhaps you should add it to libs.zip? A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-776: Status: Open (was: Patch Available) there are two things we need to fix: 1) this just pushes the problems slightly. someone can still use a timeout of 1 and run into the same problem. we should make the minimum timeout configurable using a system property. (i would suggest zookeeper.minTimeout) and set it to something reasonable like 100. 2) we should also put a similar check in the C client. let me know if you are willing to make those changes. i'd be glad to pitch in if you cannot. API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.3.1, 3.3.0, 3.2.2 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-775: Attachment: libs.zip added missing file indicated by ivan A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-775: Attachment: (was: libs.zip) A large scale pub/sub system Key: ZOOKEEPER-775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 Project: Zookeeper Issue Type: New Feature Components: contrib Reporter: Benjamin Reed Fix For: 3.4.0 Attachments: libs.zip, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch we have developed a large scale pub/sub system based on ZooKeeper and BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872281#action_12872281 ] Benjamin Reed commented on ZOOKEEPER-733: - i figured out the timing issue for ACLTest. if you look at how NIOServerCnxn handles the readConnectRequest, you will notice that it disables the receipt of packets until the connect request is processed successfully. if you do that with netty, the ACLTest should work. use netty to handle client connections -- Key: ZOOKEEPER-733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed Attachments: accessive.jar, moved.zip, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch we currently have our own asynchronous NIO socket engine to be able to handle lots of clients with a single thread. over time the engine has become more complicated. we would also like the engine to use multiple threads on machines with lots of cores. plus, we would like to be able to support things like SSL. if we switch to netty, we can simplify our code and get the previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872284#action_12872284 ] Travis Crawford commented on ZOOKEEPER-744: --- @savu - Sometimes the right thing is publishing everything, sometimes not. In this case I'll have some filtering/formatting in the zk2ganglia script. Add monitoring four-letter word --- Key: ZOOKEEPER-744 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744 Project: Zookeeper Issue Type: New Feature Components: server Affects Versions: 3.4.0 Reporter: Travis Crawford Assignee: Savu Andrei Attachments: zk-ganglia.png, ZOOKEEPER-744.patch Filing a feature request based on a zookeeper-user discussion. Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base) This command should initially export the following: (a) Count of instances in the ensemble. (b) Count of up-to-date instances in the ensemble. But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key space character value line: # Total number of instances in the ensemble zk_ensemble_instances_total 5 # Number of instances currently participating in the quorum. zk_ensemble_instances_active 4 From the mailing list: Date: Mon, 19 Apr 2010 12:10:44 -0700 From: Patrick Hunt ph...@apache.org To: zookeeper-u...@hadoop.apache.org Subject: Re: Recovery issue - how to debug? On 04/19/2010 11:55 AM, Travis Crawford wrote: It would be a lot easier from the operations perspective if the leader explicitly published some health stats: (a) Count of instances in the ensemble. (b) Count of up-to-date instances in the ensemble. This would greatly simplify monitoring alerting - when an instance falls behind one could configure their monitoring system to let someone know and take a look at the logs. That's a great idea. Please enter a JIRA for this - a new 4 letter word and JMX support. It would also be a great starter project for someone interested in becoming more familiar with the server code. Patrick -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872326#action_12872326 ] Gregory Haskins commented on ZOOKEEPER-776: --- I will take a crack at it API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Haskins updated ZOOKEEPER-776: -- Attachment: zookeeper-776-fix.patch This is an updated version that supports a default minTimeout of 100, and loading a new default from zookeeper.properties - zookeeper.minTimeout API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch, zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872400#action_12872400 ] Benjamin Reed commented on ZOOKEEPER-776: - you were a little over ambitious gregory :) you don't need to load from a properties file. just check the system property and if it isn't sent (or not a number) use 100. are you going to be able to patch the C client too? API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch, zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
