Benjamin Reed updated ZOOKEEPER-776:

    Status: Open  (was: Patch Available)

there are two things we need to fix:

1) this just pushes the problems slightly. someone can still use a timeout of 1 
and run into the same problem. we should make the minimum timeout configurable 
using a system property. (i would suggest "zookeeper.minTimeout") and set it to 
something reasonable like 100.
2) we should also put a similar check in the C client.

let me know if you are willing to make those changes. i'd be glad to pitch in 
if you cannot.

> API should sanity check sessionTimeout argument
> -----------------------------------------------
>                 Key: ZOOKEEPER-776
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: c client, java client
>    Affects Versions: 3.3.1, 3.3.0, 3.2.2
>         Environment: OSX 10.6.3, JVM 1.6.0-20
>            Reporter: Gregory Haskins
>            Priority: Minor
>             Fix For: 3.4.0
>         Attachments: zookeeper-776-fix.patch
> passing in a "0" sessionTimeout to ZooKeeper() constructor leads to errors in 
> subsequent operations.  It would be ideal to capture this configuration error 
> at the source by throwing something like an IllegalArgument exception when 
> the bogus sessionTimeout is specified, instead of later when it is utilized.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to