[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12842212#action_12842212 ] Steven Cheng commented on ZOOKEEPER-543: Extra import was left in there for some reason. Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-543: --- Attachment: ZOOKEEPER-543.patch Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Cheng updated ZOOKEEPER-622:
---
Attachment: ZOOKEEPER-622.patch
A working test case for watch transfer with multiple hosts. I left testScript
in there because it is quite useful for basic sanity testing for the scripts.
Test for pending watches in send_set_watches should be moved
Key: ZOOKEEPER-622
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Steven Cheng
Assignee: Benjamin Reed
Fix For: 3.3.0
Attachments: ZOOKEEPER-622.patch, ZOOKEEPER-622.patch,
ZOOKEEPER-622.patch
Valgrind found:
{quote}
==2357== Conditional jump or move depends on uninitialised value(s)
==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
(TestZookeeperClose.cc:161)
==2357==by 0x806C6BF: CppUnit::TestCallerZookeeper_close::runTest()
(TestCaller.h:166)
{quote}
zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12837139#action_12837139
]
Steven Cheng commented on ZOOKEEPER-622:
This patch works but is still in rough shape! The multi host test servers are
started on separate ports and are running concurrently with the single host
test server. Would be helpful to make this more clear.
Paths still hardcoded to /tmp.
zooX.cfg are in the patch but are generated by generateCfgs.sh
I encountered a ZCONNECTIONLOSS from an operation executed after the client
reconnects to a new host. Adds an awkward section to the test case. I guess
in some sense the client should not be oblivious to one of these lucky
disconnect/reconnect situations.
Test for pending watches in send_set_watches should be moved
Key: ZOOKEEPER-622
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Steven Cheng
Assignee: Benjamin Reed
Fix For: 3.3.0
Attachments: ZOOKEEPER-622.patch, ZOOKEEPER-622.patch,
ZOOKEEPER-622.patch
Valgrind found:
{quote}
==2357== Conditional jump or move depends on uninitialised value(s)
==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
(TestZookeeperClose.cc:161)
==2357==by 0x806C6BF: CppUnit::TestCallerZookeeper_close::runTest()
(TestCaller.h:166)
{quote}
zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-543: --- Attachment: ZOOKEEPER-543.patch C and Java version of testSequentialNodeData. I found that almost all the tests in TestClient.cc need THREADED and this test also would not work without THREADED even though there's no reason it shouldn't. Is there a reason for this? Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805743#action_12805743 ] Steven Cheng commented on ZOOKEEPER-543: Can do, shouldn't take too long I think. Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805746#action_12805746
]
Steven Cheng commented on ZOOKEEPER-622:
Hi Ben, sorry about that, this was just a rough cut patch, I got stuck when I
tried to add zkMultiServer.sh into the tests since the Zookeeper server gets
started in main() rather than in the test classes, so I posted it here to see
if I was on the right track. Not sure if that was the right thing to do,
mainly didn't want to go through and start changing all of the test setup
without checking first.
If there isn't anything wrong with moving the Zookeeper server startup into the
setup() methods of the test classes, I can probably get the patch starting up
multiple servers in /tmp and the basic test in place after some work. To
handle $base_dir I was planning to generate the config files somewhere in
$base_dir and point the server to them.
Test for pending watches in send_set_watches should be moved
Key: ZOOKEEPER-622
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Steven Cheng
Assignee: Benjamin Reed
Fix For: 3.3.0
Attachments: ZOOKEEPER-622.patch, ZOOKEEPER-622.patch
Valgrind found:
{quote}
==2357== Conditional jump or move depends on uninitialised value(s)
==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
(TestZookeeperClose.cc:161)
==2357==by 0x806C6BF: CppUnit::TestCallerZookeeper_close::runTest()
(TestCaller.h:166)
{quote}
zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-543: --- Attachment: ZOOKEEPER-543.patch I took a look at ClientTest and testMultipleWatcherObjs seems to cover most of what the lock test does. There is a fair bit of overlap with testSequentialNodeNames and the queue test, but the queue test tests the data. I moved the queue test into ClientTest and changed it to make it more similar to testSequentialNodeNames in this patch. Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12803574#action_12803574 ] Steven Cheng commented on ZOOKEEPER-543: Hi Mahadev, my original idea was to have small tests that tested the basic features needed to implement the examples without bringing in a full API. testQueue tests that creating nodes works properly, in a similar way that a queue would use them. testLock tests that create and delete work properly in a way that a lock would use them. At this point I think that the queue and lock recipes do a good job of covering these cases, so these tests are probably not needed. Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802085#action_12802085 ] Steven Cheng commented on ZOOKEEPER-458: Couldn't figure out where it's happening and I don't get quite the same error. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801229#action_12801229 ] Steven Cheng commented on ZOOKEEPER-458: Hi Mahadev, haven't been able to look at it until now, I'll take a look and update on what I find. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801264#action_12801264
]
Steven Cheng commented on ZOOKEEPER-622:
Looks like I need to add multi server handling to the C tests to manage this,
I'll try to get a rough cut done and post the patch.
Test for pending watches in send_set_watches should be moved
Key: ZOOKEEPER-622
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Steven Cheng
Fix For: 3.3.0
Attachments: ZOOKEEPER-622.patch
Valgrind found:
{quote}
==2357== Conditional jump or move depends on uninitialised value(s)
==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
(TestZookeeperClose.cc:161)
==2357==by 0x806C6BF: CppUnit::TestCallerZookeeper_close::runTest()
(TestCaller.h:166)
{quote}
zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12790534#action_12790534
]
Steven Cheng commented on ZOOKEEPER-622:
Sounds good Mahadev, I'll get started on it.
Test for pending watches in send_set_watches should be moved
Key: ZOOKEEPER-622
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Steven Cheng
Fix For: 3.3.0
Attachments: ZOOKEEPER-622.patch
Valgrind found:
{quote}
==2357== Conditional jump or move depends on uninitialised value(s)
==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
(TestZookeeperClose.cc:161)
==2357==by 0x806C6BF: CppUnit::TestCallerZookeeper_close::runTest()
(TestCaller.h:166)
{quote}
zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Cheng updated ZOOKEEPER-622:
---
Attachment: ZOOKEEPER-622.patch
This patch moves the check for outstanding watches in send_set_watches, going
to try to figure out how to test this later, any suggestions?
Test for pending watches in send_set_watches should be moved
Key: ZOOKEEPER-622
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Steven Cheng
Fix For: 3.3.0
Attachments: ZOOKEEPER-622.patch
Valgrind found:
{quote}
==2357== Conditional jump or move depends on uninitialised value(s)
==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
(TestZookeeperClose.cc:161)
==2357==by 0x806C6BF: CppUnit::TestCallerZookeeper_close::runTest()
(TestCaller.h:166)
{quote}
zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789055#action_12789055 ] Steven Cheng commented on ZOOKEEPER-458: I'm out of ideas for now, can't find anything obvious Mahadev, I will think about it some more. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789148#action_12789148 ] Steven Cheng commented on ZOOKEEPER-458: Hmm.. I tried with a lower timeout on my computer and couldn't get the failure. I'll look around the timer stuff. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch Maybe free_buffer is getting called twice on the same structure, changed patch to null out the buffer field. If free_buffer is getting called twice, we should see a __wrap_free ... p = 0 in the backtrace. It's also possible that the buffer is getting free'd since buffer is shared with the iarchive zookeeper.c:1781 but I couldn't find any paths where the iarchive buffer is free'd by manually tracing through. One thing I am confused about is that the segfault happens at the end of the testConnectIndex1 test, but the path that it is taking is processing outstanding synchronous completions. The only synchronous completion that could be there is the zoo_exists call, but this was completed at the beginning of the test, before the server was stopped. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch Really looks like something with free... maybe this patch will be able to catch it better... marks the buffer node by setting len=-1 and checks it later. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch This patch, rather. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch Sorry Mahadev, for some reason an old patch got uploaded instead. I'll make sure to double-check next time. I changed the tests so that a server was available and then disconnects, these ones pass for me. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Status: Patch Available (was: Open) connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782513#action_12782513 ] Steven Cheng commented on ZOOKEEPER-458: Now I'm wondering how the old patch passed? Strange. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782633#action_12782633 ] Steven Cheng commented on ZOOKEEPER-458: These ones are passing for me, and still pass after svn update. Can't tell where it segfaults, it should have connected to the server if the zoo_exists returns ZOK? connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782702#action_12782702 ] Steven Cheng commented on ZOOKEEPER-458: Any debugging help you can give would be great Mahadev. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch This patch ensures that 0 = connect_index addrs_count whenever connect_index is set to a non-zero value. Includes two tests that this property is maintained over disconnects. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779815#action_12779815 ] Steven Cheng commented on ZOOKEEPER-458: I think so... I would need to force handle_error to get called to bump up connect_index. Any tips on the best way to do this? Looks like handle_error gets called from either a socket error or if there's an auth fail. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-414) zkServer.sh is duplicated in a couple of places
[ https://issues.apache.org/jira/browse/ZOOKEEPER-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777336#action_12777336 ] Steven Cheng commented on ZOOKEEPER-414: Current list of zkServer.sh files: ./src/contrib/zkpython/src/test/zkServer.sh ./src/contrib/rest/src/test/zkServer.sh ./src/c/tests/zkServer.sh ./src/recipes/queue/src/c/tests/zkServer.sh ./src/recipes/lock/src/c/tests/zkServer.sh ./bin/zkServer.sh All of the extra ones are for testing. Looked into this a bit, main difference between bin/zkServer.sh and the testing scripts is that the testing scripts delete the zookeeper data. I'm guessing that it wouldn't be helpful to have zkServer.sh delete? One option is to create bin/testzkServer.sh that handles the deleting and calls zkServer.sh as needed. Then a conf file just needs to be created and the test suites can be hooked in to the new script. zkServer.sh is duplicated in a couple of places --- Key: ZOOKEEPER-414 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-414 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed Assignee: Mahadev konar Fix For: 3.3.0 we have zkServer.sh in 4 different places. some differ only in whitespace. it would be much more maintainable if there were only one version that everything used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776770#action_12776770 ] Steven Cheng commented on ZOOKEEPER-550: Haven't done a make install yet with zookeeper so that part should be ok, I'll try applying the patch to a fresh checkout Mahadev. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776854#action_12776854 ] Steven Cheng commented on ZOOKEEPER-550: Just tried with a fresh checkout. The recipes depend on the libraries being in src/c which only happens if you run make in that directory. Also src/recipes/lock/src/c/tests/zkServer.sh does not have execute permissions on a fresh checkout, src/recipes/queue/src/c/tests/zkServer.sh also won't have permission because it's in a patch. What would be a good solution to the library issue? I noticed that the c client test builds to build/test/test-cppunit, the recipe tests could get the library from there instead of src/c? Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Status: In Progress (was: Patch Available) Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Attachment: ZOOKEEPER-550.patch Added threaded test cases to C and Java recipes, uncovered a few bugs in the Java version where too many methods were synchronized, and orderedChildren() needs to throw the NoNodeException so that take() works properly. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Status: Patch Available (was: In Progress) Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Attachment: ZOOKEEPER-550.patch Sorry, missed that, fixed in this patch. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-563) ant test for recipes is broken.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12771178#action_12771178 ] Steven Cheng commented on ZOOKEEPER-563: Looks like it breaks after ant clean on root, but the recipes will run if ivy downloads the files after ant test on root. Is the right thing to integrate ivy into recipes/build.xml? ant test for recipes is broken. --- Key: ZOOKEEPER-563 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-563 Project: Zookeeper Issue Type: Bug Components: build Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 With ZOOKEEPER-529 checked in, ant test for recipes broke. Its a minor change to the build for including librariries from the new location where jars are downloaded by ivy. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Status: In Progress (was: Patch Available) Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Status: Patch Available (was: In Progress) Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Attachment: ZOOKEEPER-550.patch Java and C queue recipe. Tests included pass. Please review. The autotools config was copied from the lock recipe, I think I changed all the right strings and added the right files to SVN. This also includes a small fix for the zkServer.sh in the lock recipe. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12768418#action_12768418 ] Steven Cheng commented on ZOOKEEPER-550: Java version seems good, still missing the C version that I'm working on. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Attachment: ZOOKEEPER-550.patch bq. 1) Sorry, didn't create a patch for the README since it was a small change, it is included in this patch with the comment revision. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766720#action_12766720 ] Steven Cheng commented on ZOOKEEPER-550: Thank you for the feedback Mahadev: 1) Updated the README.txt 2) I'll revise it to make it more clear. 3) A return is done after the delete in remove() and take(), only the client that deletes the node can return the data, all others will get a NoNodeException. If different exception is thrown then it will exit the method. The loop can only continue if NoNodeExceptions are thrown, these are only thrown when another client has remove()d or take()n the node. 4) The current patch takes in an acl, I mostly copied this handling from the lock recipe, is there more handling I should add? I would like to integrate more of the common pieces of the lock recipe into the queue but I think I will leave this to later. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Attachment: ZOOKEEPER-550.patch Changed tabs to spaces and added a README.txt which is a copy from the lock version but without reference to a C implementation. I'll get started on a C version, the C lock recipe is a nice base to start from. Should the C version be submitted under this JIRA as well? Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Status: Patch Available (was: Open) Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12764764#action_12764764 ] Steven Cheng commented on ZOOKEEPER-550: Thanks, great idea, I'll change it. Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Attachment: ZOOKEEPER-550.patch Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-550) Java Queue Recipe
[ https://issues.apache.org/jira/browse/ZOOKEEPER-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-550: --- Attachment: ZOOKEEPER-550.patch Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-550) Java Queue Recipe
Java Queue Recipe - Key: ZOOKEEPER-550 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.2.1 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-550.patch This patch adds a recipe for creating a distributed queue with ZooKeeper similar to the WriteLock recipe and some sequential tests. This early attempt follows the Java BlockingQueue interface, though it doesn't implement it since I don't think there's a good reason for it to be Iterable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-543) Tests for ZooKeeper examples
Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-543: --- Attachment: ZOOKEEPER-543.patch Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762807#action_12762807 ] Steven Cheng commented on ZOOKEEPER-543: There's a bug in the node name processing, it tries to remove the full path from the string before parsing the id. The test still passes because of the 0 padding on the names. I'll fix this. Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-543: --- Attachment: ZOOKEEPER-543.patch Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-543: --- Attachment: (was: ZOOKEEPER-543.patch) Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
