Steven Cheng commented on ZOOKEEPER-622:

Hi Ben, sorry about that, this was just a rough cut patch, I got stuck when I 
tried to add zkMultiServer.sh into the tests since the Zookeeper server gets 
started in main() rather than in the test classes, so I posted it here to see 
if I was on the right track.   Not sure if that was the right thing to do, 
mainly didn't want to go through and start changing all of the test setup 
without checking first.

If there isn't anything wrong with moving the Zookeeper server startup into the 
setup() methods of the test classes, I can probably get the patch starting up 
multiple servers in /tmp and the basic test in place after some work.  To 
handle $base_dir I was planning to generate the config files somewhere in 
$base_dir and point the server to them.

> Test for pending watches in send_set_watches should be moved
> ------------------------------------------------------------
>                 Key: ZOOKEEPER-622
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>            Reporter: Steven Cheng
>            Assignee: Benjamin Reed
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-622.patch, ZOOKEEPER-622.patch
> Valgrind found:
> {quote}
> ==2357== Conditional jump or move depends on uninitialised value(s)
> ==2357==    at 0x807FDCA: check_events (zookeeper.c:1180)
> ==2357==    by 0x808043A: zookeeper_process (zookeeper.c:1775)
> ==2357==    by 0x806A21B: Zookeeper_close::testCloseConnected1() 
> (TestZookeeperClose.cc:161)
> ==2357==    by 0x806C6BF: CppUnit::TestCaller<Zookeeper_close>::runTest() 
> (TestCaller.h:166)
> {quote}
> zookeeper.c:1180 was the first if in send_set_watches.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to