[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702356#action_12702356 ] Luca Telloli commented on ZOOKEEPER-103: Any update on this issue? I think it would be good to have at least zookeeper and related jars (like bookkeeper) in a maven repository for inclusion in projects that use maven or ivy for building > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620016#action_12620016 ] Mahadev konar commented on ZOOKEEPER-103: - +1 on ben's comments the maven tree changes have caused considerable distraction for us and we havent been committing recipes just because of the maven changes. 3.0 is an important release for us and we can keep this issue open while we work on the 3.0 release . We can be a little relaxed after we have 3.0 out the door and that will give us a chance to reflect and work on the directory structure with maven. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620013#action_12620013 ] Benjamin Reed commented on ZOOKEEPER-103: - I think we need to postpone this issue. It is causing a tremendous amount of distraction when we are right in the middle of getting out the next release. The proposal here conflicts with the proposal for maintaining recipes under contrib. It is also starting to hold up patches since the tree structure is considered in flux while this issue is open. In my opinion now is not the time for a tree restructuring. Lets focus on getting the patch backlog cleaned out and getting the release ready. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620004#action_12620004 ] Hiram Chirino commented on ZOOKEEPER-103: - I think this patch is a nice middle ground. It's using only ANT, but adopting the maven directory conventions. So Pat's -1 does not really apply to this issue since ant is the only build system being used. Could the rest of the committers please post their thoughts on this? BTW once this is implemented, it should be easier to implement: ZOOKEEPER-95 and ZOOKEEPER-98 > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619975#action_12619975 ] Doug Cutting commented on ZOOKEEPER-103: > On ZOOKEEPER-83 we plainly agreed that we were going to compromise and use > maven conventions for the directory structure I don't see that. Pat & Nigel agreed that we should be able to produce Maven artifacts. Mahadev supported Maven naming conventions, but I don't see Pat reversing his -1 on supporting multiple build systems. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619871#action_12619871 ] Hiram Chirino commented on ZOOKEEPER-103: - On ZOOKEEPER-83 we plainly agreed that we were going to compromise and use maven conventions for the directory structure but only include a ant build. And yes.. it's suspicious because it IS using the maven conventions. There is no doubt about it. That was part of the compromise. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619710#action_12619710 ] Doug Cutting commented on ZOOKEEPER-103: You didn't answer my question: Is there a way to configure Maven otherwise? This issue looks suspiciously like trying to support two different build systems, and, on ZOOKEEPER-83, Pat said, "I'm -1 on supporting multiple build systems." > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619658#action_12619658 ] Hiram Chirino commented on ZOOKEEPER-103: - The redundancy is a good convention since it makes it obvious which directory builds which jar file. And prefixing all the zookeeper jars with zookeeper- is a good convention too since it will help uniquely identify your jars in a project that uses multiple 3rd party jars. For example if ActiveMQ starts shipping some of the zookeeper bits in it's distribution. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619111#action_12619111 ] Doug Cutting commented on ZOOKEEPER-103: > The maven convention is to have each module/jar the it's own directory who's > name matches the module/jar name. That imposes big, redundant directory names. Is there no way to configure Maven otherwise? > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619107#action_12619107 ] Hiram Chirino commented on ZOOKEEPER-103: - The maven convention is to have each module/jar the it's own directory who's name matches the module/jar name. The ant build does not do this (yet) but in the maven build, you end up with zookeeper-xxx.jar files. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617973#action_12617973 ] Doug Cutting commented on ZOOKEEPER-103: > we could group things into directories but that would just deepen the > directory tree and not add tremendous amount of value. I would prefer all sources under a single src/ directory, and not to have directories with redundant 'zookeeper-xxx' names. Separate subdirectories of trunk/src/ are no less decoupled than separate subdirectories of trunk/. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617859#action_12617859 ] Hiram Chirino commented on ZOOKEEPER-103: - Generally it's just a good sign showing that stuff is decoupled. we could group things into directories but that would just deepen the directory tree and not add tremendous amount of value. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617857#action_12617857 ] Patrick Hunt commented on ZOOKEEPER-103: I reviewed the patch itself (the patch file and the script) against the code (this was on friday 7/25). It applied cleanly and the build/test continued to function properly. I'm a bit concerned that this new structure results in a large number of toplevel (trunk) directories... just me or anyone else think this might be an issue? > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617823#action_12617823 ] Hiram Chirino commented on ZOOKEEPER-103: - Benjamin, Good point.. I'll comment on ZOOKEERER-80 on how best to sort out the recipies/contrib stuff. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617691#action_12617691 ] Mahadev konar commented on ZOOKEEPER-103: - i like the new source tree structure --- the only problem being that with contrib modules we will have lots of small contribs--- will they all have a top level directory? > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617503#action_12617503 ] Hiram Chirino commented on ZOOKEEPER-103: - Any updates on this? > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617089#action_12617089 ] Hiram Chirino commented on ZOOKEEPER-103: - Hi Patrick yes. Lots projects just keep it flat like that. Some project will group stuff in a directory if there is a specific grouping to the modules. Generally it's more specific than a general 'contrib' grouping though. Also something to think about is the possibility of having independent release cycles for some of the modules. At this stage of the I don't think we need to worry about that complexity. Benjamin, Generally the final binary distribution does make that distinction. Some organize as: /bin : start scripts /lib : the main zoo keeper jar /lib/extras or /lib/contrib: optional libs that are not required to run ZK /doc : /src etc. etc. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617084#action_12617084 ] Benjamin Reed commented on ZOOKEEPER-103: - It would be nice to have a contrib directory to separate out what is mainline and what is not. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617078#action_12617078 ] Patrick Hunt commented on ZOOKEEPER-103: What about additional contributions, they would be new directories at the same level (child of trunk)? trunk/zookeeper-recipes/..., trunk/zookeeper-spring/..., trunk/zookeeper-fuse/..., etc...? > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
