[Zope-CMF] GenericSetup Zope support
Currently GenericSetup trunk no longer runs on Zope 2.10. If I try to run the tests I get this: File /src/Products.GenericSetup/Products/GenericSetup/registry.py, line 23, in ? from App.class_init import InitializeClass ImportError: cannot import name InitializeClass I can see two solutions: - add a BBB import to import from Globals - from App.class_init import default__class_init__ as InitializeClass Does anyone have preferences? Wichert. -- Wichert Akkerman wich...@wiggy.netIt is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] GenericSetup Zope support
Hi! Wichert Akkerman wrote: Currently GenericSetup trunk no longer runs on Zope 2.10. If I try to run the tests I get this: File /src/Products.GenericSetup/Products/GenericSetup/registry.py, line 23, in ? from App.class_init import InitializeClass ImportError: cannot import name InitializeClass I can see two solutions: - add a BBB import to import from Globals - from App.class_init import default__class_init__ as InitializeClass Does anyone have preferences? Well. The third solution is making the next releases of Zope 2.10 and Zope 2.11 required for GenericSetup 1.5. Importing directly from App.class_init exposed a circular import issue in Zope, see: http://mail.zope.org/pipermail/zope-cmf/2008-December/028003.html I fixed that issue on Zope 2.10 and Zope 2.11 trunk and added InitializeClass as alias for default__class_init__. If you really need to run GenericSetup on older versions I'd prefer your first solution (BBB import from Globals) because it makes sure modules are imported in the right order. Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] GenericSetup Zope support
Previously yuppie wrote: Wichert Akkerman wrote: Currently GenericSetup trunk no longer runs on Zope 2.10. If I try to run the tests I get this: File /src/Products.GenericSetup/Products/GenericSetup/registry.py, line 23, in ? from App.class_init import InitializeClass ImportError: cannot import name InitializeClass I can see two solutions: - add a BBB import to import from Globals - from App.class_init import default__class_init__ as InitializeClass Does anyone have preferences? Well. The third solution is making the next releases of Zope 2.10 and Zope 2.11 required for GenericSetup 1.5. Importing directly from App.class_init exposed a circular import issue in Zope, see: http://mail.zope.org/pipermail/zope-cmf/2008-December/028003.html I fixed that issue on Zope 2.10 and Zope 2.11 trunk and added InitializeClass as alias for default__class_init__. If you really need to run GenericSetup on older versions I'd prefer your first solution (BBB import from Globals) because it makes sure modules are imported in the right order. I see no good reasons not to support existing Zope 2.10 (and older) releases, and it would make it possible to use GenericSetup 1.5 with Plone, which is exactly what I want to do. Wichert. -- Wichert Akkerman wich...@wiggy.netIt is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] GenericSetup Zope support
Wichert Akkerman wrote: Previously yuppie wrote: If you really need to run GenericSetup on older versions I'd prefer your first solution (BBB import from Globals) because it makes sure modules are imported in the right order. I see no good reasons not to support existing Zope 2.10 (and older) releases, and it would make it possible to use GenericSetup 1.5 with Plone, which is exactly what I want to do. In case you are waiting for a go-ahead: I didn't remember the GenericSetup 1.5 release is scheduled before the next Zope 2.10 release. In that case the BBB import from Globals is obviously the right solution. Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] GenericSetup Zope support
Previously yuppie wrote: Wichert Akkerman wrote: Previously yuppie wrote: If you really need to run GenericSetup on older versions I'd prefer your first solution (BBB import from Globals) because it makes sure modules are imported in the right order. I see no good reasons not to support existing Zope 2.10 (and older) releases, and it would make it possible to use GenericSetup 1.5 with Plone, which is exactly what I want to do. In case you are waiting for a go-ahead: I didn't remember the GenericSetup 1.5 release is scheduled before the next Zope 2.10 release. In that case the BBB import from Globals is obviously the right solution. Done. All tests run on both Zope 2.10 and Zope 2.12 now. Wichert. -- Wichert Akkerman wich...@wiggy.netIt is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
