[Zope-CMF] Re: GenericSetup now incompatible with Zope 2.8?
Hi Philipp!
Philipp von Weitershausen wrote:
yuppie wrote:
Should be fixed now: http://svn.zope.org/?rev=68474&view=rev
Simply avoiding the cleanup in Zope 2.8 isn't a proper fix. You should
instead do the following (which works across all Zopes):
from zope.testing.cleanup import CleanUp
CleanUp().cleanUp()
Thanks for keeping an eye on these checkins, but I believe in this case
it is a proper fix. You just can't see it in the diff. There is nothing
to clean up in Zope 2.8. These tests require the traversing setup only
in Zope 2.10 and a separate 'traversing.zcml' does not exist in earlier
Zope/Five versions. I attached the complete code.
Cheers,
Yuppie
class SecurityRequestTest(ZopeTestCase):
def setUp(self):
import Products
from AccessControl.SecurityManagement import newSecurityManager
ZopeTestCase.setUp(self)
try:
# BBB: for Zope 2.9
from Products.Five.traversable import FiveTraversable
except ImportError:
zcml.load_config('meta.zcml', Products.Five)
zcml.load_config('traversing.zcml', Products.Five)
self.root = self.app
newSecurityManager(None,
OmnipotentUser().__of__(self.app.acl_users))
def tearDown(self):
from AccessControl.SecurityManagement import noSecurityManager
noSecurityManager()
ZopeTestCase.tearDown(self)
try:
from zope.testing.cleanup import cleanUp
cleanUp()
except ImportError:
# BBB: for Zope 2.8
pass
___
Zope-CMF maillist - Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf
See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: GenericSetup now incompatible with Zope 2.8?
yuppie wrote: > Jens Vagelpohl wrote: >> This checkin seems to have broken Zope 2.8-compatibility: >> >> http://svn.zope.org/GenericSetup/trunk/tests/common.py?rev=68391&r1=41338&r2=68391 >> >> >> Specifically, the line "from zope.testing.cleanup import cleanUp" >> breaks Zope 2.8, I checked all stable tags (2.8.5, 2.8.6, 2.8.7) and >> there is no toplevel name "cleanUp" in zope.testing.cleanup. >> >> DEPENDENCIES.txt still claims it works with Zope 2.8.5 and higher. One >> or the other needs changing, either DEPENDENCIES.txt needs updating >> or, if this breakage was inadvertently introduced, common.py needs >> fixing. > > Sorry, my mistake. I only tested against Zope 2.9 and 2.10 before > checking in. > > Should be fixed now: http://svn.zope.org/?rev=68474&view=rev Simply avoiding the cleanup in Zope 2.8 isn't a proper fix. You should instead do the following (which works across all Zopes): from zope.testing.cleanup import CleanUp CleanUp().cleanUp() ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: GenericSetup now incompatible with Zope 2.8?
Jens Vagelpohl wrote: This checkin seems to have broken Zope 2.8-compatibility: http://svn.zope.org/GenericSetup/trunk/tests/common.py?rev=68391&r1=41338&r2=68391 Specifically, the line "from zope.testing.cleanup import cleanUp" breaks Zope 2.8, I checked all stable tags (2.8.5, 2.8.6, 2.8.7) and there is no toplevel name "cleanUp" in zope.testing.cleanup. DEPENDENCIES.txt still claims it works with Zope 2.8.5 and higher. One or the other needs changing, either DEPENDENCIES.txt needs updating or, if this breakage was inadvertently introduced, common.py needs fixing. Sorry, my mistake. I only tested against Zope 2.9 and 2.10 before checking in. Should be fixed now: http://svn.zope.org/?rev=68474&view=rev Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: GenericSetup now incompatible with Zope 2.8?
On Sat, 03 Jun 2006 12:16:06 +0100, Jens Vagelpohl <[EMAIL PROTECTED]> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This checkin seems to have broken Zope 2.8-compatibility: http://svn.zope.org/GenericSetup/trunk/tests/common.py? rev=68391&r1=41338&r2=68391 Specifically, the line "from zope.testing.cleanup import cleanUp" breaks Zope 2.8, I checked all stable tags (2.8.5, 2.8.6, 2.8.7) and there is no toplevel name "cleanUp" in zope.testing.cleanup. DEPENDENCIES.txt still claims it works with Zope 2.8.5 and higher. One or the other needs changing, either DEPENDENCIES.txt needs updating or, if this breakage was inadvertently introduced, common.py needs fixing. Since we bill Plone 2.5 as compatible with Zope 2.8, and since 1.6 had a lot to do with Plone 2.5 and GenericSetup, this seem a bit strange, not to mention unfortunate from a Plone perspective. I understand it's only in the tests, but if we can't run the tests on 2.8, we can't know whether it works there! :) Martin -- "You can just adapt yourself out of it..." // Archipelago sprint 26/04/2006 ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
