Re: [Zope-CMF] CMFActionIcons moved to github

[Charlie Clark]

Am .09.2015, 00:19 Uhr, schrieb Maurits van Rees  
:


Not in active development anymore, as the code was moved into other  
parts of CMF years ago, but it made sense to me to move this one over  
too.


Not to me, it doesn't. There should be no more work on this particular  
library.


Charlie
--
Charlie Clark
Managing Director
Clark Consulting & Research
German Office
Kronenstr. 27a
Düsseldorf
D- 40217
Tel: +49-211-600-3657
Mobile: +49-178-782-6226
___
Zope-CMF maillist  -  Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Re: [Zope-CMF] CMFActionIcons moved to github

[Johannes Raggam]

I wonder why Plone still depends on it, if the code was moved to other
CMF packages...?

On Fri, 2015-09-11 at 10:37 +0200, Charlie Clark wrote:
> Am .09.2015, 00:19 Uhr, schrieb Maurits van Rees  
> :
> 
> > Not in active development anymore, as the code was moved into other
> >   
> > parts of CMF years ago, but it made sense to me to move this one
> > over  
> > too.
> 
> Not to me, it doesn't. There should be no more work on this
> particular  
> library.
> 
> Charlie

signature.asc
Description: This is a digitally signed message part
___
Zope-CMF maillist  -  Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

[Zope-CMF] Successful - CMF-trunk_Zope-trunk - Build # 861

[Jenkins]

CMF-trunk_Zope-trunk - Build # 861 - Successful:

Check console output at 
https://jenkins.starzel.de/job/CMF-trunk_Zope-trunk/861/ to view the results.___
Zope-CMF maillist  -  Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

[Tres Seaver]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 09/10/2015 11:43 PM, Maurits van Rees wrote:

> I thought I would add a link to my branch on Launchpad, but apparently
>  only the master and 1.6 branches are synced, so mine is not visible: 
> https://code.launchpad.net/zope-genericsetup

The mirroring bits aren't (yet) automated in Launchpad's Git integration.
 I just updated manually via:

> $ git remote -v launchpad
> git+ssh://git.launchpad.net/zope-genericsetup (fetch) launchpad
> git+ssh://git.launchpad.net/zope-genericsetup (push) origin
> g...@github.com:zopefoundation/Products.GenericSetup (fetch) origin
> g...@github.com:zopefoundation/Products.GenericSetup (push) $ git fetch
> origin remote: Counting objects: 61, done. remote: Compressing
> objects: 100% (31/31), done. remote: Total 61 (delta 34), reused 22
> (delta 22), pack-reused 8 Unpacking objects: 100% (61/61), done. From
> github.com:zopefoundation/Products.GenericSetup * [new branch]
> maurits-apply-dependency-only-once ->
> origin/maurits-apply-dependency-only-once $ git checkout
> maurits-apply-dependency-only-once Branch
> maurits-apply-dependency-only-once set up to track remote branch
> maurits-apply-dependency-only-once from origin. Switched to a new
> branch 'maurits-apply-dependency-only-once' $ git push --all launchpad
>  Total 0 (delta 0), reused 0 (delta 0) To
> git+ssh://git.launchpad.net/zope-genericsetup * [new branch]
> maurits-apply-dependency-only-once ->
> maurits-apply-dependency-only-once



Tres.
- -- 
===
Tres Seaver  +1 540-429-0999  tsea...@palladion.com
Palladion Software   "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJV8uiCAAoJEPKpaDSJE9HY04QP/jcMG0C8LUVl1f1M0UpGoFMJ
VhZeWMmvLQteaJQw5vXahnmFrn1UaqjIyKkoZcpPoi00vUXcR3cvKgWsJ0Q7AmW+
7dAn0Zt9CSjHNGOOos4ke6+JHKGP2ITL+pJiRSASQz70sCsF1WPU4xK7K2tNFnQd
7AYndav7t3z0YQnywMmwa3eb7h8fbcF7qydU5zqeylaxFwtG+rbnej2h4FSR1tON
/S9UXxlJ64vkJRkS54Hh6ra2fX3PCwMo6lX3dHxS3E9qEMT3AGvihEq43icg8tMP
7xhc7ansg1frlt698l/m+OiVyVP66OHuniN4XwBPuGHV0O0njlY0VRAGw/XpDw8h
cSxkXK135qmPkREzm0fo0cWI0Aswa5r8N11p84cETDuPY16MjaGDvRnGjkd65sJg
3c0B/0YxNRqssf7pil2FTQKVXf/Q8w0bBn+3lcBcyV2IdCiCey+Cb70Wv/Mh9NkZ
PpTp+iEiQIStWfLod/8jFloUBbtEBqH4lEWm+QGBiJ+IvbfH1sQAO+1/5yk5Hh4I
9wSnGAmR6+GBT00xGeDOtucHUb39azkrNTUKEgsO3akayFunKnGq07mm7QVpjm+n
bzg4vtufbi0atpMQRIfQtA720TjmVfWSFkXWAnUqt0t76nMfdaqSdZ9kXbKs0nGK
dC4QlOeTt7ZXHTpvednr
=RH2J
-END PGP SIGNATURE-

___
Zope-CMF maillist  -  Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

[Maurits van Rees]

Hi yuppie,

Op 11-09-15 om 09:00 schreef yuppie:

The Import tab wasn't built with extension profiles and upgrade steps in
mind. It is not exactly the UI you expect for installing add-ons.

One issue you want to fix is this:

Someone installs an add-on on a site that has outdated configuration.
Because nobody warns him, he messes up the configuration of his site.

Your answer is: Don't bother him with this detail, I'm sure he wanted to
upgrade his dependencies first. I'll do that for him silently.

My answer is: His site is in a bad state if he didn't run the upgrades.
He should fix that before he starts installing add-ons.


Someone has a site with profile hoopyfrood up to date.  He has no idea 
what this does, it was just applied as a dependency of another add-on.


He adds an addon with profile towel to the buildout config.  This 
requires a new version of the package that has profile hoopyfrood. 
Fine, he updates the version pins,  runs buildout and restarts the site.


He installs the towel add-on.

Old answer: no matter what the state of the hoopyfrood profile, we apply 
it.  This may be mostly harmless (I swear I did not plan this culture 
reference), but it does more than necessary and may be harmful in some 
cases.


My answer: apply the upgrade step of hoopyfrood.  Everybody happy.

Your answer: give an error, pointing to the Upgrades tab, telling him to 
run the upgrades of hoopyfrood first?  Then nothing happens.


Your answer may be fine when applying a profile in the ZMI, but then 
again, I have updated the pull request to give the user more options in 
the ZMI so that may be fine already.  So maybe you are happy with that 
already.


From the point of view of existing code in add-ons that call 
runAllImportStepsFromProfile and expect it to maybe do too much but at 
least work, your answer would be a regression: either nothing is done or 
you get an exception.


BTW, the add-ons control panel in Plone 5 lists the available upgrades 
first, and then the installable new add-ons.  We could improve the ZMI 
similarly, like:

- add a warning at the top of the Imports tab if there are upgrades
- Show on the Upgrades tab which profiles actually have upgrades that 
need to be applied. Now I sometimes click through the entire list to 
check this.

Maybe something for another pull request.

But, for me, this is not about how it works in the ZMI.  I am sure with 
some back and forth like this we can work something out.  It is mostly 
about: what happens when in code you do runAllImportStepsFromProfile 
with the default settings.


BTW 2, Plone 5 is still also using CMFQuickInstaller, but that is going 
the way of the dodo.  Slowly.



In other words: 'profile-' is the default prefix. All methods handle ids
without prefix the same way as ids with the default prefix. Correct?


Yes, exactly.

Thanks for the feedback,

--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

___
Zope-CMF maillist  -  Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Re: [Zope-CMF] CMFActionIcons moved to github

[Maurits van Rees]

Op 11-09-15 om 13:55 schreef Charlie Clark:

Am .09.2015, 13:02 Uhr, schrieb Johannes Raggam :


I wonder why Plone still depends on it, if the code was moved to other
CMF packages...?


I think Plone still hasn't switched to the version of CMF which has the
integration. I don't know the details but I think there are things that
are done directly in Plone. It's a pity because CMF 2.1 and 2.2 contain
a lot of improvements including a browser-view only skin.


Yes, Plone has switched over a long time ago.  Plone 4.0 and higher, 
including Plone 5, have CMF 2.2.  (Not 2.3, for compatibility reasons 
that I don't know.)


But CMFActionIcons 2.1.3 is still shipped in Plone 4 for backwards 
compatibility reasons, so you don't get broken objects in the ZMI.


I noticed some links to svn.zope.org in the sources.cfg in the Plone 
coredev buildout for 4.3, and I wanted to get rid of it.  This is part 
of that.


--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

___
Zope-CMF maillist  -  Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests