Re: [Zope-dev] Re: Zope 2.4 crashes -- possible fix identified, other solutions also suggested
Well, if you want to grab what is probably going to turn in to Python 2.1.2 from CVS, you can get the release21-maint branch from :pserver:[EMAIL PROTECTED]:/cvsroot/python package python. This already has the important change to ceval.c in it; but I'm not sure that the rest of the changes for the 2.1.2 release have been finalized. I think Anthony Baxter is going to try to put a beta / release candidate of 2.1.2 up real soon now, but I can't speak for him :) On Wednesday, December 19, 2001, at 10:39 PM, Joseph Wayne Norton wrote: Matt - If possible, I would prefer to use a source Python 2.1.2 release with a source zope 2.4.4 ? bugfix release (or create my own from the 2.4 cvs branch) once the fixes are complete. We do not want to put a 2.5 release in production at this time. Thanks for the update. regards, - j At Wed, 19 Dec 2001 09:25:08 -0500, Matthew T. Kromer wrote: The ExtensionClass.h patch has NOT been merged into the branches and trunk yet pending further review. just my 2 cents, but we have been using this in production for about 1 week or more without any troubles. ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] disabling gc does not necessarily hide memorycorruption
Well the ExtensionClass.h fix I think is completely harmless (assuming you recompile every ExtensionClass based C module) but I'm not convinced it's necessary, either. It's more of an insurance policy -- if every C module plays by the rules and checks the type flags field of the type object first, then the ExtensionClass.h file fix isn't necessary. Of course, anytime someone says well if every... I get suspicious. Those people who have reported that it helps their system stability are probably benefiting because stack stomps (from the two known stack-clobbering bugs in Python 2.1) end up leaving pointers to extensionclass objects in places they don't belong (ie places which have already CHECKED the flags, and thus don't check them again). Those C modules then use a NULL pointer check, which properly halts chasing of chains with the ExtensionClass.h patch, where it would have led to another wild pointer without. Its the same reason disabling GC also helps some people; it reduces the activities that follow bad pointers. Actually, I was kind of hoping Martijn Faassen would pipe up and say I applied the restricted python patches you've already put up on the Zope-2_4-branch, and my problems with ParsedXML went away! since he's one of the folks that did NOT benefit from applying the ExtensionClass.h patch. On Wednesday, December 19, 2001, at 03:44 PM, Chris McDonough wrote: I'm not sure the ExtensionClass fix is baked yet, and there's not yet an overwhelming consensus that it helps stability, not to mention that I'm not sure how to install it, so no. ;-) I think you can use the trunk, no branch required. Hopefully the fixes will be merged soon. - Original Message - From: Leonardo Rochael Almeida [EMAIL PROTECTED] To: Zope Developers list [EMAIL PROTECTED] Sent: Wednesday, December 19, 2001 3:22 PM Subject: Re: [Zope-dev] disabling gc does not necessarily hide memorycorruption Oh, and which branch should I get the tarball from? On Wed, 2001-12-19 at 18:20, Leonardo Rochael Almeida wrote: On Wed, 2001-12-19 at 18:02, Martijn Pieters wrote: [...] You can download files from CVS as a tarball. Just go to http://cvs.zope.org/Zope/lib/python/RestrictedPython and use the link at the bottom. Should I apply the ExtensionClass.h fix from CVS mentioned here in the list too? -- Ideas don't stay in some minds very long because they don't like solitary confinement. -- Ideas don't stay in some minds very long because they don't like solitary confinement. ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope ) ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope ) ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] disabling gc does not necessarily hide memorycorruption
Matthew T. Kromer wrote: [snip] Actually, I was kind of hoping Martijn Faassen would pipe up and say I applied the restricted python patches you've already put up on the Zope-2_4-branch, and my problems with ParsedXML went away! since he's one of the folks that did NOT benefit from applying the ExtensionClass.h patch. Here I'm piping up, finally; I didn't catch this thread until before. I found a pyassem.py 6 days old in the trunk, so I'm putting that into a Zope2.5.0b2 now.. restarting Zope.. Nope. Would be odd if it had, as this code shouldn't be exercising restricted Python at all anyway (it's just a Python product in the filesystem). Setting ZOPE_SECURITY_POLICY to PYTHON makes the problem go away, so I suspect the problem is still with cAccessControl.. (or in ParsedXML, but the code isn't complicated securitywise as far as I am aware, and doesn't crash when I run it in plain python) Regards, Martijn ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Zope 2.4 crashes -- possible fix identified, other solutions also suggested
Leonardo Rochael Almeida wrote: On Tue, 2001-12-18 at 13:44, Matthew T. Kromer wrote: Soo... if shutting off GC extends time between crashes for some folks from every 15 minutes to 3 times a day, my advise is to shut off GC. Now I can really confirm that gc.disable() is enough to avoid the crashes (no need to recompile python --without-gc). I changed the z2.py to include this, but just as a data point to Matt, ParsedXML is still crashing. ;) Regards, Martijn ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Zope 2.4 crashes -- possible fix identified, other solutions also suggested
Matthew T. Kromer wrote Anthony Baxter is anticipating a Python 2.1.2 beta real soon now (probably this weekend) so I am going to try to get that into Zope 2.5's binary releases, although we may put out a Zope 2.5 beta 3 first. This will include the necessary Python patches to ceval.c to fix the frame bug; after it hits the streets Python 2.1.2 will become our recommended Python for Zope. That's still the plan - ripping along through the todo list at the moment. I'm just double-quadruple-triple checking the safety of the patch to make solaris threading not suck as a backport. Note that it's not going to be a beta, but a release candidate - it shouldn't be necessary to have a beta for a bugfix release. Anthony -- Anthony Baxter [EMAIL PROTECTED] It's never too late to have a happy childhood. ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Zope 2.4 crashes -- possible fix identified, other solutions also suggested
Matthew T. Kromer wrote Well, if you want to grab what is probably going to turn in to Python 2.1.2 from CVS, you can get the release21-maint branch from :pserver:[EMAIL PROTECTED]:/cvsroot/python package python. I'd _love_ it if people wanted to do this, once the release candidate is out - I don't have access to a massive number of platforms, so I'd like to know if I've accidentally broken anything. :) Watch this space... -- Anthony Baxter [EMAIL PROTECTED] It's never too late to have a happy childhood. ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
