Re: [Zope-dev] zope-tests - FAILED: 5, OK: 19
Op 16-01-13 18:47, Tres Seaver schreef: [3]FAILED winbot / z3c.ptcompat_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-January/071440.html Same error related to the recent zope.pagetemplates changes. This is a test that passes with standard zope.pagetemplates, but fails in combination with Chameleon. It is in a recursion test that has been added in zope.pagetemplate 4.0.0. I have now added a bin/testcompat script in the zope.pagetemplates buildout to test with z3c.pt(compat) plus Chameleon. The expected output for this test is: !-- See https://bugs.launchpad.net/zope.pagetemplate/+bug/732972 -- ul liroot/li li ul lifirst/li /ul /li li ul lisecond/li /ul /li /ul The real output is: !-- See https://bugs.launchpad.net/zope.pagetemplate/+bug/732972 -- ul liroot/li li ul lifirst/li /ul /li li ul lisecond/li /ul /li /ul The difference is that the two inner '/ul' get an extra line before them with a single space character. I have tried a few changes in the test template to see if that would result in the output html being the same with and without Chameleon, but that did not work. Possibly this needs a change not in zope.pagetemplate but in Chameleon or one of the other packages. -- Maurits van Rees: http://maurits.vanrees.org/ Zest Software: http://zestsoftware.nl ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope-tests - FAILED: 5, OK: 19
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/18/2013 08:58 AM, Maurits van Rees wrote: Op 16-01-13 18:47, Tres Seaver schreef: [3]FAILED winbot / z3c.ptcompat_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-January/071440.html Same error related to the recent zope.pagetemplates changes. This is a test that passes with standard zope.pagetemplates, but fails in combination with Chameleon. It is in a recursion test that has been added in zope.pagetemplate 4.0.0. I have now added a bin/testcompat script in the zope.pagetemplates buildout to test with z3c.pt(compat) plus Chameleon. The expected output for this test is: !-- See https://bugs.launchpad.net/zope.pagetemplate/+bug/732972 -- ul liroot/li li ul lifirst/li /ul /li li ul lisecond/li /ul /li /ul The real output is: !-- See https://bugs.launchpad.net/zope.pagetemplate/+bug/732972 -- ul liroot/li li ul lifirst/li /ul /li li ul lisecond/li /ul /li /ul The difference is that the two inner '/ul' get an extra line before them with a single space character. I have tried a few changes in the test template to see if that would result in the output html being the same with and without Chameleon, but that did not work. Possibly this needs a change not in zope.pagetemplate but in Chameleon or one of the other packages. Or use ElementTree to normalize the XHTML before testing (since the whitespace diffreences are semantically irrelevant). Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iEYEARECAAYFAlD5abkACgkQ+gerLs4ltQ4qIACgnPul4E9ztNS5Y3bhXiQRGIa4 fFYAn170Y1Z6b0fe7MQkZKSWfh9ABs/4 =Xn2k -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope-tests - FAILED: 5, OK: 19
Op 18-01-13 16:26, Tres Seaver schreef:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01/18/2013 08:58 AM, Maurits van Rees wrote:
Op 16-01-13 18:47, Tres Seaver schreef:
[3]FAILED winbot / z3c.ptcompat_py_265_32
https://mail.zope.org/pipermail/zope-tests/2013-January/071440.html
Same error related to the recent zope.pagetemplates changes.
This is a test that passes with standard zope.pagetemplates, but fails
in combination with Chameleon. It is in a recursion test that has
been added in zope.pagetemplate 4.0.0.
I have now added a bin/testcompat script in the zope.pagetemplates
buildout to test with z3c.pt(compat) plus Chameleon.
The expected output for this test is:
!-- See https://bugs.launchpad.net/zope.pagetemplate/+bug/732972 --
ul liroot/li li ul lifirst/li /ul /li li ul
lisecond/li /ul /li /ul
The real output is:
!-- See https://bugs.launchpad.net/zope.pagetemplate/+bug/732972 --
ul liroot/li li ul lifirst/li
/ul /li li ul lisecond/li
/ul /li /ul
The difference is that the two inner '/ul' get an extra line before
them with a single space character.
I have tried a few changes in the test template to see if that would
result in the output html being the same with and without Chameleon,
but that did not work.
Possibly this needs a change not in zope.pagetemplate but in Chameleon
or one of the other packages.
Or use ElementTree to normalize the XHTML before testing (since the
whitespace diffreences are semantically irrelevant).
I did it in a crude way in zope.pagetemplate:
+# crude way of normalizing whitespace
+expect = expect.replace(' ', '').replace('\n\n', '\n')
+out = out.replace(' ', '').replace('\n\n', '\n')
util.check_html(expect, out)
That works.
For the buildbot test to pass, a zope.pagetemplate 4.0.1 release would
need to be made.
--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl
___
Zope-Dev maillist - Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] zope-tests - FAILED: 2, OK: 21
This is the summary for test reports received on the zope-tests list between 2013-01-17 00:00:00 UTC and 2013-01-18 00:00:00 UTC: See the footnotes for test reports of unsuccessful builds. An up-to date view of the builders is also available in our buildbot documentation: http://docs.zope.org/zopetoolkit/process/buildbots.html#the-nightly-builds Reports received Fixed - zopetoolkit_trunk - Build # 144 Fixed - zopetoolkit_trunk_app - Build # 127 Zope-2.10 Python-2.4.6 : Linux Zope-2.11 Python-2.4.6 : Linux Zope-2.12 Python-2.6.8 : Linux Zope-2.13 Python-2.6.8 : Linux Zope-2.13 Python-2.7.3 : Linux Zope-trunk Python-2.6.8 : Linux Zope-trunk Python-2.7.3 : Linux winbot / ZODB_dev py_265_win32 winbot / ZODB_dev py_265_win64 winbot / ZODB_dev py_270_win32 winbot / ZODB_dev py_270_win64 [1]winbot / z3c.ptcompat_py_265_32 [2]winbot / z3c.recipe.paster_py_265_32 winbot / ztk_10 py_254_win32 winbot / ztk_10 py_265_win32 winbot / ztk_10 py_265_win64 winbot / ztk_11 py_254_win32 winbot / ztk_11 py_265_win32 winbot / ztk_11 py_265_win64 winbot / ztk_11 py_270_win32 winbot / ztk_11 py_270_win64 Non-OK results -- [1]FAILED winbot / z3c.ptcompat_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-January/071510.html [2]FAILED winbot / z3c.recipe.paster_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-January/071532.html ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
