Re: [Zope-dev] Deprecated code in zope.location
Hello, * 2009-08-21 21:15, Dan Korostelev wrote: What about removing the use of zope.deferredimport from zope.location and make a new major release of zope.location? +1, just change that to plain imports with # BBB comments. Would it also be possible to remove the dependency of zope.location on zope.copy? It is only needed to register an adapter for ICopyHook, which can be made optional in the ZCML. To me it looks a wise choice, because zope.location is well usable without zope.copy, and if somebody needs the hook it is because he will be using zope.copy, so he must depend on it. I prepared these changes in a branch, can somebody review them? svn://svn.zope.org/repos/main/zope.location/branches/optional-zope.copy Thanks, Fabio ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Deprecated code in zope.location
2009/8/23 Fabio Tranchitella kob...@kobold.it: * 2009-08-21 21:15, Dan Korostelev wrote: What about removing the use of zope.deferredimport from zope.location and make a new major release of zope.location? +1, just change that to plain imports with # BBB comments. Would it also be possible to remove the dependency of zope.location on zope.copy? It is only needed to register an adapter for ICopyHook, which can be made optional in the ZCML. To me it looks a wise choice, because zope.location is well usable without zope.copy, and if somebody needs the hook it is because he will be using zope.copy, so he must depend on it. I prepared these changes in a branch, can somebody review them? It seems somewhat strange to have a module that imports from a package that is not in dependencies. Also, zope.copy is a very tiny module with no dependencies beyond zope.interface and no C code, so I don't see any problem with having it in dependencies. However, any option is fine with me, so +0 :-) BTW probably it's better to isolate the copy hook adapter in a submodule with more sane name, like copyhook and deprecate the pickling module, so people could understand those things easier. :-) -- WBR, Dan Korostelev ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Deprecated code in zope.location
Hello, we deprecated locationCopy and CopyPersistent from zope.locaton.pickling with the 3.5.3 release (which should have been a new major release, by the way). This introduced a new dependency on zope.deferredimport, but I just realized that according to the decisions taken by the streering group, the right way to deprecate code is to *not* use zope.deferredimport: http://docs.zope.org/zopetoolkit/steeringgroup/decisions.html I thus propose to stop using zope.deferredimport in core ZTK packages, as stated in the page I mentioned above, unless a new decision is made by who is in charge of making decisions. What about removing the use of zope.deferredimport from zope.location and make a new major release of zope.location? Thanks, Fabio ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Deprecated code in zope.location
2009/8/21 Fabio Tranchitella kob...@kobold.it: we deprecated locationCopy and CopyPersistent from zope.locaton.pickling with the 3.5.3 release (which should have been a new major release, by the way). Sorry, that was my bad, I didn't care much about versioning when I was making those refactorings with zope.copy. This introduced a new dependency on zope.deferredimport, but I just realized that according to the decisions taken by the streering group, the right way to deprecate code is to *not* use zope.deferredimport: Well, IIRC that change was released before the decision about deprecation warnings was finally taken, so it should be fixed now. What about removing the use of zope.deferredimport from zope.location and make a new major release of zope.location? +1, just change that to plain imports with # BBB comments. -- WBR, Dan Korostelev ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
