[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/add-archive-module into lp:zorba has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 -- https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba
This query doesn't work because the serializer of the query result throws an
error. The result of a query must not be an attribute. fn:trace does work on my
side:
./bin/zorba -q 'trace(attribute { a } { 1 }, a)'
a [1]: a=1 == fn:trace print
?xml version=1.0 encoding=UTF-8?
serialization error [err:SENR0001]: 1: can not serialize attribute node;
raised at /home/dagraf/zorba/sandbox/src/api/serialization/serializer.cpp:456
You need to execute something like: ./bin/zorba -q 'data(trace(attribute { a
} { 1 }, a))'
... to not see an error.
--
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/add-archive-module into lp:zorba has been updated. Status: Rejected = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 -- https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/add-archive-module-2012-08-15T07-45-11.735Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba
Validation queue job add-archive-module-2012-08-15T07-45-11.735Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/add-archive-module into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 -- https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/expr-memman2 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/119523 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expr-memman2 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/expr-memman2 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/119523 -- https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/119523 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expr-memman2 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/expr-memman2-2012-08-15T09-57-04.577Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/119523 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/expr-memman2 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/expr-memman2 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job expr-memman2-2012-08-15T09-57-04.577Z is finished. The final status was: 2 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/119523 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expr-memman2 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/expr-memman2 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/119523 -- https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/119523 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-library-functions-2012-08-15T14-11-15.358Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba
Validation queue job jsoniq-library-functions-2012-08-15T14-11-15.358Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba.
Requested reviews:
Paul J. Lucas (paul-lucas)
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/119730
Miscellaneous changes, some a prerequisite for LLVM that should be done anyway
and not have to wait for the far-in-the-future LLVM branch merge.
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/119730
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'include/zorba/internal/unique_ptr.h'
--- include/zorba/internal/unique_ptr.h 2012-08-14 11:13:50 +
+++ include/zorba/internal/unique_ptr.h 2012-08-15 15:14:25 +
@@ -26,6 +26,7 @@
#include algorithm/* for swap() */
#include type_traits.h
+#include ztd.h
namespace std {
@@ -205,9 +206,7 @@
typedef typename ZORBA_TR1_NS::add_referenceD const::type
deleter_const_reference;
- // see http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2333.html
- struct pointer_conversion { int valid; };
- typedef int pointer_conversion::*explicit_bool;
+ typedef zorba::internal::ztd::explicit_bool explicit_bool;
public:
typedef T element_type;
@@ -408,8 +407,8 @@
* @return Returns \c true only if the pointer is not null; \c false only if
* the pointer is null.
*/
- operator explicit_bool() const throw() {
-return get() ? pointer_conversion::valid : 0;
+ operator explicit_bool::type() const throw() {
+return explicit_bool::value_of( get() );
}
private:
=== modified file 'include/zorba/internal/ztd.h'
--- include/zorba/internal/ztd.h 2012-08-14 11:13:50 +
+++ include/zorba/internal/ztd.h 2012-08-15 15:14:25 +
@@ -370,6 +370,56 @@
return s ? s : null;
}
+// misc ///
+
+/**
+ * Helper class for implementing a solution to the explicit bool conversion
+ * problem. The canonical use is of the form:
+ * \code
+ * class your_class {
+ *// ...
+ *operator explicit_bool::type() const {
+ * return explicit_bool::value_of( some_expression );
+ *}
+ * };
+ * \endcode
+ *
+ * See: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2333.html
+ */
+class explicit_bool {
+ struct pointer_conversion { int valid; };
+public:
+ typedef int pointer_conversion::*type;
+
+ /**
+ * Gets the explicit \c bool value for \c false.
+ *
+ * @return Returns said value.
+ */
+ static type false_value() {
+return 0;
+ }
+
+ /**
+ * Gets the explicit \c bool value for \c true.
+ *
+ * @return Returns said value.
+ */
+ static type true_value() {
+return pointer_conversion::valid;
+ }
+
+ /**
+ * Converts the the built-in \c bool value to an explicit \c bool value.
+ *
+ * @param value The \c bool value to convert.
+ * @return Return said value.
+ */
+ static type value_of( bool value ) {
+return value ? true_value() : false_value();
+ }
+};
+
///
} // namespace ztd
=== modified file 'src/util/stl_util.h'
--- src/util/stl_util.h 2012-08-14 11:13:50 +
+++ src/util/stl_util.h 2012-08-15 15:14:25 +
@@ -155,11 +155,13 @@
///
/**
- * A less-verbose way to determine whether the given setT contains a
+ * A less-verbose way to determine whether the given map or set contains a
* particular element.
*/
-templatetypename T inline
-bool contains( std::setT const s, typename call_traitsT::arg_type v ) {
+templateclass ContainerType inline
+bool contains(
+ContainerType const s,
+typename call_traitstypename ContainerType::key_type::arg_type v ) {
return s.find( v ) != s.end();
}
@@ -200,8 +202,32 @@
}
/**
- * Erases the first element in the given sequence for which the given predicate
- * is \c true.
+ * Erases all elements in the given container for which the given predicate is
+ * \c true.
+ *
+ * @tparam SequenceType The sequence type.
+ * @tparam PredicateType The predicate type.
+ * @param seq The sequence to modify.
+ * @param pred The predicate to use.
+ * @return Returns the number of elements erased.
+ */
+templateclass SequenceType,class PredicateType inline
+typename SequenceType::size_type erase_if( SequenceType seq,
+ PredicateType pred ) {
+ typename SequenceType::size_type erased = 0;
+ for ( typename SequenceType::iterator i = seq.begin(); i != seq.end(); ) {
+if ( pred( *i ) ) {
+ i = seq.erase( i );
+ ++erased;
+} else
+ ++i;
+ }
+ return erased;
+}
+
+/**
+ * Erases only the first element in the given sequence for which the given
+ * predicate is \c true.
*
* @tparam SequenceType The sequence type.
* @tparam PredicateType The predicate type.
=== modified file 'src/zorbaserialization/serialize_zorba_types.cpp'
---
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba
My only concern is that for non-Apple, non-Windows platforms, you add -luuid to the link line, but there's no CMake stuff to search for a uuid library or to ensure that such an option will compile/link successfully. Is it a guarantee that it will always be available, at least on Linux? Good catch. I don't suppose you could add the relevant CMake stuff to find libuuid? -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/119730 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba
Review: Approve Of course! I'm sorry about the confusion. -- https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba
The proposal to merge lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 -- https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fn_trace_jsoniq_fix-2012-08-15T15-41-05.154Z/log.html -- https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba
Validation queue job fn_trace_jsoniq_fix-2012-08-15T15-41-05.154Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba
The proposal to merge lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 -- https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba
Good catch. I don't suppose you could add the relevant CMake stuff to find libuuid? 1. Are the things you compile/link against on Windows and Mac guaranteed to exist? (ie, do I only need to find libuuid on Linux platforms) 2. What should happen if I *don't* find it? Can the UUID code be made optional at compile time? Would that mean we need a ZORBA_WITH_UUID or something like that? Or, do we have a hard requirement on libuuid and the build should fail without it? It does appear that on Ubuntu, at least, libuuid comes from the package libuuid1, which is part of the minimal Task and is depended on by some pretty low-level packages such as util-linux and e2fsprogs. It's not clear to me whether it's at all possible to have a functional Linux/Ubuntu system without libuuid existing. So maybe it's OK to assume it will always be there. -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba
1. Are the things you compile/link against on Windows and Mac guaranteed to exist? (ie, do I only need to find libuuid on Linux platforms) Yes. 2. What should happen if I *don't* find it? Can the UUID code be made optional at compile time? Would that mean we need a ZORBA_WITH_UUID or something like that? Or, do we have a hard requirement on libuuid and the build should fail without it? I think it has to be the latter, but Matthias might know. -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1010746 into lp:zorba/image-module
Review: Approve Beautiful change. I'll vote Approve based on a reading of the code, but I can't actually test it; hopefully Juan can verify that an appropriate pretty error is thrown on a machine without ImageMagick installer. -- https://code.launchpad.net/~zorba-coders/zorba/bug1010746/+merge/118209 Your team Zorba Coders is subscribed to branch lp:zorba/image-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
