Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job jsoniq-roundtrip-2012-09-21T05-41-03.33Z is finished. The final status was: 2 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T07-06-03.989Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue job jsoniq-roundtrip-2012-09-21T07-06-03.989Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Needs Fixing, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1044260 into lp:zorba
Review: Needs Fixing I think more error codes must be listed in the catch clause in apply_updates.cpp. For example, XUDY0024, and a bunch of ZDDY codes related to collections and indexes (search for XUDY and ZDDY in src/store and see which of these errors are thrown during PUL apply). -- https://code.launchpad.net/~zorba-coders/zorba/bug-1044260/+merge/125297 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Review: Approve Approve the serialization changes. I skimmed the relevant tests as well. I didn't dive deeply into the implementation of the roundtrip functions. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqdoc-extensions into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/xqdoc-extensions into lp:zorba has been updated. Commit Message changed to: - xqdoc generation for collection declarations - xqdoc generation for index declarations (inclusive sources) - possibility to disable xqdoc generation for certain components For more details, see: https://code.launchpad.net/~zorba-coders/zorba/xqdoc-extensions/+merge/125662 -- https://code.launchpad.net/~zorba-coders/zorba/xqdoc-extensions/+merge/125662 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqdoc-extensions into lp:zorba
Documentation improvements are welcomed :-) -- https://code.launchpad.net/~zorba-coders/zorba/xqdoc-extensions/+merge/125662 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fread-pdf-trunk into lp:zorba
It doesn't look like the fpdf.* files were added via bzr add -- were they supposed to be? -- https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fread-pdf-trunk into lp:zorba
Paul, If you're asking about my last commit msg, it is as it should be just one line change, by deleting the tag name, it makes trunk use the latest HEAD version of the module branch. The files in util-jvm were already reviewed and merged see this merge: https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-utiljvm-module/+merge/125332 . The changes in file: modules/ExternalModules.conf' 117 --- modules/ExternalModules.conf 2012-09-17 00:36:37 + 118 +++ modules/ExternalModules.conf 2012-09-21 15:25:26 + 119 @@ -39,11 +39,12 @@ 123 +read-pdf bzr lp:zorba/read-pdf-module 128 -util-jvm bzr lp:zorba/util-jvm-module zorba-2.6 129 +util-jvm bzr lp:zorba/util-jvm-module -- https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Review: Needs Fixing
- JNTY0023 doesn't exist in the spec
- jn:decode-from-roundtrip should return item()*, e.g. it could also return
atomics
- Probably not related to this proposal but it's strange that the following
example doesn't raise a sequence-type matching error (in this branch)
jn:decode-from-roundtrip({ Q{http://jsoniq.org/roundtrip}type; :
xs:dateTime, Q{http://jsoniq.org/roundtrip}value; :
2012-09-21T09:44:14.753-07:00 }) instance of xs:dateTime
- jn:encode-for-roundtrip should accept item()*
- the exception raised in JSONEncodeForRoundtripIterator::encodeNode doesn't
have a query location. It could have one by directly raising an XQueryException
or catching and rethrowing it in nextImpl with the location added.
- ChangeLog entry missing
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fread-pdf-trunk into lp:zorba
Review: Needs Fixing The module works pretty decent. I was able to extract text or generate images for several pdfs without any problems. There are some minor things that should be discussed and/or fixed: - the error seems to be too general, essentially it always raises JAVA-EXCEPTION no matter what goes wrong (e.g. it the given input is not a valid pdf) - the java stack trace seems to be sent to standard error - Renders the each page of the PDF document as an image. = Renders each page of the PDF document as an image. - the names of the private functions should also adhere to the code conventions renderToImages = render-to-images - make xqdoc failes because the comments seem to contain invalid xml /home/mbrantner/zorba/build/URI_PATH/com/zorba-xquery/www/modules/project_xqdoc.xq:142,9: user-defined error [err:UE004]: Error processing module zerr:ZXQD0002 - This module provides funtionality to read the text from PDF documents and to render PDF documents to images. a href=http://pdfbox.apache.org;Apache PDFBox/a library is used to implement these functions. br / br / bNote:/b Since this module has a Java library dependency a JVM required to be installed on the system. For Windows: jvm.dll is required on the system path ( usually located in C:\Program Files\Java\jre6\bin\client. bNote:b For Debian based Linux distributions install PdfBox and FontBox packages: sudo apt-get install libpdfbox-java libfontbox-java : can not parse as XML for xqdoc: loader parsing error: Opening and ending tag mismatch: b line 0 and root ; raised at /home/mbrantner/zorba/sandbox/src/runtime/errors_and_diagnostics/errors_and_diagnostics_impl.cpp:81 - adapt the year in Copyright 2006-2009 The FLWOR Foundation. in the .xq file (and some other files also) - would it make sense to return one string per page in the pdf instead of one big string? - remove commented out code in read-pdf.cpp - valgrind shows tons of invalid writes. Why? Are they critical? Is there anything we can do? - would it make sense to return the images in a streaming fashion (i.e. don't create all base64's in a vector)? - encoding each image shouldn't be necessary and will probably we wasted effort because the images might be written to a file in their binary form -- https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
- JNTY0023 doesn't exist in the spec
I've sent an e-mail to the list to add it to the spec.
- jn:decode-from-roundtrip should return item()*, e.g. it could also return
atomics
- Probably not related to this proposal but it's strange that the following
example doesn't raise a sequence-type matching error (in this branch)
jn:decode-from-roundtrip({ Q{http://jsoniq.org/roundtrip}type; :
xs:dateTime, Q{http://jsoniq.org/roundtrip}value; :
2012-09-21T09:44:14.753-07:00 }) instance of xs:dateTime
- jn:encode-for-roundtrip should accept item()*
Thinking more about this both functions should probably accept and return
item()* as simple atomic values 5 should just go through untouched.
I've changed the signature to item()* for now and sent an e-mail to the list
for clarification.
- the exception raised in JSONEncodeForRoundtripIterator::encodeNode doesn't
have a query location. It could have one by directly raising an
XQueryException or catching and rethrowing it in nextImpl with the location
added.
fixed
- ChangeLog entry missing
fixed
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T18-48-12.23Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue job jsoniq-roundtrip-2012-09-21T18-48-12.23Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Needs Fixing. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1044260 into lp:zorba
It looks like: XUDY0014, XUDY0015, XUDY0016, XUDY0017, XUDY0023, XUDY0031, ZDDY0016, ZDDY0027. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1044260/+merge/125297 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T20-22-01.521Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
