Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-soundex_key into lp:zorba/data-cleaning-module

2013-05-21 Thread Bruno Martins
Review: Approve

The previous version of the soundex-key function had indeed a problem with the 
string 3-D Adventure, returning a stack overflow since it as recursively 
trying to produce a soundex key with just 4 characters. The new implementation 
fixes this, and also seems to be correct. 

I've approved the revision.

Nonetheless, it makes no sense to call soundex-key with an input that does 
not correspond to a single English word. Maybe the documentation should be 
changed in order to indicate this.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-soundex_key into lp:zorba/data-cleaning-module

2013-05-21 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/fix-soundex_key into 
lp:zorba/data-cleaning-module has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-soundex_key into lp:zorba/data-cleaning-module

2013-05-21 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/fix-soundex_key-2013-05-21T14-25-30.124Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-soundex_key into lp:zorba/data-cleaning-module

2013-05-21 Thread Zorba Build Bot
Validation queue job fix-soundex_key-2013-05-21T14-25-30.124Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-soundex_key into lp:zorba/data-cleaning-module

2013-05-21 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/fix-soundex_key into 
lp:zorba/data-cleaning-module has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-05-21 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch 
into lp:zorba.

Commit message:
Fixed and optimized deep-equal (bug #1180023)

Requested reviews:
  Markos Zaharioudakis (markos-za)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/164981

Fixed and optimized deep-equal (bug #1180023)
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/164981
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'ChangeLog'
--- ChangeLog	2013-05-16 09:21:28 +
+++ ChangeLog	2013-05-21 21:50:31 +
@@ -7,9 +7,11 @@
 
 Optimizations:
   * Implemented hoisting optimization for general FLWOR.
+  * Optimized implementation of fn:deep-equal
 
 Bug Fixes/Other Changes:
   * Fixed bug in hoisting through try-catch expr
+  * Fixed implementation of fn:deep-equal according to latest W3C spec.
 
 
 version 2.9

=== modified file 'src/runtime/sequences/sequences_impl.cpp'
--- src/runtime/sequences/sequences_impl.cpp	2013-05-08 20:40:49 +
+++ src/runtime/sequences/sequences_impl.cpp	2013-05-21 21:50:31 +
@@ -829,25 +829,23 @@
 /***
   15.3.1 fn:deep-equal
 /
-// Forward declaration
+
 static bool DeepEqual(
 const QueryLoc loc,
 static_context* sctx,
-dynamic_context* dctx,
 store::Item_t item1,
 store::Item_t item2,
-XQPCollator* collator);
-
-
-static bool DeepEqual(
+XQPCollator* collator,
+int timezone);
+
+
+static bool DeepEqualChildren(
 const QueryLoc loc,
 static_context* sctx,
-dynamic_context* dctx,
-store::Iterator_t it1,
-store::Iterator_t it2,
+const store::Iterator_t it1,
+const store::Iterator_t it2,
 XQPCollator* collator,
-bool skip_pi_nodes,
-bool skip_comment_nodes)
+int timezone)
 {
   store::Item_t child1, child2;
   bool c1Valid, c2Valid;
@@ -857,38 +855,35 @@
 
   while (1)
   {
-while ((c1Valid = it1-next(child1))
-
-((skip_pi_nodes  child1-getNodeKind() == store::StoreConsts::piNode)
-  ||
-(skip_comment_nodes  child1-getNodeKind() == store::StoreConsts::commentNode)))
+while ((c1Valid = it1-next(child1)) 
+   (child1-getNodeKind() == store::StoreConsts::piNode ||
+child1-getNodeKind() == store::StoreConsts::commentNode))
   ;
 
-while ((c2Valid = it2-next(child2))
-
-((skip_pi_nodes  child2-getNodeKind() == store::StoreConsts::piNode)
-  ||
-(skip_comment_nodes  child2-getNodeKind() == store::StoreConsts::commentNode)))
+while ((c2Valid = it2-next(child2)) 
+(child2-getNodeKind() == store::StoreConsts::piNode ||
+ child2-getNodeKind() == store::StoreConsts::commentNode))
   ;
 
 if (!c1Valid  !c2Valid)
   return true;
 else if (!c1Valid || !c2Valid)
   return false;
-else if (!DeepEqual(loc, sctx, dctx, child1, child2, collator))
+else if (!DeepEqual(loc, sctx, child1, child2, collator, timezone))
   return false;
   }
 
   return true;
 }
 
+
 static bool DeepEqualAttributes(
   const QueryLoc loc,
   static_context* sctx,
-  dynamic_context* dctx,
-  store::Iterator_t it1,
-  store::Iterator_t it2,
-  XQPCollator* collator)
+  const store::Iterator_t it1,
+  const store::Iterator_t it2,
+  XQPCollator* collator,
+  int timezone)
 {
   store::Item_t child1, child2;
   int c1count = 0, c2count = 0;
@@ -899,14 +894,18 @@
   while (it1-next(child1))
   {
 c1count++;
+
 it2-reset();
+
 bool found = false;
 while (it2-next(child2))
-  if (DeepEqual(loc, sctx, dctx, child1, child2, collator))
+{
+  if (DeepEqual(loc, sctx, child1, child2, collator, timezone))
   {
 found = true;
 break;
   }
+}
 
 if (!found)
   return false;
@@ -922,128 +921,196 @@
   return true;
 }
 
+
 static bool DeepEqualNodes(
 const QueryLoc loc,
 static_context* sctx,
-dynamic_context* dctx,
 const store::Item_t item1,
 const store::Item_t item2,
-XQPCollator* collator)
+XQPCollator* collator,
+int timezone)
 {
   if (item1-getNodeKind() != item2-getNodeKind())
 return false;
 
   switch (item1-getNodeKind())
   {
-case store::StoreConsts::anyNode:
-  ZORBA_ASSERT(false);  // case not treated
-  break;
-
-case store::StoreConsts::documentNode:
-{
-  return DeepEqual(loc,
-   sctx,
-   dctx,
-   item1-getChildren(),
-   item2-getChildren(),
-   collator,
-   true,
-   false);
-  break;
-}
-case store::StoreConsts::elementNode:
-{
-  if (! item1-getNodeName()-equals(item2-getNodeName()))
-return false;
-
- 

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-05-21 Thread Markos Zaharioudakis
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/164981
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-05-21 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has 
been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/164981
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/164981
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-05-21 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-05-21T21-59-47.74Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/164981
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-05-21 Thread Zorba Build Bot
Validation queue job markos-scratch-2013-05-21T21-59-47.74Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/164981
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-05-21 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has 
been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/164981
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/164981
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba

2013-05-21 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/install-symlink-jars 
into lp:zorba.

Commit message:
If specified EXTERNAL jar is a symlink, install the target of the symlink.

Requested reviews:
  Zorba Coders (zorba-coders)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
-- 
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba.
=== modified file 'cmake_modules/ZorbaModule.cmake'
--- cmake_modules/ZorbaModule.cmake	2013-03-28 01:00:17 +
+++ cmake_modules/ZorbaModule.cmake	2013-05-21 23:50:35 +
@@ -516,7 +516,11 @@
   # Put absolute path into classpath file
   FILE (APPEND ${_CP_FILE} ${_jar_file}\n)
 ELSE (JAR_EXTERNAL AND NOT ZORBA_PACKAGE_EXTERNAL_JARS)
-  # Copy jar to jars/ directory and add relative path to classpath file
+  # Copy real jar (after following any symlinks) to jars/ directory
+  # and add relative path to classpath file
+  IF (IS_SYMLINK ${_jar_file})
+	GET_FILENAME_COMPONENT (_jar_file ${_jar_file} REALPATH)
+  ENDIF (IS_SYMLINK ${_jar_file})
   GET_FILENAME_COMPONENT (_output_filename ${_jar_file} NAME)
   ADD_COPY_RULE (LIB ${_jar_file} jars/${_output_filename}  
 	${JAR_TARGET} 1 ${JAR_TEST_ONLY})

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba

2013-05-21 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba 
has been updated.

Commit Message changed to:

If specified EXTERNAL jar is a symlink, install the target of the symlink.

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
-- 
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba

2013-05-21 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba

2013-05-21 Thread Juan Zacarias
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba

2013-05-21 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
-- 
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba

2013-05-21 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/install-symlink-jars-2013-05-22T01-10-43.295Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba

2013-05-21 Thread Zorba Build Bot
Validation queue job install-symlink-jars-2013-05-22T01-10-43.295Z is finished. 
The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba

2013-05-21 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/install-symlink-jars into lp:zorba 
has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
-- 
https://code.launchpad.net/~zorba-coders/zorba/install-symlink-jars/+merge/164993
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103115 into lp:zorba

2013-05-21 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/bug-1103115 into 
lp:zorba.

Commit message:
Corrected time-zone units and did a clean-up of the TimeZone class.

Requested reviews:
  Paul J. Lucas (paul-lucas)
Related bugs:
  Bug #1103115 in Zorba: Timezone units as hours are wrong
  https://bugs.launchpad.net/zorba/+bug/1103115

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103115/+merge/165002

Corrected time-zone units and did a clean-up of the TimeZone class.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103115/+merge/165002
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'include/zorba/dynamic_context.h'
--- include/zorba/dynamic_context.h	2013-03-13 16:17:38 +
+++ include/zorba/dynamic_context.h	2013-05-22 02:24:29 +
@@ -213,7 +213,7 @@
* or dateTime value that does not have a timezone is used in a comparison or
* arithmetic operation.
*
-   * @param aTimezone the implicit timezone as int that should be used.
+   * @param aTimezone the number of seconds east of the prime meridian.
* @return true if the implicit timezone has been set successfully, false otherwise.
* @throw ZorbaException if an error occured.
*/
@@ -223,8 +223,9 @@
   /** \brief Retrieve the implicit timezone used in comparisons or arithmetic operations
* of date, time, or dateTime values.
*
-   * @return int the implicit timezone. Note that 0 is returned if an error occured
-   * and an DiagnosticHandler is used.
+   * @return the implicit timezone as the number of seconds east of the
+   * prime medidian. Note that 0 is returned if an error occured and an
+   * DiagnosticHandler is used.
* @throw ZorbaException if an error occured.
*/
   virtual int

=== modified file 'include/zorba/item_factory.h'
--- include/zorba/item_factory.h	2013-04-17 00:24:24 +
+++ include/zorba/item_factory.h	2013-05-22 02:24:29 +
@@ -327,13 +327,13 @@
* @param aHour short-valued representation of the hour.
* @param aMinute short-valued representation of the minute.
* @param aSecond double-valued representation of the seconds and fractional seconds.
-   * @param aTimeZone_hours short-valued representation of the difference in hours to UTC.
+   * @param aTimeZone the number of seconds east of the prime meridian.
* @return The DateTime Item.
*/
   virtual Item
   createDateTime(short aYear, short aMonth, short aDay,
  short aHour, short aMinute, double aSecond,
- short aTimeZone_hours) = 0;
+ int aTimeZone) = 0;
 
   /** \brief Creates a DateTime Item without setting a time zone.
* see [http://www.w3.org/TR/xmlschema-2/#dateTime]
@@ -615,11 +615,11 @@
* @param aHour short representation of the hour.
* @param aMinute short representation of the minute.
* @param aSecond double representation of the seconds and fractional seconds.
-   * @param aTimeZone_hours short representation of the timezone difference in hours to UTC.
+   * @param aTimeZone the number of seconds east of the prime meridian.
* @return The Time Item.
*/
   virtual Item
-  createTime ( short aHour, short aMinute, double aSecond, short aTimeZone_hours ) = 0;
+  createTime ( short aHour, short aMinute, double aSecond, int aTimeZone ) = 0;
 
   /** \brief Creates an Unsigned Byte Item
* see [http://www.w3.org/TR/xmlschema-2/#unsignedByte]
@@ -848,13 +848,13 @@
* @param aHour short-valued representation of the hour.
* @param aMinute short-valued representation of the minute.
* @param aSecond double-valued representation of the seconds and fractional seconds.
-   * @param aTimeZone_hours short-valued representation of the difference in hours to UTC.
+   * @param aTimeZone the number of seconds east of the prime meridian.
* @return The DateTimeStamp Item.
*/
   virtual Item
   createDateTimeStamp(short aYear, short aMonth, short aDay,
   short aHour, short aMinute, double aSecond,
-  short aTimeZone_hours) = 0;
+  int aTimeZone) = 0;
 
   /** \brief Creates a DateTimeStamp Item
* see [www.w3.org/TR/xmlschema11-2/#dateTimeStamp]

=== modified file 'src/api/itemfactoryimpl.cpp'
--- src/api/itemfactoryimpl.cpp	2013-05-15 23:22:01 +
+++ src/api/itemfactoryimpl.cpp	2013-05-22 02:24:29 +
@@ -402,11 +402,11 @@
   
 Item ItemFactoryImpl::createDateTime(short aYear, short aMonth, short aDay,
   short aHour, short aMinute, double aSecond,
-  short aTimezone_hours)
+  int aTimezone)
 {
   store::Item_t lItem;
   theItemFactory-createDateTime(lItem, aYear, aMonth, aDay,
-  

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103115 into lp:zorba

2013-05-21 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103115/+merge/165002
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103115 into lp:zorba

2013-05-21 Thread Paul J. Lucas
The proposal to merge lp:~zorba-coders/zorba/bug-1103115 into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103115/+merge/165002
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103115/+merge/165002
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103115 into lp:zorba

2013-05-21 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug-1103115-2013-05-22T03-06-58.287Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103115/+merge/165002
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103115 into lp:zorba

2013-05-21 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug-1103115 into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job bug-1103115-2013-05-22T03-06-58.287Z is finished.  The
  final status was:

  

  10 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103115/+merge/165002
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103115 into lp:zorba

2013-05-21 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-1103115 into lp:zorba has been 
updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103115/+merge/165002
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103115/+merge/165002
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp