[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1180224 into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/bug-1180224 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 -- https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1180224 into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve. -- https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1180224 into lp:zorba
Validation queue job bug-1180224-2013-06-04T04-39-59.57Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1180224 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1180224-2013-06-04T04-39-59.57Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1180224 into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/bug-1180224 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 -- https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module
The proposal to merge lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module
The proposal to merge lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-process into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/bug-1180220-process into lp:zorba/process-module has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-process/+merge/167191 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-process/+merge/167191 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-process into lp:zorba/process-module
Validation queue job bug-1180220-process-2013-06-04T02-49-37Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-process/+merge/167191 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-process into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1180220-process-2013-06-04T02-49-37Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-process/+merge/167191 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-jdbc into lp:zorba/jdbc-module
The proposal to merge lp:~zorba-coders/zorba/bug-1180220-jdbc into lp:zorba/jdbc-module has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-jdbc/+merge/167190 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-jdbc/+merge/167190 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-jdbc into lp:zorba/jdbc-module
Validation queue job bug-1180220-jdbc-2013-06-04T02-24-48.707Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-jdbc/+merge/167190 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-process into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/bug-1180220-process into lp:zorba/process-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-process/+merge/167191 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-process/+merge/167191 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-process into lp:zorba/process-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-process/+merge/167191 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-process into lp:zorba/process-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-process/+merge/167191 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-jdbc into lp:zorba/jdbc-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1180220-jdbc-2013-06-04T02-24-48.707Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-jdbc/+merge/167190 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-jdbc into lp:zorba/jdbc-module
The proposal to merge lp:~zorba-coders/zorba/bug-1180220-jdbc into lp:zorba/jdbc-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-jdbc/+merge/167190 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-jdbc/+merge/167190 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-process into lp:zorba/process-module
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/bug-1180220-process into lp:zorba/process-module. Commit message: Removed unnecessary #include. Requested reviews: Chris Hillery (ceejatec) Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-process/+merge/167191 Removed unnecessary #include. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-process/+merge/167191 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. === modified file 'src/com/zorba-xquery/www/modules/process.xq.src/process.cpp' --- src/com/zorba-xquery/www/modules/process.xq.src/process.cpp 2012-12-05 17:29:38 + +++ src/com/zorba-xquery/www/modules/process.xq.src/process.cpp 2013-06-04 02:24:27 + @@ -45,7 +45,6 @@ #include #include #include -#include #include "process.h" -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-jdbc into lp:zorba/jdbc-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-jdbc/+merge/167190 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-jdbc into lp:zorba/jdbc-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-jdbc/+merge/167190 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-jdbc into lp:zorba/jdbc-module
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/bug-1180220-jdbc into lp:zorba/jdbc-module. Commit message: Removed unnecessary #include. Requested reviews: Chris Hillery (ceejatec) Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-jdbc/+merge/167190 Removed unnecessary #include. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-jdbc/+merge/167190 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. === modified file 'src/jdbc.xq.src/jdbc.cpp' --- src/jdbc.xq.src/jdbc.cpp 2013-01-29 21:33:07 + +++ src/jdbc.xq.src/jdbc.cpp 2013-06-04 02:20:37 + @@ -20,7 +20,6 @@ #include #include #include -#include #include #include #include -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module
The proposal to merge lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module
The proposal to merge lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module has been updated. Description changed to: Removed unnecessary #include. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module. Commit message: Removed unnecessary #include. Requested reviews: Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167188 Removed unnecessary #include. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167188 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module
The proposal to merge lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module has been updated. Commit Message changed to: Removed unnecessary #include. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module. Commit message: Removed unnecessary #include. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 Removed unnecessary #include. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167189 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. === modified file 'src/csv.xq.src/csv.cpp' --- src/csv.xq.src/csv.cpp 2011-08-18 20:54:58 + +++ src/csv.xq.src/csv.cpp 2013-06-04 02:13:30 + @@ -32,7 +32,6 @@ #include #include #include -#include #include "csv.h" -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167187 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220-csv/+merge/167187 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/bug-1180220-csv into lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1180224 into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/bug-1180224 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 -- https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1180224 into lp:zorba
The attempt to merge lp:~paul-lucas/zorba/bug-1180224 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message): Validation queue job bug-1180224-2013-06-04T00-44-49.419Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1180224 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1180224-2013-06-04T00-44-49.419Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1180224 into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/bug-1180224 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 -- https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1180224 into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1180224 into lp:zorba
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/bug-1180224 into lp:zorba. Commit message: Removed category enum and everything that goes along with it. Requested reviews: Paul J. Lucas (paul-lucas) Related bugs: Bug #1180224 in Zorba: "Remove categories from API's diagnostic class" https://bugs.launchpad.net/zorba/+bug/1180224 For more details, see: https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Removed category enum and everything that goes along with it. -- https://code.launchpad.net/~paul-lucas/zorba/bug-1180224/+merge/167184 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug-1180220 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message): Validation queue job bug-1180220-2013-06-03T23-40-21.931Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220/+merge/167177 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1180220 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220/+merge/167177 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220/+merge/167177 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1180220-2013-06-03T23-40-21.931Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220/+merge/167177 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/167176 -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/167176 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue job markos-scratch-2013-06-03T23-11-55.014Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/167176 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1180220 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220/+merge/167177 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220/+merge/167177 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-06-03T23-11-55.014Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/167176 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/167176 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1180220 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220/+merge/166919 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220/+merge/166919 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/167176 -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/167176 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220 into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220/+merge/166919 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1180220 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1180220 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1180220/+merge/166919 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1180220/+merge/166919 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch
into lp:zorba.
Commit message:
fixed memory error in UserDefinedXQType::isSuperTypeOf()
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/167176
fixed memory error in UserDefinedXQType::isSuperTypeOf()
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/167176
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'ChangeLog'
--- ChangeLog 2013-05-24 20:45:21 +
+++ ChangeLog 2013-06-03 23:06:31 +
@@ -22,6 +22,8 @@
* Fixed implementation of fn:deep-equal according to latest W3C spec.
* Must apply document ordering on the domain expression of a FOR clause, if
the FOR clause is followed by a sequential clause.
+ * Fixed invalid memory access error occuring during sequence type matching
+for user-defined types.
version 2.9
=== modified file 'src/types/typeimpl.cpp'
--- src/types/typeimpl.cpp 2013-05-21 21:44:25 +
+++ src/types/typeimpl.cpp 2013-06-03 23:06:31 +
@@ -1500,26 +1500,26 @@
/
bool UserDefinedXQType::isSuperTypeOf(
const TypeManager* tm,
-const XQType& subType,
+const XQType* subType,
const QueryLoc& loc) const
{
- if (isUnion() && isGenAtomicAny() && subType.isAtomicAny())
+ if (isUnion() && isGenAtomicAny() && subType->isAtomicAny())
{
std::vector::const_iterator ite = m_unionItemTypes.begin();
std::vector::const_iterator end = m_unionItemTypes.end();
for (; ite != end; ++ite)
{
- if (TypeOps::is_subtype(tm, subType, *(*ite), loc))
+ if (TypeOps::is_subtype(tm, *subType, *(*ite), loc))
return true;
}
return false;
}
- if (subType.type_kind() != XQType::USER_DEFINED_KIND)
+ if (subType->type_kind() != XQType::USER_DEFINED_KIND)
return false;
- const UserDefinedXQType* subtype = static_cast(&subType);
+ const UserDefinedXQType* subtype = static_cast(subType);
do
{
@@ -1529,14 +1529,13 @@
return true;
}
-if (subtype->type_kind() == XQType::USER_DEFINED_KIND)
-{
- subtype = static_cast(subtype->getBaseType().getp());
-}
-else
-{
+subType = subtype->getBaseType().getp();
+
+if (subType->type_kind() != XQType::USER_DEFINED_KIND)
return false;
-}
+
+subtype = static_cast(subType);
+
}
while (subtype != NULL);
=== modified file 'src/types/typeimpl.h'
--- src/types/typeimpl.h 2013-05-21 21:44:25 +
+++ src/types/typeimpl.h 2013-06-03 23:06:31 +
@@ -802,7 +802,7 @@
bool isSuperTypeOf(
const TypeManager* tm,
- const XQType& subType,
+ const XQType* subType,
const QueryLoc& loc) const;
bool isSubTypeOf(const TypeManager* tm, const XQType& superType) const;
=== modified file 'src/types/typeops.cpp'
--- src/types/typeops.cpp 2013-04-23 20:38:23 +
+++ src/types/typeops.cpp 2013-06-03 23:06:31 +
@@ -486,9 +486,7 @@
case XQType::ANY_FUNCTION_TYPE_KIND:
case XQType::EMPTY_KIND:
case XQType::STRUCTURED_ITEM_KIND:
-#ifdef ZORBA_WITH_JSON
case XQType::JSON_TYPE_KIND:
-#endif
return true;
case XQType::USER_DEFINED_KIND:
@@ -577,9 +575,7 @@
case XQType::NODE_TYPE_KIND:
case XQType::EMPTY_KIND:
case XQType::STRUCTURED_ITEM_KIND:
-#ifdef ZORBA_WITH_JSON
case XQType::JSON_TYPE_KIND:
-#endif
return true;
default:
@@ -590,7 +586,6 @@
break;
}
-#ifdef ZORBA_WITH_JSON
case XQType::JSON_TYPE_KIND:
{
if (subtype.type_kind() != XQType::JSON_TYPE_KIND)
@@ -615,7 +610,6 @@
ZORBA_ASSERT(false);
}
}
-#endif
case XQType::NODE_TYPE_KIND:
{
@@ -656,9 +650,7 @@
case XQType::NODE_TYPE_KIND:
case XQType::ITEM_KIND:
-#ifdef ZORBA_WITH_JSON
case XQType::JSON_TYPE_KIND:
-#endif
case XQType::STRUCTURED_ITEM_KIND:
return false;
@@ -710,7 +702,7 @@
const UserDefinedXQType& udt =
static_cast(supertype);
-return udt.isSuperTypeOf(tm, subtype, loc);
+return udt.isSuperTypeOf(tm, &subtype, loc);
}
default:
@@ -822,17 +814,12 @@
case XQType::STRUCTURED_ITEM_KIND:
{
-#ifdef ZORBA_WITH_JSON
if (subitem->isStructuredItem())
-#else
-if (subitem->isNode())
-#endif
return true;
return false;
}
-#ifdef ZORBA_WITH_JSON
case XQType::JSON_TYPE_KIND:
{
if (!subitem->isJSONItem())
@@ -856,7 +843,6 @@
ZORBA_ASSERT(false);
}
}
-#endif
case XQType::NODE_TYPE_KIND:
{
@@ -904,7 +890,7 @@
const UserDefinedXQType& udSuperType =
static_cast(supertype);
-return udSuperType.isSuperTypeOf(tm, *subtype, loc);
+return udSuperType.isSuperTypeOf(tm, subtype.getp(), loc);
}
default:
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zor
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Review: Needs Fixing - I didn't see the changes you described in the last comment. Did you not push them? - Why does the module use XQuery instead of JSONiq? I think it should use JSONiq and not use prefixes for types etc. - we might have to change the namespace to zorba.io - comments should use to separate paragraphs instead of newlines. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Matthias, They URI messages won't appear anymore, but I've done it by calling abort() instead of exit() in the child fork() in the process module, because: -- it will keep the Zorba URIs leaks messages in the Release build -- the exit code in the case of an error is lost anyway due to the thrown exception in Zorba -- it is not actually correct to deallocate the Zorba store twice (once in the child and the second time in the parent). It could lead to problems if store is not an in-memory store. I've added a lengthy comment in the code describing what happens and where the problem lies. If the error exit code could be sent to the main process (e.g. through another opened pipe) then it would work perfectly. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
