Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug986016 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug986016/+merge/102792 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug986016 into lp:zorba
How did you discover this work-around? Perhaps a comment explaining it so nobody removed the apparently useless !! ? -- https://code.launchpad.net/~zorba-coders/zorba/bug986016/+merge/102792 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug986016 into lp:zorba
I discovered it here: http://stackoverflow.com/questions/9285657/sfinae-differentiation-between-signed-and-unsigned -- https://code.launchpad.net/~zorba-coders/zorba/bug986016/+merge/102792 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug986016 into lp:zorba
What was the error you got? -- https://code.launchpad.net/~zorba-coders/zorba/bug986016/+merge/102792 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug986016 into lp:zorba
Also, to Matthias: please put a link to the stackoverflow page in the block comment above all the functions... something like: Note: the use of !! is to work around a compiler problem on Windows; see: http://stackoverflow.com/questions/9285657/sfinae-differentiation-between-signed-and-unsigned -- https://code.launchpad.net/~zorba-coders/zorba/bug986016/+merge/102792 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug986016 into lp:zorba
I'd also be curious as to whether adding additional is_integral checks to the enable_if's would solve the problem, i.e.: typename std::enable_ifZORBA_TR1_NS::is_integralN1::value ZORBA_TR1_NS::is_unsignedN1::value ZORBA_TR1_NS::is_integralN2::value ZORBA_TR1_NS::is_unsignedN2::value,bool::type -- https://code.launchpad.net/~zorba-coders/zorba/bug986016/+merge/102792 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug986016 into lp:zorba
Validation queue job bug986016-2012-04-20T14-58-58.982Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug986016/+merge/102876 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug986016 into lp:zorba
Rodolfo Ochoa has proposed merging lp:~zorba-coders/zorba/bug986016 into
lp:zorba.
Requested reviews:
Cezar Andrei (cezar-andrei)
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #986016 in Zorba: Windows trunk not compiling
https://bugs.launchpad.net/zorba/+bug/986016
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug986016/+merge/102792
Workaround Windows compiler error
--
https://code.launchpad.net/~zorba-coders/zorba/bug986016/+merge/102792
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/util/stl_util.h'
--- src/util/stl_util.h 2012-04-19 21:40:27 +
+++ src/util/stl_util.h 2012-04-20 05:20:24 +
@@ -309,21 +309,21 @@
templatetypename N1,typename N2 inline
typename std::enable_ifZORBA_TR1_NS::is_signedN1::value
- ZORBA_TR1_NS::is_unsignedN2::value,bool::type
+ !!ZORBA_TR1_NS::is_unsignedN2::value,bool::type
ge_min( N1 n1, N2 ) {
return n1 = 0;
}
templatetypename N1,typename N2 inline
-typename std::enable_ifZORBA_TR1_NS::is_unsignedN1::value
+typename std::enable_if!!ZORBA_TR1_NS::is_unsignedN1::value
ZORBA_TR1_NS::is_signedN2::value,bool::type
ge_min( N1, N2 ) {
return true;
}
templatetypename N1,typename N2 inline
-typename std::enable_ifZORBA_TR1_NS::is_unsignedN1::value
- ZORBA_TR1_NS::is_unsignedN2::value,bool::type
+typename std::enable_if!!ZORBA_TR1_NS::is_unsignedN1::value
+ !!ZORBA_TR1_NS::is_unsignedN2::value,bool::type
ge_min( N1, N2 ) {
return true;
}
@@ -337,21 +337,21 @@
templatetypename N1,typename N2 inline
typename std::enable_ifZORBA_TR1_NS::is_signedN1::value
- ZORBA_TR1_NS::is_unsignedN2::value,bool::type
+ !!ZORBA_TR1_NS::is_unsignedN2::value,bool::type
le_max( N1 n1, N2 ) {
return n1 = 0 || static_castN2( n1 ) = std::numeric_limitsN2::max();
}
templatetypename N1,typename N2 inline
-typename std::enable_ifZORBA_TR1_NS::is_unsignedN1::value
+typename std::enable_if!!ZORBA_TR1_NS::is_unsignedN1::value
ZORBA_TR1_NS::is_signedN2::value,bool::type
le_max( N1 n1, N2 ) {
return n1 = static_castN1( std::numeric_limitsN2::max() );
}
templatetypename N1,typename N2 inline
-typename std::enable_ifZORBA_TR1_NS::is_unsignedN1::value
- ZORBA_TR1_NS::is_unsignedN2::value,bool::type
+typename std::enable_if!!ZORBA_TR1_NS::is_unsignedN1::value
+ !!ZORBA_TR1_NS::is_unsignedN2::value,bool::type
le_max( N1 n1, N2 ) {
return n1 = std::numeric_limitsN2::max();
}
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug986016 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug986016 into lp:zorba has been updated. Commit Message changed to: Workaround Windows compiler error For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug986016/+merge/102792 -- https://code.launchpad.net/~zorba-coders/zorba/bug986016/+merge/102792 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
