Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/util-jvm-rpath into lp:zorba/util-jvm-module

2013-05-27 Thread Juan Zacarias
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/util-jvm-rpath into lp:zorba/util-jvm-module

2013-05-27 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/util-jvm-rpath into lp:zorba/util-jvm-module

2013-05-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/util-jvm-rpath into 
lp:zorba/util-jvm-module has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
-- 
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/util-jvm-rpath into lp:zorba/util-jvm-module

2013-05-27 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/util-jvm-rpath-2013-05-27T19-06-44.412Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/util-jvm-rpath into lp:zorba/util-jvm-module

2013-05-27 Thread Zorba Build Bot
Validation queue job util-jvm-rpath-2013-05-27T19-06-44.412Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/util-jvm-rpath into lp:zorba/util-jvm-module

2013-05-27 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/util-jvm-rpath into 
lp:zorba/util-jvm-module has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
-- 
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/util-jvm-rpath into lp:zorba/util-jvm-module

2013-05-08 Thread Juan Zacarias
Juan Zacarias has proposed merging lp:~zorba-coders/zorba/util-jvm-rpath into 
lp:zorba/util-jvm-module.

Commit message:
Fixes for Debian Installers.

Requested reviews:
  Chris Hillery (ceejatec)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074

Fixes for Debian Installers.
-- 
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.
=== added file 'cmake_modules/FindJNI.cmake'
--- cmake_modules/FindJNI.cmake	1970-01-01 00:00:00 +
+++ cmake_modules/FindJNI.cmake	2013-05-09 00:10:32 +
@@ -0,0 +1,286 @@
+# - Find JNI java libraries.
+# This module finds if Java is installed and determines where the
+# include files and libraries are. It also determines what the name of
+# the library is. This code sets the following variables:
+#   
+#  JNI_INCLUDE_DIRS  = the include dirs to use
+#  JNI_LIBRARIES = the libraries to use
+#  JNI_FOUND = TRUE if JNI headers and libraries were found.
+#  JAVA_AWT_LIBRARY  = the path to the jawt library
+#  JAVA_JVM_LIBRARY  = the path to the jvm library
+#  JAVA_INCLUDE_PATH = the include path to jni.h
+#  JAVA_INCLUDE_PATH2= the include path to jni_md.h
+#  JAVA_AWT_INCLUDE_PATH = the include path to jawt.h
+#
+
+#=
+# Copyright 2001-2009 Kitware, Inc.
+#
+# Distributed under the OSI-approved BSD License (the License);
+# see accompanying file Copyright.txt for details.
+#
+# This software is distributed WITHOUT ANY WARRANTY; without even the
+# implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+# See the License for more information.
+#=
+# (To distribute this file outside of CMake, substitute the full
+#  License text for the above reference.)
+
+# Expand {libarch} occurences to java_libarch subdirectory(-ies) and set ${_var}
+MACRO(java_append_library_directories _var)
+# Determine java arch-specific library subdir
+# Mostly based on openjdk/jdk/make/common/shared/Platform.gmk as of openjdk
+# 1.6.0_18 + icedtea patches. However, it would be much better to base the
+# guess on the first part of the GNU config.guess platform triplet.
+IF(CMAKE_SYSTEM_PROCESSOR STREQUAL x86_64)
+SET(_java_libarch amd64)
+ELSEIF(CMAKE_SYSTEM_PROCESSOR MATCHES ^i.86$)
+SET(_java_libarch i386)
+ELSEIF(CMAKE_SYSTEM_PROCESSOR MATCHES ^alpha)
+SET(_java_libarch alpha)
+ELSEIF(CMAKE_SYSTEM_PROCESSOR MATCHES ^arm)
+# Subdir is arm for both big-endian (arm) and little-endian (armel).
+SET(_java_libarch arm)
+ELSEIF(CMAKE_SYSTEM_PROCESSOR MATCHES ^mips)
+# mips* machines are bi-endian mostly so processor does not tell
+# endianess of the underlying system.
+SET(_java_libarch ${CMAKE_SYSTEM_PROCESSOR} mips mipsel mipseb)
+ELSEIF(CMAKE_SYSTEM_PROCESSOR MATCHES ^(powerpc|ppc)64)
+SET(_java_libarch ppc64)
+ELSEIF(CMAKE_SYSTEM_PROCESSOR MATCHES ^(powerpc|ppc))
+SET(_java_libarch ppc)
+ELSEIF(CMAKE_SYSTEM_PROCESSOR MATCHES ^sparc)
+# Both flavours can run on the same processor
+SET(_java_libarch ${CMAKE_SYSTEM_PROCESSOR} sparc sparcv9)
+ELSEIF(CMAKE_SYSTEM_PROCESSOR MATCHES ^(parisc|hppa))
+SET(_java_libarch parisc parisc64)
+ELSEIF(CMAKE_SYSTEM_PROCESSOR MATCHES ^s390)
+# s390 binaries can run on s390x machines
+SET(_java_libarch ${CMAKE_SYSTEM_PROCESSOR} s390 s390x)
+ELSEIF(CMAKE_SYSTEM_PROCESSOR MATCHES ^sh)
+SET(_java_libarch sh)
+ELSE(CMAKE_SYSTEM_PROCESSOR STREQUAL x86_64)
+SET(_java_libarch ${CMAKE_SYSTEM_PROCESSOR})
+ENDIF(CMAKE_SYSTEM_PROCESSOR STREQUAL x86_64)
+
+# Append default list architectures if CMAKE_SYSTEM_PROCESSOR was empty or
+# system is non-Linux (where the code above has not been well tested)
+IF(NOT _java_libarch OR NOT CMAKE_SYSTEM_NAME MATCHES Linux)
+LIST(APPEND _java_libarch i386 amd64 ppc)
+ENDIF(NOT _java_libarch OR NOT CMAKE_SYSTEM_NAME MATCHES Linux)
+
+# Sometimes ${CMAKE_SYSTEM_PROCESSOR} is added to the list to prefer
+# current value to a hardcoded list. Remove possible duplicates.
+LIST(REMOVE_DUPLICATES _java_libarch)
+
+FOREACH(_path ${ARGN})
+IF(_path MATCHES {libarch})
+FOREACH(_libarch ${_java_libarch})
+STRING(REPLACE {libarch} ${_libarch} _newpath ${_path})
+LIST(APPEND ${_var} ${_newpath})
+ENDFOREACH(_libarch)
+ELSE(_path MATCHES {libarch})
+LIST(APPEND ${_var} ${_path})
+ENDIF(_path MATCHES {libarch})
+ENDFOREACH(_path)
+ENDMACRO(java_append_library_directories)
+
+GET_FILENAME_COMPONENT(java_install_version
+  [HKEY_LOCAL_MACHINE\\SOFTWARE\\JavaSoft\\Java 

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/util-jvm-rpath into lp:zorba/util-jvm-module

2013-05-08 Thread Chris Hillery
Review: Needs Fixing

1. I believe that the correct values for RPATH are directories, not actual .so 
files, so the value of INSTALL_RPATH_PATHS should omit all the /libjvm.so 
parts.

2. FindJNI.cmake says:

# (To distribute this file outside of CMake, substitute the full
#  License text for the above reference.)

So, we should do that.
-- 
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp