Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-29 Thread William Candillon 
I've added this improvement in commit 10674.
-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-29 Thread Markos Zaharioudakis 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-29 Thread Matthias Brantner 
I approve the fix but the indentation still deserves some improvements (i.e. a 
space after the if if().
-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-29 Thread Matthias Brantner 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-28 Thread Markos Zaharioudakis 
A small code improvement: rather thah doing a dynamic_cast to check if an expr 
is an fo_expr, use the get_expr_kind() method. So, the code would look like 
this:

if (right-get_expr_kind() == fo_expr_kind)
{
  fo_expr* lfoExpr = static_castfo_expr*(right.getp());
  etc;
}

Also, please respect the coding style of the files you update. In this case, 
put the { in a separate line.

-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-27 Thread Zorba Build Bot 
There are additional revisions which have not been approved in review. Please 
seek review and approval of these new revisions.
-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-21 Thread Matthias Brantner 
Review: Needs Fixing

- I talked to Paul about the error message. He said it should be:

multi-item sequence can not be operand for concatenation

- NoSeqForFnOp_3: the _3 usually indicates that this error message has 3 
parameters which is wrong in this case

-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94009
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-21 Thread Zorba Build Bot 
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1. 
Got: 1 Approve, 1 Needs Fixing, 2 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94009
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-21 Thread William Candillon 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94036
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-21 Thread Matthias Brantner 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94036
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-20 Thread Matthias Brantner 
Review: Needs Information

Looks pretty good. One question: shouldn't the StringConcatExpr not be added to 
the %destructor directive in xquery_parser.y?
-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93773
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-20 Thread Zorba Build Bot 
The attempt to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job concat_operator-2012-02-20T16-10-08.516Z is finished.
  The final status was:

  

  No tests were run - build or configure step must have failed.

  Not commiting changes.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93773
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba

2012-02-20 Thread Zorba Build Bot 
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1. 
Got: 1 Approve, 3 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93879
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp