Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dataf-module-fix into lp:zorba/data-formatting-module
Review: Approve Looks good. -- https://code.launchpad.net/~zorba-coders/zorba/dataf-module-fix/+merge/105267 Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dataf-module-fix into lp:zorba/data-formatting-module
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/dataf-module-fix/+merge/105091 Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dataf-module-fix into lp:zorba/data-formatting-module
I have hard-coded some version such that the jars are at least found with the current port version of xsl-fo. That's clearly not a long-term solution but given the fact that find_jar is not in cmake 2.8.5 I don't see any quick fix for this. The right solution is probably to come up with a FindFOP.cmake script that does all the magic. -- https://code.launchpad.net/~zorba-coders/zorba/dataf-module-fix/+merge/105122 Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dataf-module-fix into lp:zorba/data-formatting-module
Review: Needs Fixing I don't think you should have removed the XSL_FOP_HOME/build and XSL_FOP_HOME/lib directories from the PATHS of FIND_FILE(). Those are where they will be located if you download the binary distribution of FOP from Apache. However, the bigger problem is the version numbers in the jar filenames in the binary distribution, as well as in the files from Macports and other places. FIND_FILE() cannot find these, and that's bad. After some discussion with Matthias today, we decided the only viable approach was effectively to re-implement FIND_FILE() with the ability to do glob patterns. I am going to see if I can add a macro to do that for jar files to the util-jvm package; if not I'll just embed it in the FOP module for now. -- https://code.launchpad.net/~zorba-coders/zorba/dataf-module-fix/+merge/105131 Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
