Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

2014-08-12 Thread Sergey Bylokhov
On 12.08.2014 1:34, Jim Graham wrote: Hi Sergey, Is the -g:none the result of #2 below? This was changed to align with javac debug=flase... in build xml(typo was fixed as well). Also, if I read the email trail correctly then source/target=1.6 is only there because JDK 9 compiler doesn't

Re: [OpenJDK 2D-Dev] Review Request for JDK-8054877: Javadoc issue in javax.print

2014-08-12 Thread Phil Race
612 * Write the instance to a stream (ie serialize the object). 613 * 614 * @exception IOException Thrown if there was an I/O error while creating 615 * the output stream 616 */ 617 private void writeObject(ObjectOutputStream s) throws IOException { 618 619

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

2014-08-12 Thread Jim Graham
The new Readme explanation looks good. Thanks for updating the new code for pre-1.5. I notice that one of the changes (in CMMTests) is to a line with a typo (Platfrom instead of Platform both in the code and in the comment on the same line), but fixing the typo might affect a lot of other

Re: [OpenJDK 2D-Dev] Review Request for JDK-8054878: javadoc issues in javax.imageio

2014-08-12 Thread Pushan Hinduja
Hello, Here is the updated Webrev for the fix: http://cr.openjdk.java.net/~ssides/8054878/8054878.1/ Thank you -- Pushan Hinduja On Tue, Aug 12, 2014 at 1:01 PM, Phil Race philip.r...@oracle.com wrote: 309 * @exception DOMException thrown if the node is not codenull/code or 310

Re: [OpenJDK 2D-Dev] Review Request for JDK-8054878: javadoc issues in javax.imageio

2014-08-12 Thread Phil Race
Approved. -phil. On 8/12/14 2:56 PM, Pushan Hinduja wrote: Hello, Here is the updated Webrev for the fix: http://cr.openjdk.java.net/~ssides/8054878/8054878.1/ http://cr.openjdk.java.net/%7Essides/8054878/8054878.1/ Thank you -- Pushan Hinduja On Tue, Aug 12, 2014 at 1:01 PM, Phil Race

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

2014-08-12 Thread Sergey Bylokhov
Hi, Jim. Actually a Boolean was changed to a boolean, to skip autoboxing. http://cr.openjdk.java.net/~serb/8042199/webrev.02/src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/CMMTests.java.sdiff.html The new Readme explanation looks good. Thanks for updating the new code for pre-1.5. I

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

2014-08-12 Thread Jim Graham
Hi Sergey, I understand that the type was changed for a reason, but the variable is spelled Platfrom - which is not a word - and the same text appears in the comment there. The word intended there is, I believe, Platform... ...jim On 8/12/14 4:20 PM, Sergey Bylokhov

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

2014-08-12 Thread Sergey Bylokhov
Hi Jim. Yes, you are right, I missed it even after attentive viewing. Typo was fixed: http://cr.openjdk.java.net/~serb/8042199/webrev.03 Hi Sergey, I understand that the type was changed for a reason, but the variable is spelled Platfrom - which is not a word - and the same text appears in

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

2014-08-12 Thread Jim Graham
Thanks Sergey, looks good - approved. It's interesting to note that you fixed the text that controls the name of the command line option and option listed in results files, but since the option is commented out anyway then I'm guessing that there are no benchmark scripts that could have been

[OpenJDK 2D-Dev] Review request for JDK-8054638 xrender: text drawn after setColor(Color.white) is actually black

2014-08-12 Thread Clemens Eisserer
Hello, Please review my fix for JDK-8054638 xrender: text drawn after setColor(Color.white) is actually black. The XRSolidSrcPict manages a small 1x1 pixmap which is used as source surface for some operations. To avoid redundant fillRect operations when setting it's color, the currently set

Re: [OpenJDK 2D-Dev] Review request for JDK-8054638 xrender: text drawn after setColor(Color.white) is actually black

2014-08-12 Thread Clemens Eisserer
Sorry, forgot to include the link to the webrev: http://cr.openjdk.java.net/~ceisserer/8054638/webrev.00/ 2014-08-13 7:32 GMT+02:00 Clemens Eisserer linuxhi...@gmail.com: Hello, Please review my fix for JDK-8054638 xrender: text drawn after setColor(Color.white) is actually black. The