Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

2016-06-13 Thread Jim Graham
Hi Jay, You still don't check the read() calls in the length case to see if you reached EOF (-1). The potential for an infinite loop is still there. Also, you still search for an FF, even if you require the function to start at an SOI marker - all subsequent markers are still subject to a s

Re: [OpenJDK 2D-Dev] Review Request for JDK-6386906 : Faulty rounding code in BMPImageReader.decodeRLE4()

2016-06-13 Thread Jim Graham
Why use ceil() at all? If you want Math.ceil(intval/2.0f), use "((intval + 1) / 2)"... ...jim On 6/13/2016 7:00 AM, Jayathirth D V wrote: Hi, _Please review the following fix in JDK9:_ _ _ Bug : https://bugs.openjdk.java.net/browse/JDK-6386906 Webrev : http://c

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

2016-06-13 Thread Jayathirth D V
Hi Jim, Thanks for your valuable inputs. I have updated the code with your inputs: 1) We should check for complete SOI marker and not just "FF" at start of skipImage(). 2) There is no need of iis.read() which was happening in default case. iis.read() present in for loop check wil

[OpenJDK 2D-Dev] Review Request for JDK-6386906 : Faulty rounding code in BMPImageReader.decodeRLE4()

2016-06-13 Thread Jayathirth D V
Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-6386906 Webrev : http://cr.openjdk.java.net/~jdv/6386906/webrev.00/ Issue : We are dividing an integer with another integer and trying to perform ceil() on resultant value which will be an

Re: [OpenJDK 2D-Dev] RFR 8159093: Fix coding conventions in Marlin renderer

2016-06-13 Thread Laurent Bourgès
Jim, This MT issue concerns only statistics collection so I deliberately did not ensure thread safety to avoid a synchronized block as the code is still "safe". Anyway I can fix it in the next patch that will improve array cache and stats per rendering context. Laurent Le 11 juin 2016 01:59, "J