Hi Brian,
Thanks for your inputs.
I have updated the new bug https://bugs.openjdk.java.net/browse/JDK-8160327
with same comment.
Thanks,
Jay
From: Brian Burkhalter
Sent: Tuesday, June 28, 2016 12:41 AM
To: Philip Race
Cc: Jayathirth D V; 2d-dev@openjdk.java.net
Subject: Re:
Looks good to me. Only thing is in test script, you need to add
copyright 2015, 2016 as the script is originally written in 2015 and you
cannot omit the created year from the copyright.
Regards
Prasanta
On 6/27/2016 4:17 PM, Prahalad Kumar Narayanan wrote:
Hello Everyone
Good day to you.
Hi Kim,
The newest changes for jdk repos is [1].
Erik points we should use DISABLED_WARNINGS_gcc to handle unknown warning tags.
[2]
[1] is implemented with it.
This change is already reviewed by 2d folks.
So I want to merge it ASAP.
Do you have any objection?
Thanks,
Yasumasa
[1]
I agree, it looks more like an overflow error, but the new code is technically more correct so this is more of a comment
on their error reporting than on the resulting fix. If you ignore the "Werror=" part of the comment, it is true that
val overflows a signed int on the 127th iteration, which
This is odd that two completely different classes have identical "equals()" methods. After looking into it in more
detail it looks as if ComponentSM is implemented as a general case that can encompass either PixelInterleaved or Banded
pixel layouts - which means the subclasses are mostly just
I think these are all OK.
Regarding the AlphaMath change, I get that we may have
the use of signed int means the undefined result would
be for that .. but it doesn't seem to impact the loop
conditions so I don't understand why that causes a problem
for loop optimisation. Still, the change is
Build changes look ok.
/Erik
On 2016-06-27 15:55, Yasumasa Suenaga wrote:
Hi,
Erik commented that the changes in Awt2dLibraries.gmk should use
DISABLED_WARNINGS_gcc
parameter.
So I use it in new webrev.
Could you review it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8160294/webrev.01/
Hi,
Erik commented that the changes in Awt2dLibraries.gmk should use
DISABLED_WARNINGS_gcc
parameter.
So I use it in new webrev.
Could you review it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8160294/webrev.01/
Thanks,
Yasumasa
On 2016/06/26 11:14, Yasumasa Suenaga wrote:
Hi Phil,
Hi All,
Please review a fix for an issue where it was found that setting left
margin of 2" is ignored and when we query
PrinterJob.job.getPageFormat(PrintRequestAttributeSet)
we get the default paper mediapritable area of x=1" instead of the set 2".
Bug:
Hello Everyone
Good day to you.
Quick follow up to fix for the Bug
Bug ID : JDK-8152971
Bug Link : https://bugs.openjdk.java.net/browse/JDK-8152971
First, Thanks to Prasanta for his review & suggestions.
I 've incorporated some of the review suggestions & updated the webrev.
Hello,
I'm happy with the makefile changes, unless anyone else could come up
with a solution for any of the remaining warnings.
/Erik
On 2016-06-23 09:09, Ajit Ghaisas wrote:
Hi,
Bug :
https://bugs.openjdk.java.net/browse/JDK-8074824
(Resolve disabled warnings for libawt_xawt)
Hi Phil,
Thanks for your review.
I have removed all the references to "for JPEG with embedded thumbnail" and
updated the information in test case, description and file names.
Please find updated webrev for review:
http://cr.openjdk.java.net/~jdv/8152672/webrev.03/
I have created
I guess this method(s) should take "fontStrLC" instead of "fontStr"
650 (*env)->CallObjectMethod(env, fontToFileMap, fmi->putMID,
651 fontStr, fileStr);
692 (*env)->CallObjectMethod(env, fontToFileMap, fmi->putMID,
693
13 matches
Mail list logo
