It is not always clear to me what warning is being suppressed and why you have
chosen a particular solution/action
this next one looks like it might introduce an unused variable warning.
What was it solving ? That the code was not checking a return value ?
size_t bytesWritten = write (
I prefer meaningful test names .. the bug id is already in the @bug tag
and a test can later be updated to test > 1 bug.
Did you verify that you are in fact capturing stderr - even in
othervm mode - when running the test under jtreg ?
Even when setting up a new VM jtreg may capture this for you.
Thanks Jim for suggesting test should have its own VM. I agree with it.
Here is the updated webrev :
http://cr.openjdk.java.net/~aghaisas/8160421/webrev.01/
Phil, can you please review it?
Regards,
Ajit
-Original Message-
From: Jim Graham
Sent: Friday, July 01, 2016 5:13 AM
To: Ajit
Hi All,
Please review a fix for an issue where it is seen "Page range (From/To)
" field is not disabled for flavors such as postscript, image flavors.
PageRanges attribute is supported only for Service Formatted flavors
such as Pageable and Printable and so for
other flavors such as
No further comments from me Erik!
Looks good.
Thanks,
David
On 5/07/2016 4:44 PM, Erik Joelsson wrote:
Hello,
New webrev: http://cr.openjdk.java.net/~erikj/8003593/webrev.02/
Only change is the name of the suppress variable.
On 2016-07-04 03:02, David Holmes wrote:
Fix typo ...
On
Hello,
New webrev: http://cr.openjdk.java.net/~erikj/8003593/webrev.02/
Only change is the name of the suppress variable.
On 2016-07-04 03:02, David Holmes wrote:
Fix typo ...
On 4/07/2016 9:01 AM, David Holmes wrote:
Hi Erik,
Only nit with that is the "source" tend to imply source code
