Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

Hi Phil & Brian, Before this code change there was no check for abortRequested() right after processImagestarted() callback in GIFImageReader.java. After code change we are checking for abortRequested() right after processImagestarted(). So after this call there is no need to verify for abortRe

Re: [OpenJDK 2D-Dev] RFR: 8164818: Reg. test java/awt/font/TextLayout/VisibleAdvance.java fails

This one also looks good to me. - Original Message - From: prasanta.sadhuk...@oracle.com To: philip.r...@oracle.com, 2d-dev@openjdk.java.net Sent: Tuesday, August 30, 2016 11:55:43 PM GMT -08:00 US/Canada Pacific Subject: Re: [OpenJDK 2D-Dev] RFR: 8164818: Reg. test java/awt/font/TextLayo

Re: [OpenJDK 2D-Dev] RFR: 8144015: [PIT] failures of text layout font tests

Looks good to me! - Original Message - From: prasanta.sadhuk...@oracle.com To: philip.r...@oracle.com, 2d-dev@openjdk.java.net Sent: Wednesday, August 31, 2016 3:17:27 AM GMT -08:00 US/Canada Pacific Subject: Re: [OpenJDK 2D-Dev] RFR: 8144015: [PIT] failures of text layout font tests Loo

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

I don't understand why the change from while() { .. } to do { .. } while(..) was needed in GIFImageReader but then I don't see any harm in it either. Can you explain that one ? Also I'd like Brian to sign off on the TIFF change. Other than that all seems fine. -phil. On 8/31/16, 5:37 AM, Serg

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160327: Support for thumbnails present in APP1 marker for JPEG

imageCreationTime = LocalDateTime.parse(dateTime, formatter); Seems like it may throw DateTimeParseException - a subtype of RuntimeException https://docs.oracle.com/javase/8/docs/api/java/time/LocalDateTime.html#parse-java.lang.CharSequence-java.time.format.DateTimeFormatter- I think in the ca

Re: [OpenJDK 2D-Dev] [9] RFR 8165146 [PIT][TEST_BUG] Doubtful usability of java/awt/print/PrinterJob/TestMediaTraySelection.java

+1 -phil. On 8/31/2016 9:58 AM, Prasanta Sadhukhan wrote: Hi All, It seems there is a question mark on the usability of the testcase if the user does not have a printer that does not have multiple trays. The testcase might be useful for dev environment so removing @test tag to prevent it run

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate

911 public boolean printDialog(final PrintRequestAttributeSet attributes) ... 956 attributes.add(new DialogOwner((Frame)w)); So this now adds the DialogOwner to the attribute set passed by the application. This needs to be guaranteed to be removed again before the metho

[OpenJDK 2D-Dev] [9] RFR 8165146 [PIT][TEST_BUG] Doubtful usability of java/awt/print/PrinterJob/TestMediaTraySelection.java

Hi All, It seems there is a question mark on the usability of the testcase if the user does not have a printer that does not have multiple trays. The testcase might be useful for dev environment so removing @test tag to prevent it running from jtreg harness. Please review. hg diff test/java/

Re: [OpenJDK 2D-Dev] Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

+1 Vadim On 31.08.2016 16:05, Prem Balakrishnan wrote: Hi Vadim, Thankyou for the Review. I have updated the patch as per review comments, http://cr.openjdk.java.net/~pkbalakr/8144735/webrev.03/ >According to the comments in the

Re: [OpenJDK 2D-Dev] Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

Hi Vadim, Thankyou for the Review. I have updated the patch as per review comments, http://cr.openjdk.java.net/~pkbalakr/8144735/webrev.03/ >According to the comments in the TranslucentWindowPainter.createInstance you >will get BIWindowPainter even for OpenGL pipeline unless you forc

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

Thanks for the review Sergey. -Original Message- From: Sergey Bylokhov Sent: Wednesday, August 31, 2016 6:08 PM To: Jayathirth D V Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG On 31.08.16 14:48

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

On 31.08.16 14:48, Jayathirth D V wrote: Hi Sergey, In case of JPEG whole read process is under a ThreadLock. public BufferedImage read(int imageIndex, ImageReadParam param) throws IOException { setThreadLock(); try { cbLock.check(); try {

Re: [OpenJDK 2D-Dev] Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

Prem, I believe it's possible to use AccelSurface.getBounds() method and skip casting to SurfaceData completely. The calculations are basically the same. According to the comments in the TranslucentWindowPainter.createInstance you will get BIWindowPainter even for OpenGL pipeline unless you f

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

Hi Sergey, In case of JPEG whole read process is under a ThreadLock. public BufferedImage read(int imageIndex, ImageReadParam param) throws IOException { setThreadLock(); try { cbLock.check(); try { readInternal(imageIndex, param,

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

I have only one question: should we call the new clearNativeReadAbortFlag(and probably the others processXXX()) under the ThreadLock? On 31.08.16 13:07, Jayathirth D V wrote: Hi Sergey, Thanks for the clarification. I have updated the test case to use Files.delete(). Please find updated webre

Re: [OpenJDK 2D-Dev] RFR: 8144015: [PIT] failures of text layout font tests

Looks ok to me. Regards Prasanta On 8/26/2016 2:40 AM, Phil Race wrote: Webrev: http://cr.openjdk.java.net/~prr/8144015/ This RFR encompasses changes that are sufficiently related to keep them all together and they deserve testing as a whole. Multiple test failures are resolved. A list is belo

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

Hi Sergey, Thanks for the clarification. I have updated the test case to use Files.delete(). Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/4924727/webrev.02/ Regards, Jay -Original Message- From: Sergey Bylokhov Sent: Monday, August 29, 2016 8:52 PM To: Jayathi