Re: [OpenJDK 2D-Dev] [9] RFR JDK-8154075: [TIFF] AIOOB Exception from TIFFLZWDecompressor

2016-09-01 Thread Brian Burkhalter
I did not notice that. It is indeed bizarre. I was trying to take some calculations outside the loops to obtain a small performance improvement and did not notice the name transposition. I’ll update it. Thanks, Brian On Sep 1, 2016, at 1:27 PM, Phil Race wrote: > 168

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8154075: [TIFF] AIOOB Exception from TIFFLZWDecompressor

2016-09-01 Thread Phil Race
168 int gain = step * srcWidth; 169 int bound = srcWidth * step; This looks odd. Is it what you meant ? -phil. On 09/01/2016 08:57 AM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8154075 Patch:

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160327: Support for thumbnails present in APP1 marker for JPEG

2016-09-01 Thread Brian Burkhalter
Did not hit “reply to all” … . Begin forwarded message: > From: Brian Burkhalter > Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160327: Support for thumbnails > present in APP1 marker for JPEG > Date: August 31, 2016 at 5:02:42 PM PDT > To: Philip Race

Re: [OpenJDK 2D-Dev] [8u Backport] Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

2016-09-01 Thread Jim Graham
Hi Ajit, In the cases where you "continue" on a non-finite slope, doesn't that mean that the edges will be mismatched? If you can't determine the bounding polygon, perhaps the entire operation should be aborted instead...? It's different from the case of dy1==dy2 which also results in a

[OpenJDK 2D-Dev] [9] RFR JDK-8154075: [TIFF] AIOOB Exception from TIFFLZWDecompressor

2016-09-01 Thread Brian Burkhalter
Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8154075 Patch: http://cr.openjdk.java.net/~bpb/8154075/webrev.00/ For banded images make sure the step in the horizontal differencing predictor calculations for Deflate and LZW compression is unity (1) instead

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate

2016-09-01 Thread Prasanta Sadhukhan
Hi Phil, Please find the modified webrev http://cr.openjdk.java.net/~psadhukhan/7064425/webrev.02/ This takes care of removing DialogOwner attribute before printDialog returns. However, I could not use the same optimisation in WPrinterJob as mentioned >>/WPrintDialog dialog = new

[OpenJDK 2D-Dev] [8u Backport] Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

2016-09-01 Thread Ajit Ghaisas
Hi, This is a review request for 8u back-port of the fix done in JDK-9. Bug : https://bugs.openjdk.java.net/browse/JDK-8158356 Root cause : The root cause of the crash is - NaN is converted to an integer and used as array index in mlib_ImageScanPoly.c. Fix : The

Re: [OpenJDK 2D-Dev] [9] RFR 4885375: Page Ranges 'To Page' field must be populated based on Pageable

2016-09-01 Thread Jayathirth D V
Hi Prasanta,   Changes are working fine.   Thanks, Jay   From: Philip Race Sent: Wednesday, August 24, 2016 11:12 PM To: Prasanta Sadhukhan Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR 4885375: Page Ranges 'To Page' field must be populated based on Pageable   OK that is what I (sort

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

2016-09-01 Thread Jayathirth D V
Hi Phil & Brian, Before this code change there was no check for abortRequested() right after processImagestarted() callback in GIFImageReader.java. After code change we are checking for abortRequested() right after processImagestarted(). So after this call there is no need to verify for