Re: [OpenJDK 2D-Dev] Regression test failures - could not find entries in JDK Bug System

2016-10-03 Thread Vitaly Provodin
Philip, Anyway, thanks for the advise. Thanks, Vitaly > On 03 Oct 2016, at 22:35, Philip Race wrote: > > This seems to be a question that is not specific to the client tests > even if the examples are. And I have no idea about these testresults files > > So I think

Re: [OpenJDK 2D-Dev] HiDPI support issues on Windows

2016-10-03 Thread Jim Graham
Hi Anton, Yes, the numbers you are describing are consistent with performing that standard boilerplate using an origin/translate that is not exactly at an integer pixel location. My comments about our mechanisms not allowing for scale-aware allocations can be dealt with in a couple of ways:

Re: [OpenJDK 2D-Dev] HiDPI support issues on Windows

2016-10-03 Thread Anton Tarasov
Hi Jim, Thank you for the details! This gives a clue. Anton. On 10/2/2016 10:10 PM, Jim Graham wrote: After looking into the code in RepaintManager and re-reading Alexander's message again I can see how it describes what is going on more clearly. Fixing the rounding errors doesn't

Re: [OpenJDK 2D-Dev] HiDPI support issues on Windows

2016-10-03 Thread Anton Tarasov
Hi Alexandr, I looked at the testcase 8162350 closely and found your explanation below not quite precise... When you repaint a letter with an slightly expanded dirty rect, you've got it as [40-1, 0-1, 80+2, 60+2] = [39, -1, 82, 62]. Let's count only "x". As Jim noted, the code to draw is:

Re: [OpenJDK 2D-Dev] RFR: 8165981: Consider making some classes in javax.imageio.plugins.tiff final

2016-10-03 Thread Phil Race
Ok to the two you are making final. > Question is whether TIFFDirectory might be made final as well. com.sun.imageio.plugins.tiff.TIFFIFD extends TIFFDirectory so that is more than a case of marking it final. Therefore it at least depends on whether you think that internal subclass really

[OpenJDK 2D-Dev] RFR: 8165981: Consider making some classes in javax.imageio.plugins.tiff final

2016-10-03 Thread Brian Burkhalter
A trivial change, code-wise: --- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFField.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFField.java @@ -261,7 +261,7 @@ * @see TIFFDirectory * @see TIFFTag */ -public class TIFFField implements

[OpenJDK 2D-Dev] Regression test failures - could not find entries in JDK Bug System

2016-10-03 Thread Vitaly Provodin
Hello, My question relates to failures of the Regression tests (jdk/test) on OpenJDK8 and how to identify whether a failure is expected or not. Running java/awt and javax/swing tests against OpenJDK8 on various platforms I got some failures. Trying to find any explanations for these failures I