Re: [OpenJDK 2D-Dev] RFR: 8200129 : Remove D3D Performance Counter.

2018-03-22 Thread mandy chung
+1 Mandy On 3/22/18 1:33 PM, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8200129 webrev: http://cr.openjdk.java.net/~prr/8200129/ It was noted in another thread [1] that we had a couple of qualified exports from java.base to java.desktop that are platform-specific but are

Re: [OpenJDK 2D-Dev] RFR: 8200129 : Remove D3D Performance Counter.

2018-03-22 Thread Alan Bateman
On 22/03/2018 20:33, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8200129 webrev: http://cr.openjdk.java.net/~prr/8200129/ This looks okay to me. -Alan

Re: [OpenJDK 2D-Dev] RFR: 8200129 : Remove D3D Performance Counter.

2018-03-22 Thread Sergey Bylokhov
Looks fine. On 22/03/2018 13:33, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8200129 webrev: http://cr.openjdk.java.net/~prr/8200129/ It was noted in another thread [1] that we had a couple of qualified exports from java.base to java.desktop that are platform-specific but

Re: [OpenJDK 2D-Dev] RFR 8199789: Emit a warning message when t2k is selected via system property

2018-03-22 Thread Sergey Bylokhov
+1 On 20/03/2018 19:42, Prahalad Kumar Narayanan wrote: Hello Phil Good day to you. Thank you for the explanation. I understand your point now. The code changes look good. Thank you Have a good day Prahalad N. - Original Message - From: Phil Race Sent: Wednesday, March 21, 2018

[OpenJDK 2D-Dev] RFR: 8200129 : Remove D3D Performance Counter.

2018-03-22 Thread Phil Race
bug: https://bugs.openjdk.java.net/browse/JDK-8200129 webrev: http://cr.openjdk.java.net/~prr/8200129/ It was noted in another thread [1] that we had a couple of qualified exports from java.base to java.desktop that are platform-specific but are in the main module-info.java. It was suggested to

Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

2018-03-22 Thread Alex Menkov
Hi Magnus, the fix looks good to me. --alex On 03/22/2018 00:41, Magnus Ihse Bursie wrote: On 2018-03-21 19:08, Alex Menkov wrote: Hi Magnus, > I have tested the following: >   * On my linux machine, failure to load libjsound.so was not fatal. In Platform.java:   54

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

2018-03-22 Thread Adam Farley8
Hi Guys, I've provided a gcc-specific fix in the makefile to prevent the warning. -- Awt2dLibraries.gmk:471 -- DISABLED_WARNINGS_gcc := array-bounds clobbered implicit-fallthrough shift-negative-value, \ I've also provided an underflow fix in the .c file to fix the problem *causing* the

Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

2018-03-22 Thread Magnus Ihse Bursie
On 2018-03-21 19:08, Alex Menkov wrote: Hi Magnus, > I have tested the following: >   * On my linux machine, failure to load libjsound.so was not fatal. In Platform.java:   54 loadLibraries();   55 readProperties(); and readProperties calls native nIsBigEndian if libjsound