Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

2018-12-05 Thread Phil Race
But what I am saying is we should not return a NULL string reference from native. You are still allowing that and then having to handle it in Java code. And FWIW you can return a zero length array as well so there isn't a NULL array reference to deal with either. -phil. On 12/3/18 8:29 AM, Shas

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java

2018-12-05 Thread Alexey Ivanov
Hi Jay, “modified UTF-8” had space before but it doesn't. Otherwise, looks good. Regards, Alexey On 05/12/2018 12:35, Jayathirth D V wrote: Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8214817 Webrev : http://cr.openjdk.java.net/~jdv/

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file

2018-12-05 Thread Philip Race
OpenJDK has no LTS releases. That's an Oracle JDK thing for which you need a support contract .. If you use free OpenJDK you can only use the latest. Others might provide an LTS but they aren't likely to include random backports on demand either . -phil. On 12/5/18, 2:53 AM, Jan Vomlel wrote:

[OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214876: Add "intermittent" key for imageio/stream/StreamCloserLeak/run_test.sh

2018-12-05 Thread Jayathirth D V
Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8214876 Webrev : http://cr.openjdk.java.net/~jdv/8214876/webrev.00/ I have not added JBS bug id under @bug since it is a trivial test change. Thanks, Jay

[OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java

2018-12-05 Thread Jayathirth D V
Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8214817 Webrev : http://cr.openjdk.java.net/~jdv/8214817/webrev.00/ Thanks, Jay

[OpenJDK 2D-Dev] [12] RFR JDK-8213050: simpleTagLabel before is not getting generated properly

2018-12-05 Thread Jayathirth D V
Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8213050 Webrev : http://cr.openjdk.java.net/~jdv/8213050/webrev.00/ Issue : Markup corrector tidy is throwing issues in files bmp_metadata.html, wbmp_metadata.html & tiff_metadata.htm

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file

2018-12-05 Thread Jan Vomlel
Thank you Jayathirth for bug resolution. I think it is ok, but can you fix it also in version 11? It is LTS version and we would like to use it for our project. Jan