Re: [OpenJDK 2D-Dev] RFR[14]: JDK-8230728 : Thin stroked shapes are not rendered if affine transform has flip bit

+1. Thanks, Jay > On 10-Sep-2019, at 3:18 AM, Phil Race wrote: > > Approved. > > -phil. > > On 9/6/19 2:15 PM, Laurent Bourgès wrote: >> Hi, >> >> Please review this bug fix for the Marlin renderer (present in Pisces code >> since JDK 6?): >> JBS:

Re: [OpenJDK 2D-Dev] RFR[14]: JDK-8230728 : Thin stroked shapes are not rendered if affine transform has flip bit

Hi Phil, Is this fix trivial enough to have only one reviewer ? So I can push asap. Laurent Le lun. 9 sept. 2019 à 23:50, Phil Race a écrit : > Approved. > > -phil. > > On 9/6/19 2:15 PM, Laurent Bourgès wrote: > > Hi, > > Please review this bug fix for the Marlin renderer (present in Pisces

Re: [OpenJDK 2D-Dev] [13] Review Request: 8225372 accessibility errors in tables in java.desktop files

Hi, Alexey. Thank you for the review, here is an updated version: http://cr.openjdk.java.net/~serb/8225372/webrev.03 - GridBagLayout.html: The text about "Figures 1 and 2" was changed - componentProperties.html: The is added to some of the tables - Modality.html: The was dropped from

Re: [OpenJDK 2D-Dev] RFR[14]: JDK-8230728 : Thin stroked shapes are not rendered if affine transform has flip bit

Approved. -phil. On 9/6/19 2:15 PM, Laurent Bourgès wrote: Hi, Please review this bug fix for the Marlin renderer (present in Pisces code since JDK 6?): JBS: https://bugs.openjdk.java.net/browse/JDK-8230728 webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/ This patch

Re: [OpenJDK 2D-Dev] [14] Review Request: 8229896 Delete an unused code in the BufferedContext

Approved. -phil. On 9/8/19 2:42 PM, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8229896 Fix: http://cr.openjdk.java.net/~serb/8229896/webrev.01 During developments of the early version of JavaFX some code was added to the

Re: [OpenJDK 2D-Dev] RFR [XS] 8230769: BufImg_SetupICM add ReleasePrimitiveArrayCritical call in early return

Looks good to me. How did you spot this ? The error code path is unlikely to be taken so checking for JNI warnings presumably won't report it. -phil On 9/9/19 7:49 AM, Baesken, Matthias wrote: Hello,   please review the following  webrev . I noticed that  in function  BufImg_SetupICM, in

[OpenJDK 2D-Dev] RFR [XS] 8230769: BufImg_SetupICM add ReleasePrimitiveArrayCritical call in early return

Hello, please review the following webrev . I noticed that in function BufImg_SetupICM, in case of initCubemap returning NULL we currently miss a ReleasePrimitiveArrayCritical call; this should be added. Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8230769

Re: [OpenJDK 2D-Dev] RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file

Hi Christoph, thanks for the review and further cleanup ! > Would be good if somebody from 2D could review this, though. I agree ! Best regards, Matthias From: Langer, Christoph Sent: Freitag, 6. September 2019 15:42 To: Baesken, Matthias ; 2d-dev@openjdk.java.net Subject: RE: RFR [XS] :