Re: [OpenJDK 2D-Dev] JDK 14 RFR of JDK-8231334: Suppress warnings on non-serializable instance fields in client libs serializable classes

2019-09-23 Thread Joe Darcy
Hi Phil, On 9/22/2019 1:25 PM, Philip Race wrote: + @SuppressWarnings("serial") // Not statically typed as Serializable So is the comment being used to distinguish this overloading of what "serial" means ? Why not introduce a new warning category ? The -Xlint:serial check in javac has had

[OpenJDK 2D-Dev] RFR: 8230873 [AIX] GUI app does work with UTF-8 locale on minimum software requirements

2019-09-23 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8230873 Change: https://cr.openjdk.java.net/~itakiguchi/8230873/webrev.00/ GUI application does not work with AIX's JA_JP UTF-8 locale on minimum software requirements and settings because of following exception:

Re: [OpenJDK 2D-Dev] RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file

2019-09-23 Thread Philip Race
Yes, approved. -phil. On 9/23/19, 6:35 AM, Langer, Christoph wrote: Hi Phil, thanks for your review. I changed this usage of Scanner by intention. Scanner implements Closeable/AutoCloseable and hence I think it's preferable to close the scanner after usage. That's what the try-with-resourc

Re: [OpenJDK 2D-Dev] RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file

2019-09-23 Thread Langer, Christoph
Hi Phil, thanks for your review. I changed this usage of Scanner by intention. Scanner implements Closeable/AutoCloseable and hence I think it's preferable to close the scanner after usage. That's what the try-with-resources construct will do. It'll take care that the underlying filestream