Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to FontUtilities.java

2020-07-10 Thread Philip Race
That is a good question. I am not sure any more how we ended up with the mixed usage but isLogging() seems appropriate to guard the call to log. So maybe make them consistent for all cases that make sense. If the end result of that is there is no other usage that calls debugFonts() that might

Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to FontUtilities.java

2020-07-10 Thread Baesken, Matthias
Hi Phil, okay get your point , thanks for clarification about avoiding the string concatenation if FontUtilities.isLogging() returns false . But I guess the coding guarded by FontUtilities.debugFonts() for example : src/java.desktop/share/classes/sun/awt/FontConfiguration.java-85-