> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Make getShell32Icon method return multi-resolition image in case of
requested icon size and actual icon size mismatch.
-
On Tue, 11 May 2021 20:01:37 GMT, Alexey Ivanov wrote:
>> Wherever it is necessary down the line we are wrapping the result in
>> multi-resolution and if we wrap it here too we will have multi-resolution
>> icon that contains multi-resolution images as a resolution variant.
>> Unfortunately
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Slightly changing javadoc wording
Removing unnecessary boxing of int
Releasing the pIcon in native code properly
-
On Tue, 11 May 2021 10:07:30 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Tue, 11 May 2021 18:48:31 GMT, Alexander Zuev wrote:
>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line
>> 1196:
>>
>>> 1194: Image icon = makeIcon(hIcon);
>>> 1195: disposeIcon(hIcon);
>>> 1196: return icon;
>>
>> Shall it not
On Tue, 11 May 2021 18:50:13 GMT, Alexander Zuev wrote:
>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line
>> 1192:
>>
>>> 1190: */
>>> 1191: static Image getShell32Icon(int iconID, int size) {
>>> 1192: long hIcon = getIconResource("shell32.dll",
On Tue, 11 May 2021 10:53:06 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Fri, 7 May 2021 22:29:53 GMT, Alexey Ushakov wrote:
> Implemented indirect rendering (via stencil texture attachment) to stencil
> texture
src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLClip.h line 52:
> 50: @property (readonly) id stencilTextureRef;
> 51: @property (readonly)
On Sat, 8 May 2021 00:19:21 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The
On Fri, 7 May 2021 17:30:15 GMT, Alexander Zuev wrote:
>> src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java line 213:
>>
>>> 211: * Returns the icon of the specified size used to display this
>>> shell folder.
>>> 212: *
>>> 213: * @param size size of the icon > 0
On Sat, 8 May 2021 00:19:21 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The
On Fri, 7 May 2021 22:29:53 GMT, Alexey Ushakov wrote:
> Implemented indirect rendering (via stencil texture attachment) to stencil
> texture
Its good that we have removed intermediate stencil blit operations using this
approach.
LGTM.
jtreg/JCK all test run is fine.
J2DDemo, SwingSet2,
12 matches
Mail list logo
