Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8217707: JNICALL declaration breaks Splash screen functions

2019-04-08 Thread Sergey Bylokhov
Looks fine. On 24/03/2019 12:18, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13. bug: https://bugs.openjdk.java.net/browse/JDK-8217707 webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/ Description: Splash screen functionality is broken in 32 bit Windows. It's because th

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8217707: JNICALL declaration breaks Splash screen functions

2019-03-28 Thread Alexey Ivanov
On 28/03/2019 17:15, Philip Race wrote: > I've run SplashScreen jtreg tests, all tests pass. I assume you mean you did this for 32 AND 64 bit builds ? Yes, I ran the tests for both 32 and 64 bit builds. -- Alexey If so, then +1 -phil. On 3/28/19, 9:11 AM, Alexey Ivanov wrote: Any volunt

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8217707: JNICALL declaration breaks Splash screen functions

2019-03-28 Thread Thomas Stüfe
Looks fine. Cheers, Thomas On Thu, Mar 28, 2019 at 5:11 PM Alexey Ivanov wrote: > Any volunteers for review? > > On 24/03/2019 19:18, Alexey Ivanov wrote: > > Hi, > > > > Please review the fix for jdk 13. > > > > bug: https://bugs.openjdk.java.net/browse/JDK-8217707 > > webrev: http://cr.openjd

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8217707: JNICALL declaration breaks Splash screen functions

2019-03-28 Thread Philip Race
> I've run SplashScreen jtreg tests, all tests pass. I assume you mean you did this for 32 AND 64 bit builds ? If so, then +1 -phil. On 3/28/19, 9:11 AM, Alexey Ivanov wrote: Any volunteers for review? On 24/03/2019 19:18, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13. bug: ht

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8217707: JNICALL declaration breaks Splash screen functions

2019-03-28 Thread Alexey Ivanov
Any volunteers for review? On 24/03/2019 19:18, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13. bug: https://bugs.openjdk.java.net/browse/JDK-8217707 webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/ Description: Splash screen functionality is broken in 32 bit Windows.

[OpenJDK 2D-Dev] [13] RFR: JDK-8217707: JNICALL declaration breaks Splash screen functions

2019-03-24 Thread Alexey Ivanov
Hi, Please review the fix for jdk 13. bug: https://bugs.openjdk.java.net/browse/JDK-8217707 webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/ Description: Splash screen functionality is broken in 32 bit Windows. It's because the functions in splashscreen.dll are exported with decor