Hi,
I am not happy with approving this until I have had a chance to review
1) The actual warnings from tidy
2) The effect on the generated javadoc.
I think P adds extra space that br does not, so don't jump to
conclusions
about what the original author was trying to achieve.
-phil.
On
Sergey, you are right, in some cases (i.e.
at the end of package-summary.html)
the closing tag /p works exactly like br.
I can submit another change; note however, that /p is not
mandatory for p; br works exactly like /p here;
and line break was the intention of the author.
Should I make new
Hi Joe.
In most cases the author used this stray p as a line break.
A line break is necessary indeed but if it is followed by a block
element, it is considered erroneous by tidy.
So adding br does, in fact, better correspond to the author original
idea.
On Wednesday, November 20, 2013
Hi all,
please review the fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8028272
webrev : http://cr.openjdk.java.net/~yan/8028272/webrev.00/
This patch cleanup tidy warnings for generated html documentation for
javax.print package, and do not affect the appearance of the documentation.
The
Hello,
I'm not an HTML expert, but it seems preferable to me to just remove an
unnecessary p tag rather than replacing it with br/.
Is there a reason to prefer br/?
Otherwise the changes look fine.
Thanks,
-Joe
On 11/20/2013 1:47 AM, Sergey Lugovoy wrote:
Hi all,
please review the fix.
Hi Joe,
there seems to be several reasons:
-- in some cases this p just adds an extra line between items in
successive ul construction. Remove the p, and these lis will
stay as close to each other as regular lines in the document.
Which means too close, or did mean for original author of the
