Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

ok. +1 Regards Prasanta On 1/24/2017 12:04 PM, dmitry markov wrote: Hi Prasanta, Please find my answer inline. Thanks, Dmitry On 24/01/2017 08:29, Prasanta Sadhukhan wrote: Hi Dmitri, On 1/23/2017 11:52 PM, Dmitry Markov wrote: Hi Prasanta, As far as I know imageDataProvider_UnholdJavaPi

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Hi Prasanta, Please find my answer inline. Thanks, Dmitry On 24/01/2017 08:29, Prasanta Sadhukhan wrote: Hi Dmitri, On 1/23/2017 11:52 PM, Dmitry Markov wrote: Hi Prasanta, As far as I know imageDataProvider_UnholdJavaPixels() is only invoked for images with ‘custom’ type. We read the dat

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Hi Dmitri, On 1/23/2017 11:52 PM, Dmitry Markov wrote: Hi Prasanta, As far as I know imageDataProvider_UnholdJavaPixels() is only invoked for images with ‘custom’ type. We read the data directly from Java memory for such images. I understand that but my question was coming from the fact that

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Hi Prasanta, As far as I know imageDataProvider_UnholdJavaPixels() is only invoked for images with ‘custom’ type. We read the data directly from Java memory for such images. At the same time for other image types we use Get/ReleasePrimitiveArrayCritical() and copy the data from Java to native

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Hi Dmitry, Any particular reason why in imageDataProvider_UnholdJavaPixels(), we are not doing isdo->pixels = null; which we do in unholdJavaPixels() since in holdJavaPixels() , we are doing 967 else if (isdo->pixels == NULL) 968 { 969 isdo->pixels = (Pixel8bit*)((*env)->Ge

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Thank you very much, Phil! Looking for the second +1 from someone else. Dmitry > On 21 Jan 2017, at 22:39, Philip Race wrote: > > +1 > > -phil > > On 1/21/17, 11:05 AM, Dmitry Markov wrote: >> >> Hi Phil, >> >> I agree ‘othervm’ is not necessary here. That is ‘copy-paste’ error. >> Also I u

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

+1 -phil On 1/21/17, 11:05 AM, Dmitry Markov wrote: Hi Phil, I agree ‘othervm’ is not necessary here. That is ‘copy-paste’ error. Also I updated the part related to the file deletion based on your suggestion. Please find new webrev here: http://cr.openjdk.java.net/~dmarkov/8163889/webrev.02/

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Hi Phil, I agree ‘othervm’ is not necessary here. That is ‘copy-paste’ error. Also I updated the part related to the file deletion based on your suggestion. Please find new webrev here: http://cr.openjdk.java.net/~dmarkov/8163889/webrev.02/

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Hi Dmitry, > 29 * @run main/othervm PrintCrashTest why othervm ? I don't think that is strictly necessary just because you are using deleteOnExit. And FWIW I think the test could "more promptly" delete the file anyway after print returns. -phil. On 1/20/17, 9:36 AM, Dmitry Markov wrote:

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Hi Phil, Prasanta, I have updated the fix as you suggested, (i.e. added the regression test). The new webrev is located at http://cr.openjdk.java.net/~dmarkov/8163889/webrev.01/ Could you review the new version, please? Thanks, Dmitry > On 20 Jan 2017, at 19:50, Phil Race wrote: > > I haven't

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

I haven't looked at the fix (yet) but I definitely agree that a manual regression test for this is better than none. What else should we do ? Just not test printing ? In my view which I've expressed to SQE for a really long time, if you aren't testing with printers installed you aren't testin

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Hi Dmitri, Ok. I think it will be good to add a testcase (since bug already has a reproducible test) and since its a print problem, anyone who runs it has to install printer to verify so no excuse there :-) or if you can find any other existing testcase which showcase this crash problem, you c

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Hi Prasanta, Thank you for your feedback. Actually there are two problems here: JDK-8163889 is devoted to the crash/assert error and JDK-8173050 which is about possible lack of support for th

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Hi Dmitri, Don't you need to implement syncFromCustom() and syncToCustom()? If not, then it seems you do not need to call this functions from customPixelsFromJava() and customPixelsToJava() in which case, then env change/fix will not be needed. Also, is it not possible to create a regression t

[OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

Hello, Could you review a fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8163889 webrev: http://cr.openjdk.java.net/~dmarkov/8163889/webrev.00/ Problem description: Several functions inside ImageSurfaceData.m, (e.g. customPixelsFromJava(), customPixelsToJava