Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog [v2]

2021-06-30 Thread Jayathirth D V
On Wed, 30 Jun 2021 14:37:31 GMT, Jayathirth D V wrote: >> Final blit operation in MTLLayer.blitTexture() is driven by CVDisplayLink in >> Metal. >> In this test case we are hitting an invalid condition because of which we >> exit from MTLLayer.blitTexture(), but we are not stopping the

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog [v2]

2021-06-30 Thread Ajit Ghaisas
On Wed, 30 Jun 2021 14:37:31 GMT, Jayathirth D V wrote: >> Final blit operation in MTLLayer.blitTexture() is driven by CVDisplayLink in >> Metal. >> In this test case we are hitting an invalid condition because of which we >> exit from MTLLayer.blitTexture(), but we are not stopping the

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog [v2]

2021-06-30 Thread Sergey Bylokhov
On Wed, 30 Jun 2021 08:09:28 GMT, Jayathirth D V wrote: >> No, I meant if we dispose the frame/exist from the app/etc before >> "Java_sun_java2d_metal_MTLLayer_blitTexture" method is executed but after we >> call "startDisplayLink", when we will call the stopDisplayLink in this case? > >

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog [v2]

2021-06-30 Thread Sergey Bylokhov
On Wed, 30 Jun 2021 14:37:31 GMT, Jayathirth D V wrote: >> Final blit operation in MTLLayer.blitTexture() is driven by CVDisplayLink in >> Metal. >> In this test case we are hitting an invalid condition because of which we >> exit from MTLLayer.blitTexture(), but we are not stopping the

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog [v2]

2021-06-30 Thread Jayathirth D V
> Final blit operation in MTLLayer.blitTexture() is driven by CVDisplayLink in > Metal. > In this test case we are hitting an invalid condition because of which we > exit from MTLLayer.blitTexture(), but we are not stopping the CVDisplayLink. > This is causing the CVDisplayLink callback to run

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog

2021-06-30 Thread Jayathirth D V
On Wed, 30 Jun 2021 11:36:18 GMT, Ajit Ghaisas wrote: >> Final blit operation in MTLLayer.blitTexture() is driven by CVDisplayLink in >> Metal. >> In this test case we are hitting an invalid condition because of which we >> exit from MTLLayer.blitTexture(), but we are not stopping the

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog

2021-06-30 Thread Ajit Ghaisas
On Tue, 29 Jun 2021 17:34:00 GMT, Jayathirth D V wrote: > Final blit operation in MTLLayer.blitTexture() is driven by CVDisplayLink in > Metal. > In this test case we are hitting an invalid condition because of which we > exit from MTLLayer.blitTexture(), but we are not stopping the

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog

2021-06-30 Thread Jayathirth D V
On Tue, 29 Jun 2021 23:28:44 GMT, Sergey Bylokhov wrote: > Please confirm that mach5 is green. @mrserb Yes CI test run is green. Test link in JBS. - PR: https://git.openjdk.java.net/jdk17/pull/175

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog

2021-06-30 Thread Jayathirth D V
On Wed, 30 Jun 2021 04:29:56 GMT, Sergey Bylokhov wrote: >> At this point if we exit, we just return and unlock MTLRenderQueue for >> backbuffer rendering. And when it is done we again start CVDisplayLink in >> MTLRenderQueue which in turn calls setNeedsDisplay to get callback to >>

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog

2021-06-29 Thread Jayathirth D V
On Wed, 30 Jun 2021 04:29:56 GMT, Sergey Bylokhov wrote: >> At this point if we exit, we just return and unlock MTLRenderQueue for >> backbuffer rendering. And when it is done we again start CVDisplayLink in >> MTLRenderQueue which in turn calls setNeedsDisplay to get callback to >>

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog

2021-06-29 Thread Sergey Bylokhov
On Wed, 30 Jun 2021 04:00:54 GMT, Jayathirth D V wrote: >> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.m line 286: >> >>> 284: if (layer == NULL || ctx == NULL) { >>> 285: J2dTraceLn(J2D_TRACE_VERBOSE, "MTLLayer_blit : Layer or >>> Context is null"); >>> 286:

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog

2021-06-29 Thread Jayathirth D V
On Tue, 29 Jun 2021 23:31:33 GMT, Sergey Bylokhov wrote: >> Final blit operation in MTLLayer.blitTexture() is driven by CVDisplayLink in >> Metal. >> In this test case we are hitting an invalid condition because of which we >> exit from MTLLayer.blitTexture(), but we are not stopping the

Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog

2021-06-29 Thread Sergey Bylokhov
On Tue, 29 Jun 2021 17:34:00 GMT, Jayathirth D V wrote: > Final blit operation in MTLLayer.blitTexture() is driven by CVDisplayLink in > Metal. > In this test case we are hitting an invalid condition because of which we > exit from MTLLayer.blitTexture(), but we are not stopping the

[OpenJDK 2D-Dev] [jdk17] RFR: 8267602: [macos] [lanai] java/awt/PrintJob/Text/stringwidth.sh doesn't exit on cancelling print dialog

2021-06-29 Thread Jayathirth D V
Final blit operation in MTLLayer.blitTexture() is driven by CVDisplayLink in Metal. In this test case we are hitting an invalid condition because of which we exit from MTLLayer.blitTexture(), but we are not stopping the CVDisplayLink. This is causing the CVDisplayLink callback to run in loop.