That is fine.
-phil.
On 2/21/18, 9:34 AM, Sergey Bylokhov wrote:
On 21/02/2018 08:49, Philip Race wrote:
I am not sure it has mac specific code, I'll reevaluate this test in
JDK-8198406.
This is mac-specific. It looks for specific fonts by name that exist
only on MacOS.
And moreover the tab
On 21/02/2018 08:49, Philip Race wrote:
I am not sure it has mac specific code, I'll reevaluate this test in
JDK-8198406.
This is mac-specific. It looks for specific fonts by name that exist
only on MacOS.
And moreover the table handling in the implementation is relevant only
for Apple AAT fo
On 2/21/18, 7:45 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
I have updated the tests mentioned in your previous email:
http://cr.openjdk.java.net/~serb/8198333/webrev.10
/java/awt/font/TextLayout/TestAATMorxFont.java should be for mac only
if (!osName.startsWith("mac")) {
42 ret
I am not sure that it is useful to add a bugid when the test is moved or
some tags are updated or some small bugs fixed in the test.
The @bug tag contains a bugid for which it was written or an bugid which
was found by this test later.
It can contain the bugid of bugfix in the test if the fix w
looks ok. Only thing is the tests do not have the current bugid appended.
Regards
Prasanta
On 2/21/2018 9:15 PM, Sergey Bylokhov wrote:
Hi, Prasanta.
I have updated the tests mentioned in your previous email:
http://cr.openjdk.java.net/~serb/8198333/webrev.10
/java/awt/font/TextLayout/TestAATM
Hi, Prasanta.
I have updated the tests mentioned in your previous email:
http://cr.openjdk.java.net/~serb/8198333/webrev.10
/java/awt/font/TextLayout/TestAATMorxFont.java should be for mac only
if (!osName.startsWith("mac")) {
42 return;
43 }
I am not sure it has mac
Also, these test should have @requires os.family too
/java/awt/font/TextLayout/TestAATMorxFont.java should be for mac only
if (!osName.startsWith("mac")) {
42 return;
43 }
javax/print/PrintServiceLookup/CountPrintServices.java for linux only
if (!os.equals("linux")) {
Couple of points.
Shouldn't java/awt/List/SetBackgroundTest/SetBackgroundTest.java be run
only on solaris/linux as it tests
if (!isXAWT){
77 System.out.println(" this is XAWT-only test. ");
78 return;
79 }
java/awt/Toolkit/RealSync/Test.java has
System.ex
+1
-phil
On 02/20/2018 07:10 AM, Sergey Bylokhov wrote:
Hello.
Please review update of the tests for jdk11.
The goal is to make our testing as stable as possible and exclude any
unstable tests(I have started from the tests which may be run in the
headless mode).
Bug: https://bugs.openjdk.j
Hello.
Please review update of the tests for jdk11.
The goal is to make our testing as stable as possible and exclude any
unstable tests(I have started from the tests which may be run in the
headless mode).
Bug: https://bugs.openjdk.java.net/browse/JDK-8198333
Webrev can be found at: http://c
10 matches
Mail list logo
